home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 675751719

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/943#issuecomment-675751719 https://api.github.com/repos/simonw/datasette/issues/943 675751719 MDEyOklzc3VlQ29tbWVudDY3NTc1MTcxOQ== 9599 2020-08-18T22:30:27Z 2020-08-18T22:30:27Z OWNER

Right now calling datasette.app() instantiates an ASGI application - complete with a bunch of routes and wrappers - and returns that application object. Calling it twice instantiates another ASGI application.

I think a single Datasette instance should only ever create a single ASGI app - so the .app() method should cache the ASGI app that it returns the first time and return the same application again on future calls.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
681375466  
Powered by Datasette · Queries took 0.858ms · About: github-to-sqlite