home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 675752436

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/943#issuecomment-675752436 https://api.github.com/repos/simonw/datasette/issues/943 675752436 MDEyOklzc3VlQ29tbWVudDY3NTc1MjQzNg== 9599 2020-08-18T22:32:44Z 2020-08-18T22:32:44Z OWNER

One thing to consider here: Datasette's table and database name escaping rules can be a little bit convoluted.

If a plugin wants to get back the first five rows of a table, it will need to construct a URL /dbname/tablename?_size=5 - but it will need to know how to turn the database and table names into the correctly escaped dbname and tablename values.

Here's how the row.html table handles that right now: https://github.com/simonw/datasette/blob/b21ed237ab940768574c834aa5a7130724bd3a2d/datasette/templates/row.html#L19-L23

It would be an improvement to have this logic abstracted out somewhere and documented so plugins can use it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
681375466  
Powered by Datasette · Queries took 1.208ms · About: github-to-sqlite