issue_comments: 683355993

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/957#issuecomment-683355993 https://api.github.com/repos/simonw/datasette/issues/957 683355993 MDEyOklzc3VlQ29tbWVudDY4MzM1NTk5Mw== 9599 2020-08-30T00:02:11Z 2020-08-30T00:04:18Z OWNER

I tried doing this and got this error: ``` (datasette) datasette % pytest ==================================================================== test session starts ===================================================================== platform darwin -- Python 3.8.5, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 rootdir: /Users/simon/Dropbox/Development/datasette, configfile: pytest.ini plugins: asyncio-0.14.0, timeout-1.4.2 collected 1 item / 23 errors

=========================================================================== ERRORS =========================================================================== _________ ERROR collecting tests/test_api.py ________ ImportError while importing test module '/Users/simon/Dropbox/Development/datasette/tests/testapi.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/test_api.py:1: in <module> from datasette.plugins import DEFAULT_PLUGINS datasette/init.py:2: in <module> from .app import Datasette datasette/app.py:30: in <module> from .views.base import DatasetteError, ureg datasette/views/base.py:12: in <module> from datasette.plugins import pm datasette/plugins.py:26: in <module> mod = importlib.import_module(plugin) /usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/init.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) datasette/publish/heroku.py:2: in <module> from datasette import hookimpl E ImportError: cannot import name 'hookimpl' from partially initialized module 'datasette' (most likely due to a circular import) (/Users/simon/Dropbox/Development/datasette/datasette/init.py) That's with `datasette/__init__.py` looking like this:python from datasette.version import version_info, version # noqa from .app import Datasette from .utils.asgi import Forbidden, NotFound, Response from .utils import actor_matches_allow, QueryInterrupted from .hookspecs import hookimpl # noqa from .hookspecs import hookspec # noqa

all = [ "actor_matches_allow", "hookimpl", "hookspec", "QueryInterrupted", "Forbidden", "NotFound", "Response", "Datasette", ] ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 688622148