home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 693003652

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/943#issuecomment-693003652 https://api.github.com/repos/simonw/datasette/issues/943 693003652 MDEyOklzc3VlQ29tbWVudDY5MzAwMzY1Mg== 9599 2020-09-15T22:03:08Z 2020-09-15T22:03:08Z OWNER

I'm not going to mess around with formats - you'll get back the exact response that a web client would receive.

Question: what should the response object look like? e.g. if you do:

response = await datasette.get("/db/table.json")

What should response be?

I could reuse the Datasette Response class from datasette.utils.asgi. This would work well for regular responses which just have a status code, some headers and a response body. It wouldn't be great for streaming responses though such as you get back from ?_stream=1 CSV exports.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
681375466  
Powered by Datasette · Queries took 1.039ms · About: github-to-sqlite