home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 693004296

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/943#issuecomment-693004296 https://api.github.com/repos/simonw/datasette/issues/943 693004296 MDEyOklzc3VlQ29tbWVudDY5MzAwNDI5Ng== 9599 2020-09-15T22:04:54Z 2020-09-15T22:04:54Z OWNER

So what should I do about streaming responses?

I could deliberately ignore them - through an exception if you attempt to run await datasette.get(...) against a streaming URL.

I could load the entire response into memory and return it as a wrapped object.

I could support some kind of asynchronous iterator mechanism. This would be pretty elegant if I could decide the right syntax for it - it would allow plugins to take advantage of other internal URLs that return streaming content without needing to load that content entirely into memory in order to process it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
681375466  
Powered by Datasette · Queries took 0.839ms · About: github-to-sqlite