home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 719983484

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1075#issuecomment-719983484 https://api.github.com/repos/simonw/datasette/issues/1075 719983484 MDEyOklzc3VlQ29tbWVudDcxOTk4MzQ4NA== 9599 2020-10-31T20:20:28Z 2020-10-31T20:20:28Z OWNER

It looks like this is specific to the way PrefixedUrlString is built. (Pdb) class Weird(str): pass (Pdb) isinstance(Weird('bob'), collections.abc.Awaitable) False So subclassing strings doesn't trigger this bug, but something about PrefixedUrlString causes the problem.

Here's the current PrefixedUrlString implementation:

https://github.com/simonw/datasette/blob/bf18b9ba175a7b25fb8b765847397dd6efb8bb7b/datasette/utils/init.py#L1015-L1035

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
733796942  
Powered by Datasette · Queries took 0.802ms · About: github-to-sqlite