issue_comments: 722542895

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/pull/195#issuecomment-722542895 https://api.github.com/repos/simonw/sqlite-utils/issues/195 722542895 MDEyOklzc3VlQ29tbWVudDcyMjU0Mjg5NQ== 9599 2020-11-05T18:01:33Z 2020-11-05T18:01:33Z OWNER

Latest test failure:

114  ->         assert [("racoons are biting trash pandas", "USA", "bar")] == table.search(
115                 "bite", order="rowid"
116             )
117     
118     
119     def test_optimize_fts(fresh_db):
(Pdb) table.search("bite")
[(2, 'racoons are biting trash pandas', 'USA', 'bar', -9.641434262948206e-07)]

The problem here is that the table.search() method now behaves differently for FTS4 v.s. FTS5 tables.

With FTS4 you get back just the table columns.

With FTS5 you also get back the rowid as the first column and the rank score as the last column.

This is weird. It also makes me question whether having .search() return a list of tuples is the right API design.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
735663855