issue_comments: 752757075

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1164#issuecomment-752757075 https://api.github.com/repos/simonw/datasette/issues/1164 752757075 MDEyOklzc3VlQ29tbWVudDc1Mjc1NzA3NQ== 9599 2020-12-30T21:01:27Z 2020-12-30T21:01:27Z OWNER

I don't want Datasette contributors to need a working Node.js install to run the tests or work on Datasette unless they are explicitly working on the JavaScript.

I think I'm going to do this with a unit test that runs only if upglify-js is available on the path and confirms that the *.min.js version of each script in the repository correctly matches the results from running uglify-js against it.

That way if anyone checks in a change to JavaScript but forgets to run the minifier the tests will fail in CI.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 776634318