issue_comments: 782740985

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/782#issuecomment-782740985 https://api.github.com/repos/simonw/datasette/issues/782 782740985 MDEyOklzc3VlQ29tbWVudDc4Mjc0MDk4NQ== 9599 2021-02-20T19:59:21Z 2021-02-20T19:59:21Z OWNER

This design should be influenced by how it's implemented.

One implementation that could be nice is that each of the keys that can be requested - next_url, total etc - maps to an async def function which can do the work. So that expensive count(*) will only be executed by the async def total function if it is requested.

This raises more questions: Both next and next_url work off the same underlying data, so if they are both requested can we re-use the work that next does somehow? Maybe by letting these functions depend on each other (so next_url() knows to first call next(), but only if it hasn't been called already.

I think I need to flesh out the full default collection of ?_extra= parameters in order to design how they will work under the hood.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
627794879