issue_comments: 850058851

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/1346#issuecomment-850058851 https://api.github.com/repos/simonw/datasette/issues/1346 850058851 MDEyOklzc3VlQ29tbWVudDg1MDA1ODg1MQ== 9599 2021-05-28T02:06:46Z 2021-05-28T02:06:46Z OWNER

The one test failure here actually illustrates a larger problem: if the user specifies .json?_shape=array but an error occurs, what should we do?

Prior to this change we return the following JSON: json { "ok": false, "error": "You did not supply a value for binding 1.", "status": 500, "title": null } But this comes from the handle_500 higher level code here: https://github.com/simonw/datasette/blob/eae3084b46e2c3931db12cdef79093ad0e644bce/datasette/app.py#L1251-L1263

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 904537568