home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 853557439

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1355#issuecomment-853557439 https://api.github.com/repos/simonw/datasette/issues/1355 853557439 MDEyOklzc3VlQ29tbWVudDg1MzU1NzQzOQ== 9599 2021-06-03T04:43:14Z 2021-06-03T04:43:14Z OWNER

It's using TestClient at the moment which is a wrapper around httpx (as of ) that uses the @async_to_sync decorator to hide the async nature.

https://github.com/simonw/datasette/blob/f78ebdc04537a6102316d6dbbf6c887565806078/datasette/utils/testing.py#L102-L156

Maybe the fix here is to switch the --get implementation to using httpx directly with https://www.python-httpx.org/async/#streaming-responses

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
910088936  
Powered by Datasette · Queries took 1.518ms · About: github-to-sqlite