issue_comments: 860142489

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/271#issuecomment-860142489 https://api.github.com/repos/simonw/sqlite-utils/issues/271 860142489 MDEyOklzc3VlQ29tbWVudDg2MDE0MjQ4OQ== 9599 2021-06-13T02:53:06Z 2021-06-13T02:53:06Z OWNER

Looks like this is the problem: https://github.com/simonw/sqlite-utils/blob/b0f9d1e494c9891ce407e27b0f5c6deeea361d30/sqlite_utils/db.py#L1724-L1742

Note how set_cols = [col for col in all_columns if col not in pks] can potentially return an empty list if ALL of the columns are primary keys - but the next line of code that assigns sql2 continues regardless, when it should instead be skipped if there are no columns in set_cols.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 919702451