issue_comments: 865160132

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/1368#issuecomment-865160132 https://api.github.com/repos/simonw/datasette/issues/1368 865160132 MDEyOklzc3VlQ29tbWVudDg2NTE2MDEzMg== 9599 2021-06-21T16:07:06Z 2021-06-21T16:08:48Z OWNER

A few tests failed - Black, the test that checks the docs mention the new hook - the most interesting failing test looks like this one: ``` updated_metadata["databases"]["fixtures"]["queries"]["magic_parameters"][ "allow" ] = (allow if "query" in permissions else deny)

      cascade_app_client.ds._metadata = updated_metadata

E AttributeError: can't set attribute ``` From https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/tests/test_permissions.py#L439-L467

This test is directly manipulating _metadata purely for the purposes of simulating different permissions - I think updating it to manipulate _local_metadata instead would fix that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 913865304