home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 890397652

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1409#issuecomment-890397652 https://api.github.com/repos/simonw/datasette/issues/1409 890397652 IC_kwDOBm6k_c41EmPU 9599 2021-07-31T19:56:48Z 2021-07-31T19:56:48Z OWNER

The other option would be to use the setting to pick the default= argument when calling self.ds.permission_allowed( request.actor, "execute-sql", resource=database, default=True).

The problem with that is that there are actually a few different places which perform that check, so changing all of them raises the risk of missing one in the future:

https://github.com/simonw/datasette/blob/a6c8e7fa4cffdeff84e9e755dcff4788fd6154b8/datasette/views/table.py#L436-L444

https://github.com/simonw/datasette/blob/a6c8e7fa4cffdeff84e9e755dcff4788fd6154b8/datasette/views/table.py#L964-L966

https://github.com/simonw/datasette/blob/d23a2671386187f61872b9f6b58e0f80ac61f8fe/datasette/views/database.py#L220-L221

https://github.com/simonw/datasette/blob/d23a2671386187f61872b9f6b58e0f80ac61f8fe/datasette/views/database.py#L343-L345

https://github.com/simonw/datasette/blob/d23a2671386187f61872b9f6b58e0f80ac61f8fe/datasette/views/database.py#L134-L136

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
957310278  
Powered by Datasette · Queries took 1.554ms · About: github-to-sqlite