issue_comments: 890399806

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1409#issuecomment-890399806 https://api.github.com/repos/simonw/datasette/issues/1409 890399806 IC_kwDOBm6k_c41Emw- 9599 2021-07-31T20:18:46Z 2021-07-31T20:18:46Z OWNER

My rationale for removing it: https://github.com/simonw/datasette/issues/813#issuecomment-640916290

Naming problem: Datasette already has a config option with this name:

$ datasette serve data.db --config allow_sql:1

https://datasette.readthedocs.io/en/stable/config.html#allow-sql

It's confusing to have two things called allow_sql that do slightly different things.

I could retire the --config allow_sql:0 option entirely, since the new metadata.json mechanism can be used to achieve the exact same thing.

I'm going to do that.

This is true. The "allow_sql" permissions block in metadata.json does indeed have a name that is easily confused with --setting allow_sql off.

So I definitely need to pick a different name from the setting. --setting default_allow_sql off is a good option here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 957310278