issue_comments: 894881448

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1425#issuecomment-894881448 https://api.github.com/repos/simonw/datasette/issues/1425 894881448 IC_kwDOBm6k_c41Vs6o 9599 2021-08-09T00:24:25Z 2021-08-09T00:24:39Z OWNER

My hunch is that the "skip this render_cell() result if it returns None" logic isn't working correctly, ever since I added the await_me_maybe line.

Could that be because Pluggy handles the "do the next if None is returned" logic itself, but I'm no-longer returning None, I'm returning an awaitable which when awaited returns None.

This would suggest that all of the await_me_maybe() plugin hooks have the same bug. That's definitely possible - it may well be that no-one has yet stumbled across a bug caused by a plugin returning an awaitable and hence not being skipped, because plugin hooks that return awaitable are rare enough that no-one has tried two plugins which both use that trick.

Still don't see why it would pass on my laptop but fail in CI though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 963528457