issue_comments: 894883664

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1425#issuecomment-894883664 https://api.github.com/repos/simonw/datasette/issues/1425 894883664 IC_kwDOBm6k_c41VtdQ 9599 2021-08-09T00:33:56Z 2021-08-09T00:33:56Z OWNER

I could extract that code out and write my own function which implements the equivalent of calling pm.hook.render_cell(...) but runs await_me_maybe() before checking if res is not None.

That's pretty nasty.

Could I instead call the plugin hook normally, but then have additional logic which says "if I await it and it returns None then try calling the hook again but skip this one" - not sure if there's a way to do that either.

I could remove the firstresult=True from the hookspec - which would cause it to call and return ALL hooks - but then in my own code use only the first one. This is slightly less efficient (since it calls all the hooks and then discards all-but-one value) but it's the least unpleasant in terms of the code I would have to write - plus I don't think it's going to be THAT common for someone to have multiple expensive render_cell() hooks installed at once (they are usually pretty cheap).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 963528457