issue_comments: 898079507

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1432#issuecomment-898079507 https://api.github.com/repos/simonw/datasette/issues/1432 898079507 IC_kwDOBm6k_c41h5sT 9599 2021-08-13T01:08:42Z 2021-08-13T01:09:41Z OWNER

This is going to break some plugins: https://ripgrep.datasette.io/-/ripgrep?pattern=config%3D&literal=on&glob=%21datasette%2F**

datasette-cluster-map/tests/test_cluster_map.py

@pytest.mark.asyncio

async def test_respects_base_url(): ds = Datasette([], memory=True, config={"base_url": "/foo/"}) response = await ds.client.get("/:memory:?sql=select+1+as+latitude,+2+as+longitude") assert (

datasette-export-notebook/tests/test_export_notebook.py

@pytest.mark.asyncio

async def test_notebook_no_csv(db_path): datasette = Datasette([db_path], config={"allow_csv_stream": False}) response = await datasette.client.get("/db/big.Notebook") assert ".csv" not in response.text

datasette-publish-vercel/tests/test_publish_vercel.py

metadata=metadata, cors=True, config={"default_page_size": 10, "sql_time_limit_ms": 2000} ).app() """

datasette-publish-vercel/datasette_publish_vercel/init.py

metadata=metadata{extras}, cors=True, config={settings}

).app()

""".strip()

datasette-search-all/tests/test_search_all.py

async def test_base_url(db_path, path): sqlite_utils.Database(db_path)["creatures"].enable_fts(["name", "description"]) datasette = Datasette([db_path], config={"base_url": "/foo/"}) response = await datasette.client.get(path) assert response.status_code == 200

I should fix those as soon as this goes out in a release. I won't close this issue until then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 969855774