home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 968207906

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1503#issuecomment-968207906 https://api.github.com/repos/simonw/datasette/issues/1503 968207906 IC_kwDOBm6k_c45ta4i 9599 2021-11-14T05:08:26Z 2021-11-14T05:08:26Z OWNER

Error: ``` def test_table_html_filter_form_column_options( path, expected_column_options, app_client ): response = app_client.get(path) assert response.status == 200 form = Soup(response.body, "html.parser").find("form") column_options = [ o.attrs.get("value") or o.string for o in form.select("select[name=_filter_column] option") ]

  assert expected_column_options == column_options

E AssertionError: assert ['- column -'...wid', 'value'] == ['- column -', 'value'] E At index 1 diff: 'rowid' != 'value' E Left contains one more item: 'value' E Use -v to get the full diff `` This is becauserowid` isn't a table column but IS returned by the query used on that page.

My solution: start with the query columns, but then add any table columns that were not already returned by the query to the end of the filter_columns list.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1050163432  
Powered by Datasette · Queries took 1.936ms · About: github-to-sqlite