issue_comments: 968360387

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/335#issuecomment-968360387 https://api.github.com/repos/simonw/sqlite-utils/issues/335 968360387 IC_kwDOCGYnMM45uAHD 9599 2021-11-14T20:45:44Z 2021-11-14T20:45:44Z OWNER

What would such an option be called? Some options:

  • table.create_index([fk.column], force=True) - not obvious what force means here
  • table.create_index([fk.column], ignore_existing_name=True) - not obvious what ignore means here
  • table.create_index([fk.column], pick_unique_name=True) - bit verbose

If the user doesn't pass in an explicit name it seems like their intent is "just create me the index, I don't care what name you use" - so actually perhaps the default behaviour here should be to pick a new unique name if that name is already in use.

Then maybe there should be an option to disable that - some options there:

  • table.create_index([fk.column], error_on_existing_index_name=True) - too verbose
  • table.create_index([fk.column], force=False) - not clear what force means
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1042569687