home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 982016594

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/344#issuecomment-982016594 https://api.github.com/repos/simonw/sqlite-utils/issues/344 982016594 IC_kwDOCGYnMM46iGJS 9599 2021-11-29T20:57:42Z 2021-11-29T20:57:42Z OWNER

What should happen if you attempt to use strict=True against a SQLite version prior to 3.37.0?

An obvious error would be best... but how about silently ignoring it on older versions instead? That would match how we handle deterministic=True for registering functions:

https://github.com/simonw/sqlite-utils/blob/126703706ea153f63e6134ad14e5712e4bbcb8ae/sqlite_utils/db.py#L372-L380

https://github.com/simonw/sqlite-utils/blob/93c7fd9868fed3193a1732b39bfac539e5812b0b/tests/test_register_function.py#L34-L37

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1066474200  
Powered by Datasette · Queries took 0.91ms · About: github-to-sqlite