home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 991285527

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1518#issuecomment-991285527 https://api.github.com/repos/simonw/datasette/issues/1518 991285527 IC_kwDOBm6k_c47FdEX 9599 2021-12-10T20:52:00Z 2021-12-10T20:52:00Z OWNER

If I break this up into @inject methods, what methods could I have and what would they do?

  • resolve_path: Use request path to resolve the database and table. Could handle hash URLs too (if I don't manage to extract those to a plugin) - would be nice if this could raise a redirect, but I think that will instead have to be one of the things it returns
  • build_sql: Builds the SQL query based on the querystring (and some DB introspection)
  • execute_count: Execute the count(*)
  • execute_rows: Execute the limit 101 to fetch the rows
  • execute_facets: Execute all requested facets (could this do its own asyncio.gather() to run facets in parallel?)
  • suggest_facets: Execute facet suggestions

Are there any plugin hooks that would make sense to execute in parallel? Actually there might be: I don't think extra_template_vars, extra_css_urls, extra_js_urls, extra_body_script depend on each other so it might be possible to execute them in a parallel chunk (at least any of them that return awaitables).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1058072543  
Powered by Datasette · Queries took 0.918ms · About: github-to-sqlite