issue_comments
8 rows where "created_at" is on date 2018-03-30 sorted by updated_at descending
This data as json, CSV (advanced)
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
377547265 | https://github.com/simonw/datasette/issues/189#issuecomment-377547265 | https://api.github.com/repos/simonw/datasette/issues/189 | MDEyOklzc3VlQ29tbWVudDM3NzU0NzI2NQ== | simonw 9599 | 2018-03-30T15:16:43Z | 2018-03-30T15:16:43Z | OWNER | I think this is the right incantation for a "next" link: https://datasette-column-sort-wip.now.sh/sortable-4bbaa6f?sql=select+*+from+sortable%0D%0Awhere+sortable+%3C%3D+94%0D%0Aand+%28%0D%0A++%28pk1+%3E+%27d%27%29%0D%0A++or%0D%0A++%28pk1+%3D+%27d%27+and+pk2+%3E+%27w%27%29%0D%0A%29%0D%0Aorder+by+sortable+desc%2C+pk1%2C+pk2%0D%0Alimit+7 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability to sort (and paginate) by column 309471814 | |
377546510 | https://github.com/simonw/datasette/issues/189#issuecomment-377546510 | https://api.github.com/repos/simonw/datasette/issues/189 | MDEyOklzc3VlQ29tbWVudDM3NzU0NjUxMA== | simonw 9599 | 2018-03-30T15:13:11Z | 2018-03-30T15:13:11Z | OWNER | Pushed some work-in-progress with failing unit tests here: https://github.com/simonw/datasette/commit/2f8359c6f25768805431c80c74e5ec4213c2b2a6 Here's a demo: https://datasette-column-sort-wip.now.sh/sortable-4bbaa6f/sortable?_sort=sortable - note that the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability to sort (and paginate) by column 309471814 | |
377462334 | https://github.com/simonw/datasette/issues/189#issuecomment-377462334 | https://api.github.com/repos/simonw/datasette/issues/189 | MDEyOklzc3VlQ29tbWVudDM3NzQ2MjMzNA== | simonw 9599 | 2018-03-30T07:06:21Z | 2018-03-30T07:06:21Z | OWNER | Maybe the answer here is that anything that's encoded in the next token is treated as >= with the exception of columns known to be primary keys, which are treated as > |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability to sort (and paginate) by column 309471814 | |
377460127 | https://github.com/simonw/datasette/issues/189#issuecomment-377460127 | https://api.github.com/repos/simonw/datasette/issues/189 | MDEyOklzc3VlQ29tbWVudDM3NzQ2MDEyNw== | simonw 9599 | 2018-03-30T06:51:29Z | 2018-03-30T06:51:52Z | OWNER | The problem is that our So I think this is the right SQL:
But how do I encode a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability to sort (and paginate) by column 309471814 | |
377459579 | https://github.com/simonw/datasette/issues/189#issuecomment-377459579 | https://api.github.com/repos/simonw/datasette/issues/189 | MDEyOklzc3VlQ29tbWVudDM3NzQ1OTU3OQ== | simonw 9599 | 2018-03-30T06:47:52Z | 2018-03-30T06:47:52Z | OWNER | I'm not entirely sure how to get Consider this data: If the page size was set to 9 rather than 11, the page divide would be between those two rows with the same value in the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability to sort (and paginate) by column 309471814 | |
377457214 | https://github.com/simonw/datasette/issues/190#issuecomment-377457214 | https://api.github.com/repos/simonw/datasette/issues/190 | MDEyOklzc3VlQ29tbWVudDM3NzQ1NzIxNA== | simonw 9599 | 2018-03-30T06:31:15Z | 2018-03-30T06:31:15Z | OWNER | Fixed! https://datasette-issue-190-compound-pks-second-fix.now.sh/compound-pks-8e99805/compound_three_primary_keys?_next=b%2Cx%2Cd&content__contains=d now correctly shows |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Keyset pagination doesn't work correctly for compound primary keys 309558826 | |
377457087 | https://github.com/simonw/datasette/issues/190#issuecomment-377457087 | https://api.github.com/repos/simonw/datasette/issues/190 | MDEyOklzc3VlQ29tbWVudDM3NzQ1NzA4Nw== | simonw 9599 | 2018-03-30T06:30:23Z | 2018-03-30T06:30:23Z | OWNER | Interestingly, in deploying a copy of the database to demonstrate this final bug fix I had to use the
This is because |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Keyset pagination doesn't work correctly for compound primary keys 309558826 | |
377454591 | https://github.com/simonw/datasette/issues/190#issuecomment-377454591 | https://api.github.com/repos/simonw/datasette/issues/190 | MDEyOklzc3VlQ29tbWVudDM3NzQ1NDU5MQ== | simonw 9599 | 2018-03-30T06:11:59Z | 2018-03-30T06:11:59Z | OWNER | Re-opening this issue: my fix doesn't play nicely with extra filter arguments. Consider this page: https://datasette-issue-190-compound-pks-not-quite-fixed.now.sh/compound-pks-8e99805/compound_three_primary_keys?content__contains=d The next link is to Sure enough, the generated SQL looks like this: https://datasette-issue-190-compound-pks-not-quite-fixed.now.sh/compound-pks-8e99805?sql=select+%2A+from+compound_three_primary_keys+where+%22content%22+like+%3Ap0+and+%28%5Bpk1%5D+%3E+%3Ap0%29%0A++or%0A%28%5Bpk1%5D+%3D+%3Ap0+and+%5Bpk2%5D+%3E+%3Ap1%29%0A++or%0A%28%5Bpk1%5D+%3D+%3Ap0+and+%5Bpk2%5D+%3D+%3Ap1+and+%5Bpk3%5D+%3E+%3Ap2%29+order+by+pk1%2C+pk2%2C+pk3+limit+101&p0=%25d%25&p1=b&p2=x&p3=d
The parameters here are confused. The :p0 should be reserved just for the like clause - the other parameters should be p1, p2 and p3 (not p0, p1 and p2). |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Keyset pagination doesn't work correctly for compound primary keys 309558826 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 2