issue_comments
26 rows where "created_at" is on date 2022-10-14 sorted by updated_at descending
This data as json, CSV (advanced)
user 3
- simonw 23
- chapmanjacobd 2
- codecov[bot] 1
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1278306180 | https://github.com/simonw/datasette/pull/1842#issuecomment-1278306180 | https://api.github.com/repos/simonw/datasette/issues/1842 | IC_kwDOBm6k_c5MMWeE | codecov[bot] 22429695 | 2022-10-14T00:11:46Z | 2022-10-24T02:04:52Z | NONE | Codecov ReportBase: 92.52% // Head: 92.54% // Increases project coverage by
Additional details and impacted files```diff @@ Coverage Diff @@ ## main #1842 +/- ## ========================================== + Coverage 92.52% 92.54% +0.02% ========================================== Files 35 35 Lines 4415 4428 +13 ========================================== + Hits 4085 4098 +13 Misses 330 330 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `94.28% <100.00%> (+0.05%)` | :arrow_up: | | [datasette/views/database.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2RhdGFiYXNlLnB5) | `95.29% <100.00%> (+0.06%)` | :arrow_up: | | [datasette/views/index.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2luZGV4LnB5) | `96.49% <100.00%> (ø)` | | | [datasette/views/row.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3Jvdy5weQ==) | `88.70% <100.00%> (+0.37%)` | :arrow_up: | | [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3RhYmxlLnB5) | `95.20% <100.00%> (+0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison):umbrella: View full report at Codecov. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
check_visibility can now take multiple permissions into account 1408561039 | |
1279598878 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279598878 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MRSEe | simonw 9599 | 2022-10-14T23:51:46Z | 2022-10-14T23:51:46Z | OWNER | Blogged about this here: https://simonwillison.net/2022/Oct/14/automating-screenshots/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279427618 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279427618 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQoQi | simonw 9599 | 2022-10-14T20:25:45Z | 2022-10-14T20:25:45Z | OWNER | Extracted a TIL: https://til.simonwillison.net/shot-scraper/subset-of-table-columns |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279415365 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279415365 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQlRF | simonw 9599 | 2022-10-14T20:11:55Z | 2022-10-14T20:11:55Z | OWNER | Twitter thread about this issue: https://twitter.com/simonw/status/1581012617526595584 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279406134 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279406134 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQjA2 | simonw 9599 | 2022-10-14T20:01:13Z | 2022-10-14T20:01:13Z | OWNER | Here's the YAML I added to https://github.com/simonw/datasette-screenshots/blob/main/shots.yml for this issue:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279405429 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279405429 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQi11 | simonw 9599 | 2022-10-14T20:00:26Z | 2022-10-14T20:00:26Z | OWNER | New images are now live on these pages: - https://docs.datasette.io/en/latest/csv_export.html - https://docs.datasette.io/en/latest/binary_data.html - https://docs.datasette.io/en/latest/facets.html - https://docs.datasette.io/en/latest/full_text_search.html - https://docs.datasette.io/en/latest/changelog.html#v0-23 (was a duplicate of the advanced export image) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279392717 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279392717 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQfvN | simonw 9599 | 2022-10-14T19:44:44Z | 2022-10-14T19:45:54Z | OWNER | OK, the URLs to use in the docs are:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279349314 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279349314 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQVJC | simonw 9599 | 2022-10-14T18:50:42Z | 2022-10-14T19:34:37Z | OWNER | I'm going to link the documentation screenshots directly to the images in the https://github.com/simonw/datasette-screenshots repository - but I don't want those images to reflect So I'm going to start tagging releases of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279383121 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279383121 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQdZR | simonw 9599 | 2022-10-14T19:33:49Z | 2022-10-14T19:33:49Z | OWNER | I'm going to tag |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279311487 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279311487 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQL5_ | simonw 9599 | 2022-10-14T18:06:53Z | 2022-10-14T19:33:24Z | OWNER | I just spotted some other out-dated screenshots in the
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279382674 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279382674 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQdSS | simonw 9599 | 2022-10-14T19:33:16Z | 2022-10-14T19:33:16Z | OWNER | That's the last two screenshots: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279348239 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279348239 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQU4P | simonw 9599 | 2022-10-14T18:49:22Z | 2022-10-14T18:49:22Z | OWNER | This works:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279339124 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279339124 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQSp0 | simonw 9599 | 2022-10-14T18:38:22Z | 2022-10-14T18:42:58Z | OWNER | This seems to get every table cell in that table for the first 3 rows and the columns up to
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279334694 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279334694 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQRkm | simonw 9599 | 2022-10-14T18:33:41Z | 2022-10-14T18:34:32Z | OWNER | I'm going to use this page for the facets screenshot: https://congress-legislators.datasettes.com/legislators/legislator_terms?_facet=type&_facet=party&_facet=state&_facet_size=10 Trying for this bit: Which incorporates |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279325685 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279325685 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQPX1 | simonw 9599 | 2022-10-14T18:23:22Z | 2022-10-14T18:23:22Z | OWNER | Here's the new advanced export image: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279325003 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279325003 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQPNL | simonw 9599 | 2022-10-14T18:22:35Z | 2022-10-14T18:22:35Z | OWNER | So:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279323714 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279323714 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQO5C | simonw 9599 | 2022-10-14T18:21:03Z | 2022-10-14T18:21:03Z | OWNER | For this image: https://latest.datasette.io/fixtures/binary_data has an extra row these days: This deletes every row past the first two (first three including the header row):
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279314400 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279314400 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQMng | simonw 9599 | 2022-10-14T18:10:07Z | 2022-10-14T18:13:36Z | OWNER | For the advanced export one:
Produces: Current image is: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279316670 | https://github.com/simonw/datasette/issues/1844#issuecomment-1279316670 | https://api.github.com/repos/simonw/datasette/issues/1844 | IC_kwDOBm6k_c5MQNK- | simonw 9599 | 2022-10-14T18:12:39Z | 2022-10-14T18:12:39Z | OWNER | New screenshot of FTS, from https://register-of-members-interests.datasettes.com/regmem/items?_search=hamper&_sort_desc=date |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update screenshots in documentation to match latest designs 1409679008 | |
1279249898 | https://github.com/dogsheep/twitter-to-sqlite/issues/60#issuecomment-1279249898 | https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/60 | IC_kwDODEm0Qs5MP83q | chapmanjacobd 7908073 | 2022-10-14T16:58:26Z | 2022-10-14T16:58:26Z | NONE | You could try using Here is a guide: https://github.com/chapmanjacobd/lb/blob/main/Windows.md#prep |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Execution on Windows 1063982712 | |
1279224780 | https://github.com/dogsheep/github-to-sqlite/issues/51#issuecomment-1279224780 | https://api.github.com/repos/dogsheep/github-to-sqlite/issues/51 | IC_kwDODFdgUs5MP2vM | chapmanjacobd 7908073 | 2022-10-14T16:34:07Z | 2022-10-14T16:34:07Z | NONE | also, it says that authenticated requests have a much higher "rate limit". Unauthenticated requests only get 60 req/hour ?? seems more like a quota than a "rate limit" (although I guess that is semantic equivalence) You would want to use
But a more complete solution would bring authenticated requests to the other subcommands. I'm surprised only |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
github-to-sqlite should handle rate limits better 703246031 | |
1278537920 | https://github.com/simonw/datasette/issues/1843#issuecomment-1278537920 | https://api.github.com/repos/simonw/datasette/issues/1843 | IC_kwDOBm6k_c5MNPDA | simonw 9599 | 2022-10-14T06:19:55Z | 2022-10-14T06:20:06Z | OWNER | Maybe I need to explicitly close those SQLite connections held by the Datasette instance after this line: https://github.com/simonw/datasette/blob/79aa0de083d38a9975915d5a4cc68ca6c74fbe3d/tests/fixtures.py#L165 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Intermittent "Too many open files" error running tests 1408757705 | |
1278480437 | https://github.com/simonw/datasette/issues/1843#issuecomment-1278480437 | https://api.github.com/repos/simonw/datasette/issues/1843 | IC_kwDOBm6k_c5MNBA1 | simonw 9599 | 2022-10-14T04:51:10Z | 2022-10-14T04:51:10Z | OWNER | Extracted a TIL: https://til.simonwillison.net/python/too-many-open-files-psutil |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Intermittent "Too many open files" error running tests 1408757705 | |
1278478042 | https://github.com/simonw/datasette/issues/1843#issuecomment-1278478042 | https://api.github.com/repos/simonw/datasette/issues/1843 | IC_kwDOBm6k_c5MNAba | simonw 9599 | 2022-10-14T04:46:29Z | 2022-10-14T04:46:29Z | OWNER | I did
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Intermittent "Too many open files" error running tests 1408757705 | |
1278302478 | https://github.com/simonw/datasette/issues/1829#issuecomment-1278302478 | https://api.github.com/repos/simonw/datasette/issues/1829 | IC_kwDOBm6k_c5MMVkO | simonw 9599 | 2022-10-14T00:06:19Z | 2022-10-14T00:06:19Z | OWNER | I'll finish this in a PR: - https://github.com/simonw/datasette/pull/1842 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Table/database that is private due to inherited permissions does not show padlock 1396948693 | |
1278300241 | https://github.com/simonw/datasette/issues/1829#issuecomment-1278300241 | https://api.github.com/repos/simonw/datasette/issues/1829 | IC_kwDOBm6k_c5MMVBR | simonw 9599 | 2022-10-14T00:03:52Z | 2022-10-14T00:04:28Z | OWNER | Here's what I've got so far: ```diff diff --git a/datasette/app.py b/datasette/app.py index 5fa4955c..df9eae49 100644 --- a/datasette/app.py +++ b/datasette/app.py @@ -1,5 +1,5 @@ import asyncio -from typing import Sequence, Union, Tuple +from typing import Sequence, Union, Tuple, Optional import asgi_csrf import collections import datetime @@ -707,7 +707,7 @@ class Datasette:
Also this fix is currently only applied on the table page - needs to be applied on database, row and query pages too. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Table/database that is private due to inherited permissions does not show padlock 1396948693 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 6