issue_comments
10,495 rows sorted by node_id
This data as json, CSV (advanced)
These facets timed out: created_at
issue >30
- Redesign default .json format 55
- ?_extra= support (draft) 49
- Upgrade to CodeMirror 6, add SQL autocomplete 48
- JavaScript plugin hooks mechanism similar to pluggy 47
- Updated Dockerfile with SpatiaLite version 5.0 45
- Complete refactor of TableView and table.html template 45
- Port Datasette to ASGI 42
- Authentication (and permissions) as a core concept 40
- invoke_startup() is not run in some conditions, e.g. gunicorn/uvicorn workers, breaking lots of things 36
- Deploy a live instance of demos/apache-proxy 34
- await datasette.client.get(path) mechanism for executing internal requests 33
- Maintain an in-memory SQLite table of connected databases and their tables 32
- Research: demonstrate if parallel SQL queries are worthwhile 32
- Ability to sort (and paginate) by column 31
- Server hang on parallel execution of queries to named in-memory databases 31
- Default API token authentication mechanism 30
- Port as many tests as possible to async def tests against ds_client 29
- link_or_copy_directory() error - Invalid cross-device link 28
- Add ?_extra= mechanism for requesting extra properties in JSON 27
- Export to CSV 27
- base_url configuration setting 27
- Documentation with recommendations on running Datasette in production without using Docker 27
- Optimize all those calls to index_list and foreign_key_list 27
- Support cross-database joins 26
- Ability for a canned query to write to the database 26
- table.transform() method for advanced alter table 26
- New pattern for views that return either JSON or HTML, available for plugins 26
- Proof of concept for Datasette on AWS Lambda with EFS 25
- WIP: Add Gmail takeout mbox import 25
- Make it easier to insert geometries, with documentation and maybe code 25
- …
id | html_url | issue_url | node_id ▼ | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
901475812 | https://github.com/simonw/datasette/issues/1293#issuecomment-901475812 | https://api.github.com/repos/simonw/datasette/issues/1293 | IC_kwDOBm6k_c41u23k | simonw 9599 | 2021-08-18T22:41:19Z | 2021-08-18T22:41:19Z | OWNER |
I'm going to do this, and call the Python library |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Show column metadata plus links for foreign keys on arbitrary query results 849978964 | |
902251316 | https://github.com/simonw/datasette/issues/1415#issuecomment-902251316 | https://api.github.com/repos/simonw/datasette/issues/1415 | IC_kwDOBm6k_c41x0M0 | simonw 9599 | 2021-08-19T21:14:15Z | 2021-08-19T21:14:15Z | OWNER | https://github.com/ahmetb/cloud-run-faq#how-do-i-continuously-deploy-to-cloud-run suggests the following:
It also links to https://cloud.google.com/run/docs/reference/iam/roles |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
feature request: document minimum permissions for service account for cloudrun 959137143 | |
902258509 | https://github.com/simonw/datasette/issues/1443#issuecomment-902258509 | https://api.github.com/repos/simonw/datasette/issues/1443 | IC_kwDOBm6k_c41x19N | simonw 9599 | 2021-08-19T21:25:07Z | 2021-08-19T21:25:07Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.databases should be a documented property 974995592 | ||
902254712 | https://github.com/simonw/datasette/pull/1434#issuecomment-902254712 | https://api.github.com/repos/simonw/datasette/issues/1434 | IC_kwDOBm6k_c41x1B4 | simonw 9599 | 2021-08-19T21:18:31Z | 2021-08-19T21:18:57Z | OWNER | I deployed a demo to https://datasette-latest-query-info-j7hipcg4aq-uc.a.run.app using the mechanism from #1442. e.g. demo here: https://datasette-latest-query-info-j7hipcg4aq-uc.a.run.app/fixtures?sql=select+*+from+searchable |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Enrich arbitrary query results with foreign key links and column descriptions 970463436 | |
902260338 | https://github.com/simonw/datasette/issues/1426#issuecomment-902260338 | https://api.github.com/repos/simonw/datasette/issues/1426 | IC_kwDOBm6k_c41x2Zy | simonw 9599 | 2021-08-19T21:28:25Z | 2021-08-19T21:29:40Z | OWNER | Actually it looks like you can send a
According to https://developers.google.com/search/docs/advanced/sitemaps/build-sitemap |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Manage /robots.txt in Datasette core, block robots by default 964322136 | |
902260799 | https://github.com/simonw/datasette/issues/1426#issuecomment-902260799 | https://api.github.com/repos/simonw/datasette/issues/1426 | IC_kwDOBm6k_c41x2g_ | simonw 9599 | 2021-08-19T21:29:13Z | 2021-08-19T21:29:13Z | OWNER | Bing's equivalent is: https://www.bing.com/webmasters/help/Sitemaps-3b5cf6ed
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Manage /robots.txt in Datasette core, block robots by default 964322136 | |
902263367 | https://github.com/simonw/datasette/issues/1426#issuecomment-902263367 | https://api.github.com/repos/simonw/datasette/issues/1426 | IC_kwDOBm6k_c41x3JH | simonw 9599 | 2021-08-19T21:33:51Z | 2021-08-19T21:36:28Z | OWNER | I was worried about if it's possible to allow access to From various answers on Stack Overflow it looks like this should handle that:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Manage /robots.txt in Datasette core, block robots by default 964322136 | |
902191150 | https://github.com/simonw/datasette/issues/1442#issuecomment-902191150 | https://api.github.com/repos/simonw/datasette/issues/1442 | IC_kwDOBm6k_c41xlgu | simonw 9599 | 2021-08-19T19:43:05Z | 2021-08-19T19:43:59Z | OWNER | Maybe as simple as teaching https://github.com/simonw/datasette/blob/main/.github/workflows/deploy-latest.yml to run on pushes to ALL branches: And then quit early if the branch is not in some allow-list. If it IS in the allow-list, use the name of the branch to dynamically construct the name of the Cloud Run service here: https://github.com/simonw/datasette/blob/adb5b70de5cec3c3dd37184defe606a082c232cf/.github/workflows/deploy-latest.yml#L60 Need to skip the documentation build and deployment stuff for other branches though. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to cause specific branches to deploy their own demos 974987856 | |
902217726 | https://github.com/simonw/datasette/issues/1442#issuecomment-902217726 | https://api.github.com/repos/simonw/datasette/issues/1442 | IC_kwDOBm6k_c41xr_- | simonw 9599 | 2021-08-19T20:21:47Z | 2021-08-19T20:21:47Z | OWNER | I think the neatest way to implement this would be for the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to cause specific branches to deploy their own demos 974987856 | |
902231018 | https://github.com/simonw/datasette/issues/1442#issuecomment-902231018 | https://api.github.com/repos/simonw/datasette/issues/1442 | IC_kwDOBm6k_c41xvPq | simonw 9599 | 2021-08-19T20:42:08Z | 2021-08-19T20:42:08Z | OWNER | If I get this working I should document it on https://docs.datasette.io/en/stable/contributing.html |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to cause specific branches to deploy their own demos 974987856 | |
902235714 | https://github.com/simonw/datasette/issues/1442#issuecomment-902235714 | https://api.github.com/repos/simonw/datasette/issues/1442 | IC_kwDOBm6k_c41xwZC | simonw 9599 | 2021-08-19T20:50:38Z | 2021-08-19T20:50:38Z | OWNER | Would this allow anyone to push a PR to this repo that would result in their code being deployed against my Cloud Run account? I'm reasonably confident that it would not, since the secrets would not be visible to their PR branch. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to cause specific branches to deploy their own demos 974987856 | |
902239215 | https://github.com/simonw/datasette/issues/1442#issuecomment-902239215 | https://api.github.com/repos/simonw/datasette/issues/1442 | IC_kwDOBm6k_c41xxPv | simonw 9599 | 2021-08-19T20:56:46Z | 2021-08-19T20:56:46Z | OWNER | I'm going to only run the tests if it's a push to |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to cause specific branches to deploy their own demos 974987856 | |
902243498 | https://github.com/simonw/datasette/issues/1442#issuecomment-902243498 | https://api.github.com/repos/simonw/datasette/issues/1442 | IC_kwDOBm6k_c41xySq | simonw 9599 | 2021-08-19T21:04:01Z | 2021-08-19T21:04:01Z | OWNER | That successfully deployed to https://datasette-latest-deploy-this-branch-j7hipcg4aq-uc.a.run.app/ even though the tests failed. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to cause specific branches to deploy their own demos 974987856 | |
902250361 | https://github.com/simonw/datasette/issues/1415#issuecomment-902250361 | https://api.github.com/repos/simonw/datasette/issues/1415 | IC_kwDOBm6k_c41xz95 | simonw 9599 | 2021-08-19T21:12:28Z | 2021-08-19T21:12:28Z | OWNER | I would love to know this too! I always find figuring out minimal permissions to be really difficult. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
feature request: document minimum permissions for service account for cloudrun 959137143 | |
902375088 | https://github.com/simonw/datasette/issues/894#issuecomment-902375088 | https://api.github.com/repos/simonw/datasette/issues/894 | IC_kwDOBm6k_c41ySaw | simonw 9599 | 2021-08-20T02:07:13Z | 2021-08-20T02:07:26Z | OWNER | Maybe |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
?sort=colname~numeric to sort by by column cast to real 657572753 | |
902375388 | https://github.com/simonw/datasette/issues/894#issuecomment-902375388 | https://api.github.com/repos/simonw/datasette/issues/894 | IC_kwDOBm6k_c41ySfc | simonw 9599 | 2021-08-20T02:07:53Z | 2021-08-20T02:07:53Z | OWNER | I could add these sorting links to the cog menu for any |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
?sort=colname~numeric to sort by by column cast to real 657572753 | |
922363640 | https://github.com/simonw/datasette/issues/1473#issuecomment-922363640 | https://api.github.com/repos/simonw/datasette/issues/1473 | IC_kwDOBm6k_c42-ib4 | mroswell 192568 | 2021-09-18T19:45:47Z | 2021-09-18T19:45:47Z | CONTRIBUTOR | An update, if I remove the Also, if I keep things exactly as they are, and it improperly, but consistently goes to the Weird stuff. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
base logo link visits `undefined` rather than href url 999902754 | |
922394999 | https://github.com/simonw/datasette/issues/1473#issuecomment-922394999 | https://api.github.com/repos/simonw/datasette/issues/1473 | IC_kwDOBm6k_c42-qF3 | mroswell 192568 | 2021-09-19T00:44:39Z | 2021-09-19T00:45:32Z | CONTRIBUTOR | I replaced:
I'd still love to know what caused this (and how to troubleshoot to figure it out), so I'll leave it open for a bit, but I do have a functional logo linking to the Hugo home page, at least locally. I'll likely push tomorrow. (Before trying this, I tried to apply a background image to the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
base logo link visits `undefined` rather than href url 999902754 | |
920543967 | https://github.com/simonw/datasette/issues/236#issuecomment-920543967 | https://api.github.com/repos/simonw/datasette/issues/236 | IC_kwDOBm6k_c423mLf | sethvincent 164214 | 2021-09-16T03:19:08Z | 2021-09-16T03:19:08Z | NONE | :wave: I just put together a small example using the lambda container image support: https://github.com/sethvincent/datasette-aws-lambda-example It uses mangum and AWS's python runtime interface client to handle the lambda event stuff. I'd be happy to help with a publish plugin for AWS lambda as I plan to use this for upcoming projects. The example uses the serverless cli for deployment but there might be a more suitable deployment approach for the plugin. It would be cool if users didn't have to install anything additional other than the aws cli and its associated config/credentials setup. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette publish lambda plugin 317001500 | |
922075480 | https://github.com/simonw/datasette/issues/236#issuecomment-922075480 | https://api.github.com/repos/simonw/datasette/issues/236 | IC_kwDOBm6k_c429cFY | simonw 9599 | 2021-09-17T20:54:13Z | 2021-09-17T20:54:13Z | OWNER | That's so useful @sethvincent! Really interesting reading your code there, especially clever how you're using the I'd be very interested to see what your demo looks like without using serverless - completely agree that the less additional dependencies there are for this the better. I'm also very interested in figuring out a way to run Datasette in Lambda but with the SQLite database on an EFS volume. Do you have a feel for how hard that would be? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette publish lambda plugin 317001500 | |
906414811 | https://github.com/simonw/datasette/pull/1448#issuecomment-906414811 | https://api.github.com/repos/simonw/datasette/issues/1448 | IC_kwDOBm6k_c42Bsrb | codecov[bot] 22429695 | 2021-08-26T13:29:02Z | 2021-08-26T13:29:02Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1448 +/-=======================================
Coverage 91.82% 91.82% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update pluggy requirement from ~=0.13.0 to >=0.13,<1.1 980228553 | |
907537693 | https://github.com/simonw/datasette/issues/1449#issuecomment-907537693 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F-0d | simonw 9599 | 2021-08-28T00:31:26Z | 2021-08-28T00:31:26Z | OWNER | Terminology question: is it correct to call these subcommands or should they be commands? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907537366 | https://github.com/simonw/datasette/issues/1449#issuecomment-907537366 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F-vW | simonw 9599 | 2021-08-28T00:29:16Z | 2021-08-28T00:29:29Z | OWNER | The closest plugin hook to this right now is publish_subcommand - which looks like this:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907537610 | https://github.com/simonw/datasette/issues/1449#issuecomment-907537610 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F-zK | simonw 9599 | 2021-08-28T00:30:51Z | 2021-08-28T00:30:51Z | OWNER | There's also the option for plugins to muck around with existing registered commands - this could get a bit untidy if multiple plugins try to do it, but being able to replace |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907542214 | https://github.com/simonw/datasette/issues/1449#issuecomment-907542214 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F_7G | simonw 9599 | 2021-08-28T01:02:38Z | 2021-08-28T01:02:38Z | OWNER | Partial prototype of @hookimpl
def register_commands(cli):
from datasette.cli import sqlite_extensions
@cli.command()
@click.argument("files", type=click.Path(exists=True), nargs=-1)
@sqlite_extensions
def verify(files, sqlite_extensions):
"Verify that files can be opened by Datasette"
for file in files:
print(file)
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907538940 | https://github.com/simonw/datasette/issues/1449#issuecomment-907538940 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F_H8 | simonw 9599 | 2021-08-28T00:39:28Z | 2021-08-28T00:39:28Z | OWNER | Here's the answer to that: ``` ~ % datasette --help Usage: datasette [OPTIONS] COMMAND [ARGS]... Datasette! Options: --version Show the version and exit. --help Show this message and exit. Commands:
serve* Serve up specified SQLite database files with a web UI
inspect
install Install Python packages - e.g.
package Package specified SQLite files into a new datasette Docker...
plugins List currently available plugins
publish Publish specified SQLite database files to the internet...
uninstall Uninstall Python packages (e.g.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907539065 | https://github.com/simonw/datasette/issues/1449#issuecomment-907539065 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F_J5 | simonw 9599 | 2021-08-28T00:40:24Z | 2021-08-28T00:40:24Z | OWNER | I'm going to call the new hook |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907539251 | https://github.com/simonw/datasette/issues/1449#issuecomment-907539251 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F_Mz | simonw 9599 | 2021-08-28T00:41:37Z | 2021-08-28T00:41:50Z | OWNER | The first example plugin I'm going to build for this will be |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907539668 | https://github.com/simonw/datasette/issues/1449#issuecomment-907539668 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F_TU | simonw 9599 | 2021-08-28T00:44:16Z | 2021-08-28T00:44:16Z | OWNER | Considering this piece of code: https://github.com/simonw/datasette/blob/a1a33bb5822214be1cebd98cd858b2058d91a4aa/datasette/cli.py#L122-L142 I think the hook itself gets called with a single argument, I can't pass it |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907540240 | https://github.com/simonw/datasette/issues/1450#issuecomment-907540240 | https://api.github.com/repos/simonw/datasette/issues/1450 | IC_kwDOBm6k_c42F_cQ | simonw 9599 | 2021-08-28T00:48:30Z | 2021-08-28T00:48:30Z | OWNER | I'll go with this: ``` % datasette --help Usage: datasette [OPTIONS] COMMAND [ARGS]... Datasette is an open source multi-tool for exploring and publishing data About Datasette: https://datasette.io/ Full documentation: https://docs.datasette.io/ Options: --version Show the version and exit. --help Show this message and exit. ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette --help should show something more useful than "Datasette!" 981681138 | |
907540790 | https://github.com/simonw/datasette/issues/1449#issuecomment-907540790 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F_k2 | simonw 9599 | 2021-08-28T00:52:32Z | 2021-08-28T00:52:32Z | OWNER | I don't think I can get this new hook to support the handy --plugins-dir= mechanism for loading plugins from Python files as opposed to registering them with setuptools - that mechanism is itself implemented inside of code called by |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907540928 | https://github.com/simonw/datasette/issues/1449#issuecomment-907540928 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42F_nA | simonw 9599 | 2021-08-28T00:53:37Z | 2021-08-28T00:53:37Z | OWNER | I'll probably have to use this mechanism for the tests then: https://til.simonwillison.net/pytest/registering-plugins-in-tests |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907543982 | https://github.com/simonw/datasette/issues/1449#issuecomment-907543982 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42GAWu | simonw 9599 | 2021-08-28T01:14:27Z | 2021-08-28T01:14:27Z | OWNER | Writing the test for this is proving difficult, because the Trying to work around that with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
907547624 | https://github.com/simonw/datasette/issues/1449#issuecomment-907547624 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42GBPo | simonw 9599 | 2021-08-28T01:44:57Z | 2021-08-28T01:58:35Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | ||
907547736 | https://github.com/simonw/datasette/issues/1449#issuecomment-907547736 | https://api.github.com/repos/simonw/datasette/issues/1449 | IC_kwDOBm6k_c42GBRY | simonw 9599 | 2021-08-28T01:45:36Z | 2021-08-28T01:45:36Z | OWNER | I need to push this out as an alpha so I can release a demo plugin that uses it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`register_commands()` plugin hook to register extra CLI commands 981676832 | |
908337614 | https://github.com/simonw/datasette/pull/1453#issuecomment-908337614 | https://api.github.com/repos/simonw/datasette/issues/1453 | IC_kwDOBm6k_c42JCHO | codecov[bot] 22429695 | 2021-08-30T13:20:26Z | 2021-08-30T13:20:26Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1453 +/-=======================================
Coverage 91.83% 91.83% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bump black from 21.7b0 to 21.8b0 982780906 | |
908832938 | https://github.com/simonw/datasette/issues/1446#issuecomment-908832938 | https://api.github.com/repos/simonw/datasette/issues/1446 | IC_kwDOBm6k_c42K7Cq | simonw 9599 | 2021-08-31T01:54:59Z | 2021-08-31T01:54:59Z | OWNER | I used the sticky footer mechanism in |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Modify base.html template to support optional sticky footer 978357984 | |
913001282 | https://github.com/simonw/datasette/pull/1455#issuecomment-913001282 | https://api.github.com/repos/simonw/datasette/issues/1455 | IC_kwDOBm6k_c42a0tC | ctb 51016 | 2021-09-04T16:31:24Z | 2021-09-04T16:31:24Z | CONTRIBUTOR | I love it! maybe 'researchers' instead? Or 'scientists and researchers'? |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add scientists to target groups 988325628 | |
913001298 | https://github.com/simonw/datasette/pull/1455#issuecomment-913001298 | https://api.github.com/repos/simonw/datasette/issues/1455 | IC_kwDOBm6k_c42a0tS | simonw 9599 | 2021-09-04T16:31:32Z | 2021-09-04T16:31:32Z | OWNER | Great idea! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add scientists to target groups 988325628 | |
913001416 | https://github.com/simonw/datasette/pull/1455#issuecomment-913001416 | https://api.github.com/repos/simonw/datasette/issues/1455 | IC_kwDOBm6k_c42a0vI | simonw 9599 | 2021-09-04T16:32:21Z | 2021-09-04T16:32:21Z | OWNER | I'll add researchers too. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add scientists to target groups 988325628 | |
913218494 | https://github.com/simonw/datasette/issues/1459#issuecomment-913218494 | https://api.github.com/repos/simonw/datasette/issues/1459 | IC_kwDOBm6k_c42bpu- | simonw 9599 | 2021-09-05T19:58:51Z | 2021-09-05T19:59:15Z | OWNER | This idea makes sense to me. There's actually an existing option that takes a path, called So... one option would be to allow combining that with
So some options here are:
I quite like that last combination option, mainly to avoid adding even more command options. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
suggestion: allow `datasette --open` to take a relative URL 988556488 | |
914439356 | https://github.com/simonw/datasette/issues/1461#issuecomment-914439356 | https://api.github.com/repos/simonw/datasette/issues/1461 | IC_kwDOBm6k_c42gTy8 | simonw 9599 | 2021-09-07T16:11:37Z | 2021-09-07T16:11:37Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Try blacken-docs 989986586 | |
914440282 | https://github.com/simonw/datasette/issues/1461#issuecomment-914440282 | https://api.github.com/repos/simonw/datasette/issues/1461 | IC_kwDOBm6k_c42gUBa | simonw 9599 | 2021-09-07T16:12:57Z | 2021-09-07T16:12:57Z | OWNER | Here's the diff it produced from that first run:
Note that you need to pass @@ -412,12 +408,16 @@ To include an expiry, add a
The resulting cookie will encode data that looks something like this: diff --git a/docs/spatialite.rst b/docs/spatialite.rst index d1b300b..556bad8 100644 --- a/docs/spatialite.rst +++ b/docs/spatialite.rst @@ -58,19 +58,22 @@ Here's a recipe for taking a table with existing latitude and longitude columns, .. code-block:: python
Querying polygons using within()
diff --git a/docs/writing_plugins.rst b/docs/writing_plugins.rst
index bd60a4b..5af01f6 100644
--- a/docs/writing_plugins.rst
+++ b/docs/writing_plugins.rst
@@ -18,9 +18,10 @@ The quickest way to start writing a plugin is to create a
+ @hookimpl def prepare_connection(conn): - conn.create_function('hello_world', 0, lambda: 'Hello world!') + conn.create_function("hello_world", 0, lambda: "Hello world!") If you save this in @@ -60,22 +61,18 @@ The example consists of two files: a
And a Python module file,
Having built a plugin in this way you can turn it into an installable package using the following command:: @@ -123,11 +120,13 @@ To bundle the static assets for a plugin in the package that you publish to PyPI .. code-block:: python
Where @@ -152,11 +151,13 @@ Templates should be bundled for distribution using the same .. code-block:: python
You can also use wildcards here such as |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Try blacken-docs 989986586 | |
914441037 | https://github.com/simonw/datasette/issues/1461#issuecomment-914441037 | https://api.github.com/repos/simonw/datasette/issues/1461 | IC_kwDOBm6k_c42gUNN | simonw 9599 | 2021-09-07T16:13:59Z | 2021-09-07T16:13:59Z | OWNER | I don't think I'll adopt it for this project. For example, here:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Try blacken-docs 989986586 | |
914644260 | https://github.com/simonw/datasette/issues/1462#issuecomment-914644260 | https://api.github.com/repos/simonw/datasette/issues/1462 | IC_kwDOBm6k_c42hF0k | simonw 9599 | 2021-09-07T21:34:32Z | 2021-09-07T21:34:32Z | OWNER | I think this is a setting. There are two relevant settings at the moment:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Separate out "debug" options from "root" options 990367646 | |
915229323 | https://github.com/simonw/datasette/pull/1463#issuecomment-915229323 | https://api.github.com/repos/simonw/datasette/issues/1463 | IC_kwDOBm6k_c42jUqL | codecov[bot] 22429695 | 2021-09-08T13:15:26Z | 2021-10-13T21:52:23Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1463 +/-==========================================
- Coverage 91.83% 91.83% -0.01% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/views/table.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update beautifulsoup4 requirement from <4.10.0,>=4.8.1 to >=4.8.1,<4.11.0 991121619 | |
915279711 | https://github.com/simonw/datasette/issues/1464#issuecomment-915279711 | https://api.github.com/repos/simonw/datasette/issues/1464 | IC_kwDOBm6k_c42jg9f | ctb 51016 | 2021-09-08T14:16:49Z | 2021-09-08T14:16:49Z | CONTRIBUTOR | on commit d57ab156b35ec642 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
clean checkout & clean environment has test failures 991191951 | |
915299013 | https://github.com/simonw/datasette/issues/1464#issuecomment-915299013 | https://api.github.com/repos/simonw/datasette/issues/1464 | IC_kwDOBm6k_c42jlrF | bobwhitelock 7476523 | 2021-09-08T14:40:28Z | 2021-09-08T14:40:28Z | CONTRIBUTOR | What are the full errors you're getting? This may be the same issue as described in https://github.com/simonw/datasette/pull/1223 - essentially the test suite (and corresponding Datasette features I assume) are by default implicitly dependent on your Sqlite installation having been compiled with the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
clean checkout & clean environment has test failures 991191951 | |
915302885 | https://github.com/simonw/datasette/issues/1464#issuecomment-915302885 | https://api.github.com/repos/simonw/datasette/issues/1464 | IC_kwDOBm6k_c42jmnl | ctb 51016 | 2021-09-08T14:44:50Z | 2021-09-08T14:44:50Z | CONTRIBUTOR | thanks for the response! full errors attached; excerpt: ``` ...
/Users/t/dev/datasette/tests/test_api.py:1115: AssertionError ``` A quick scan of #1223 suggests you're right. Unfortunately, pysqlite3-binary isn't available for Mac OS X, so I can't quickly check that that fixes it; will do so later. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
clean checkout & clean environment has test failures 991191951 | |
915343886 | https://github.com/simonw/datasette/issues/1464#issuecomment-915343886 | https://api.github.com/repos/simonw/datasette/issues/1464 | IC_kwDOBm6k_c42jwoO | bobwhitelock 7476523 | 2021-09-08T15:32:06Z | 2021-09-08T15:32:06Z | CONTRIBUTOR | Thanks, that does look similar!
Ah that makes sense, I guess that's why this isn't just always installed already. I wonder if a possible solution to this issue could be doing feature detection on whether this feature is supported by the current Sqlite version, and if not these tests could be disabled locally? But possibly there's a better way to handle this, will see what @simonw thinks |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
clean checkout & clean environment has test failures 991191951 | |
917642487 | https://github.com/simonw/datasette/issues/1464#issuecomment-917642487 | https://api.github.com/repos/simonw/datasette/issues/1464 | IC_kwDOBm6k_c42shz3 | ctb 51016 | 2021-09-12T14:03:09Z | 2021-09-12T14:03:09Z | CONTRIBUTOR | haven't had time to get back to this, but idle thought that I'm recording for later investigation: how does the continuous integration handle this installation issue? Is it documented there? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
clean checkout & clean environment has test failures 991191951 | |
917839801 | https://github.com/simonw/datasette/issues/1468#issuecomment-917839801 | https://api.github.com/repos/simonw/datasette/issues/1468 | IC_kwDOBm6k_c42tR-5 | simonw 9599 | 2021-09-13T04:54:17Z | 2021-09-13T04:54:17Z | OWNER | Here's a already open issue for this: #972 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Faceting for custom SQL queries 994390593 | |
917839507 | https://github.com/simonw/datasette/issues/1468#issuecomment-917839507 | https://api.github.com/repos/simonw/datasette/issues/1468 | IC_kwDOBm6k_c42tR6T | simonw 9599 | 2021-09-13T04:53:22Z | 2021-09-13T04:53:22Z | OWNER | At the moment this isn't possible - though there's a workaround which is to define a SQL view for the query, at which point facets will be displayed again. I did a lot of the work required to support this when I refactored how facets worked a while back - but to finally implement this I need to refactor the table view and the arbitrary query view to share much more logic than they do at the moment. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Faceting for custom SQL queries 994390593 | |
917839062 | https://github.com/simonw/datasette/issues/1469#issuecomment-917839062 | https://api.github.com/repos/simonw/datasette/issues/1469 | IC_kwDOBm6k_c42tRzW | simonw 9599 | 2021-09-13T04:52:01Z | 2021-09-13T04:52:01Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Column cog shows "facet by this" when already default faceted 994450961 | ||
917840012 | https://github.com/simonw/datasette/issues/1466#issuecomment-917840012 | https://api.github.com/repos/simonw/datasette/issues/1466 | IC_kwDOBm6k_c42tSCM | simonw 9599 | 2021-09-13T04:54:59Z | 2021-09-13T04:54:59Z | OWNER | Especially relevant now that 0.2.0 is out which is a much higher quality release. https://github.com/simonw/datasette-app/releases/tag/0.2.0 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add Datasette Desktop to installation documentation 991467558 | |
918621705 | https://github.com/simonw/datasette/issues/1464#issuecomment-918621705 | https://api.github.com/repos/simonw/datasette/issues/1464 | IC_kwDOBm6k_c42wQ4J | bobwhitelock 7476523 | 2021-09-13T22:17:17Z | 2021-09-13T22:17:17Z | CONTRIBUTOR |
Not certain, but I think tests in CI run on Ubuntu and don't appear to install any additional Sqlite-related dependencies, and so my guess is the version of Sqlite installed by default on Ubuntu has the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
clean checkout & clean environment has test failures 991191951 | |
919135732 | https://github.com/simonw/datasette/pull/1453#issuecomment-919135732 | https://api.github.com/repos/simonw/datasette/issues/1453 | IC_kwDOBm6k_c42yOX0 | dependabot[bot] 49699333 | 2021-09-14T13:10:38Z | 2021-09-14T13:10:38Z | CONTRIBUTOR | Superseded by #1471. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bump black from 21.7b0 to 21.8b0 982780906 | |
919141156 | https://github.com/simonw/datasette/pull/1471#issuecomment-919141156 | https://api.github.com/repos/simonw/datasette/issues/1471 | IC_kwDOBm6k_c42yPsk | codecov[bot] 22429695 | 2021-09-14T13:16:29Z | 2021-10-13T21:12:25Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1471 +/-==========================================
- Coverage 91.83% 91.83% -0.01% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/views/table.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bump black from 21.7b0 to 21.9b0 996002181 | |
939074818 | https://github.com/simonw/datasette/pull/1481#issuecomment-939074818 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-SUC | simonw 9599 | 2021-10-08T19:40:23Z | 2021-10-08T19:40:23Z | OWNER | Then I created myself a temporary 3.10 environment using
And used that with my Datasette checkout like so:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939075686 | https://github.com/simonw/datasette/pull/1481#issuecomment-939075686 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-Shm | simonw 9599 | 2021-10-08T19:42:00Z | 2021-10-08T19:42:00Z | OWNER | Running
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939076399 | https://github.com/simonw/datasette/pull/1481#issuecomment-939076399 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-Ssv | simonw 9599 | 2021-10-08T19:43:33Z | 2021-10-08T19:43:33Z | OWNER | So maybe this is an issue with Janus? I'm using https://pypi.org/project/janus/ 0.6.1 which is the latest release, from October 2020. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939078095 | https://github.com/simonw/datasette/pull/1481#issuecomment-939078095 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-THP | simonw 9599 | 2021-10-08T19:47:29Z | 2021-10-08T19:47:29Z | OWNER | Only mention I can find of that "loop argument must agree with lock" error is here - which doesn't have any tips for a workaround yet: https://giters.com/django/channels_redis/issues/278 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939078872 | https://github.com/simonw/datasette/pull/1481#issuecomment-939078872 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-TTY | simonw 9599 | 2021-10-08T19:49:08Z | 2021-10-08T19:49:08Z | OWNER | Here's the code that raises that error: https://github.com/python/cpython/blob/bb3e0c240bc60fe08d332ff5955d54197f79751c/Lib/asyncio/locks.py#L219-L234 ```python class Condition(_ContextManagerMixin, mixins._LoopBoundMixin): """Asynchronous equivalent to threading.Condition. This class implements condition variable objects. A condition variable allows one or more coroutines to wait until they are notified by another coroutine. A new Lock object is created and used as the underlying lock. """
``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939079727 | https://github.com/simonw/datasette/pull/1481#issuecomment-939079727 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-Tgv | simonw 9599 | 2021-10-08T19:50:52Z | 2021-10-08T19:50:52Z | OWNER | And here's the relevant Janus code: https://github.com/aio-libs/janus/blob/d7970f8b76bcac2e087067ca4575ac845e481874/janus/init.py#L24-L42 ```python class Queue(Generic[T]): def init(self, maxsize: int = 0) -> None: self._loop = current_loop() self._maxsize = maxsize
``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939100803 | https://github.com/simonw/datasette/pull/1481#issuecomment-939100803 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-YqD | simonw 9599 | 2021-10-08T20:33:42Z | 2021-10-08T20:33:42Z | OWNER | There's a tiny chance this could be a bug in Python 3.10 itself - I filed an issue here: https://bugs.python.org/issue45416 - in which I said:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939180313 | https://github.com/simonw/datasette/pull/1481#issuecomment-939180313 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-sEZ | simonw 9599 | 2021-10-08T23:41:39Z | 2021-10-08T23:41:39Z | OWNER | I submitted a PR to Janus with a workaround for this: https://github.com/aio-libs/janus/pull/359 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939185319 | https://github.com/simonw/datasette/pull/1481#issuecomment-939185319 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c43-tSn | simonw 9599 | 2021-10-09T00:04:54Z | 2021-10-09T00:04:54Z | OWNER | I applied my PR against Janus to my local copy of Datasette like so:
Then I ran the Datasette tests and got a much happier pass rate. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
939191311 | https://github.com/simonw/datasette/issues/1482#issuecomment-939191311 | https://api.github.com/repos/simonw/datasette/issues/1482 | IC_kwDOBm6k_c43-uwP | simonw 9599 | 2021-10-09T00:35:04Z | 2021-10-09T00:35:04Z | OWNER | I think that SQLite error message difference was caused by https://github.com/python/cpython/commit/a50e28377bcf37121b55c2de70d95a5386c478f8 or related work. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support Python 3.10 1021550542 | |
938171377 | https://github.com/simonw/datasette/issues/1480#issuecomment-938171377 | https://api.github.com/repos/simonw/datasette/issues/1480 | IC_kwDOBm6k_c4361vx | ghing 110420 | 2021-10-07T21:33:12Z | 2021-10-07T21:33:12Z | CONTRIBUTOR | Thanks for the reply @simonw. What services have you had better success with than Cloud Run for larger database? Also, what about my issue description makes you think there may be a workaround? Is there any instrumentation I could add to see at which point in the deploy the memory usage spikes? Should I be able to see this whether it's running under Docker locally, or do you suspect this is Cloud Run-specific? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Exceeding Cloud Run memory limits when deploying a 4.8G database 1015646369 | |
938124652 | https://github.com/simonw/datasette/issues/1470#issuecomment-938124652 | https://api.github.com/repos/simonw/datasette/issues/1470 | IC_kwDOBm6k_c436qVs | simonw 9599 | 2021-10-07T20:17:53Z | 2021-10-07T20:18:55Z | OWNER | Here's the exception:
So the bug is in this code: https://github.com/simonw/datasette/blob/adb5b70de5cec3c3dd37184defe606a082c232cf/datasette/views/table.py#L604-L617 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
?_sort=rowid with _next= returns error 995098231 | |
938131806 | https://github.com/simonw/datasette/issues/1470#issuecomment-938131806 | https://api.github.com/repos/simonw/datasette/issues/1470 | IC_kwDOBm6k_c436sFe | simonw 9599 | 2021-10-07T20:28:30Z | 2021-10-07T20:28:30Z | OWNER | On further investigation this isn't related to
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
?_sort=rowid with _next= returns error 995098231 | |
938134038 | https://github.com/simonw/datasette/issues/1480#issuecomment-938134038 | https://api.github.com/repos/simonw/datasette/issues/1480 | IC_kwDOBm6k_c436soW | simonw 9599 | 2021-10-07T20:31:46Z | 2021-10-07T20:31:46Z | OWNER | I've had this problem too - my solution was to not use Cloud Run for databases larger than about 2GB, but the way you describe it here makes me think that maybe there is a workaround here which could get it to work. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Exceeding Cloud Run memory limits when deploying a 4.8G database 1015646369 | |
938141121 | https://github.com/simonw/datasette/pull/1481#issuecomment-938141121 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c436uXB | codecov[bot] 22429695 | 2021-10-07T20:42:37Z | 2021-10-24T22:19:28Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1481 +/-==========================================
- Coverage 91.83% 91.82% -0.02% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/app.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
938142436 | https://github.com/simonw/datasette/pull/1481#issuecomment-938142436 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c436urk | simonw 9599 | 2021-10-07T20:44:43Z | 2021-10-07T20:44:43Z | OWNER | The 3.10 tests failed a lot. Trying to run this locally: ``` /tmp % pyenv install 3.10 python-build: definition not found: 3.10 The following versions contain `3.10' in the name: 3.10.0a6 3.10-dev miniconda-3.10.1 miniconda3-3.10.1 See all available versions with `pyenv install --list'. If the version you need is missing, try upgrading pyenv: brew update && brew upgrade pyenv ``` So trying:
Then did this:
But it looks like I have
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fix compatibility with Python 3.10 1020436713 | |
923106887 | https://github.com/simonw/datasette/issues/111#issuecomment-923106887 | https://api.github.com/repos/simonw/datasette/issues/111 | IC_kwDOBm6k_c43BX5H | simonw 9599 | 2021-09-20T16:58:39Z | 2021-09-20T16:58:39Z | OWNER | Still a good idea today too! Would be great for https://cdc-vaccination-history.datasette.io/ for example. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add “updated” to metadata 274615452 | |
923979964 | https://github.com/simonw/datasette/pull/1476#issuecomment-923979964 | https://api.github.com/repos/simonw/datasette/issues/1476 | IC_kwDOBm6k_c43EtC8 | codecov[bot] 22429695 | 2021-09-21T13:18:22Z | 2021-09-21T13:18:22Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1476 +/-=======================================
Coverage 91.83% 91.83% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update pytest-xdist requirement from <2.4,>=2.2.1 to >=2.2.1,<2.5 1002459220 | |
924432643 | https://github.com/simonw/datasette/issues/111#issuecomment-924432643 | https://api.github.com/repos/simonw/datasette/issues/111 | IC_kwDOBm6k_c43GbkD | simonw 9599 | 2021-09-21T22:23:23Z | 2021-09-21T22:23:23Z | OWNER | I'm going to use https://github.com/dateutil/dateutil for this - it's been maintained constantly (by an evolving team of contributors) since 2003 and is a very trustworthy dependency. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add “updated” to metadata 274615452 | |
924437942 | https://github.com/simonw/datasette/issues/111#issuecomment-924437942 | https://api.github.com/repos/simonw/datasette/issues/111 | IC_kwDOBm6k_c43Gc22 | simonw 9599 | 2021-09-21T22:32:59Z | 2021-09-21T22:47:07Z | OWNER | Side-note: Django 4.0 will switch from using If I need to handle timezones I'll use that, but I think I can get away without it? Django does this: https://github.com/django/django/blob/b0ed619303d2fb723330ca9efa3acf23d49f1d19/setup.cfg#L39-L43
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add “updated” to metadata 274615452 | |
924435971 | https://github.com/simonw/datasette/issues/111#issuecomment-924435971 | https://api.github.com/repos/simonw/datasette/issues/111 | IC_kwDOBm6k_c43GcYD | simonw 9599 | 2021-09-21T22:29:15Z | 2021-09-21T22:29:49Z | OWNER | So this is a metadata key called Question: should I support just the date - I think so. I can easily imagine situations where the exact time of day that a change was made hasn't been recorded, but the overall date is known. But in that case, should the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add “updated” to metadata 274615452 | |
924438481 | https://github.com/simonw/datasette/issues/111#issuecomment-924438481 | https://api.github.com/repos/simonw/datasette/issues/111 | IC_kwDOBm6k_c43Gc_R | simonw 9599 | 2021-09-21T22:34:03Z | 2021-09-21T22:34:21Z | OWNER | The simplest possible version of this: it's always represented as a UTC ISO datetime, like this:
Later versions of Datasette could extend this to handle other timezones or support just the date (though that's a backwards incompatible change so probably better to decide on the date thing right now). |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add “updated” to metadata 274615452 | |
924443089 | https://github.com/simonw/datasette/issues/111#issuecomment-924443089 | https://api.github.com/repos/simonw/datasette/issues/111 | IC_kwDOBm6k_c43GeHR | simonw 9599 | 2021-09-21T22:45:14Z | 2021-09-21T22:45:26Z | OWNER | The audiences I care about here are:
For producers I think there are going to be two categories. The first is users who run "publish" and want the site to reflect when they did so (probably using For humans... I'd like to be able to calculate a relative time (3 hours ago) in addition to showing the display time, because that helps avoid confusion over timezones. For machine consumers, it might be nice to offer the option of a calculated Unix timestamp-since-1970, since those can be easier to work with in some languages than running a full ISO date parser. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add “updated” to metadata 274615452 | |
939386591 | https://github.com/simonw/datasette/issues/1470#issuecomment-939386591 | https://api.github.com/repos/simonw/datasette/issues/1470 | IC_kwDOBm6k_c43_ebf | simonw 9599 | 2021-10-10T01:17:34Z | 2021-10-10T01:17:34Z | OWNER | I'll open a separate issue for removing |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
?_sort=rowid with _next= returns error 995098231 | |
930071625 | https://github.com/simonw/datasette/issues/1479#issuecomment-930071625 | https://api.github.com/repos/simonw/datasette/issues/1479 | IC_kwDOBm6k_c43b8RJ | kirajano 76450761 | 2021-09-29T11:01:30Z | 2021-09-29T11:01:30Z | NONE | Thanks, but this one has a different error type. Unfortunately, still not working. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Win32 "used by another process" error with datasette publish 1010112818 | |
929927144 | https://github.com/simonw/datasette/issues/1479#issuecomment-929927144 | https://api.github.com/repos/simonw/datasette/issues/1479 | IC_kwDOBm6k_c43bY_o | soobrosa 1244799 | 2021-09-29T07:49:40Z | 2021-09-29T07:49:40Z | NONE | My search yielded these four entries: https://github.com/simonw/datasette/issues?q=PermissionError%3A+%5BWinError+32%5D+ Maybe this is the closet hit? https://github.com/simonw/datasette/issues/744 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Win32 "used by another process" error with datasette publish 1010112818 | |
932807859 | https://github.com/simonw/datasette/issues/1479#issuecomment-932807859 | https://api.github.com/repos/simonw/datasette/issues/1479 | IC_kwDOBm6k_c43mYSz | simonw 9599 | 2021-10-02T19:22:35Z | 2021-10-02T19:22:35Z | OWNER | I'm pretty sure this is a Windows issue, not a Fly issue. I imagine it affects other forms of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Win32 "used by another process" error with datasette publish 1010112818 | |
932808043 | https://github.com/simonw/datasette/issues/1479#issuecomment-932808043 | https://api.github.com/repos/simonw/datasette/issues/1479 | IC_kwDOBm6k_c43mYVr | simonw 9599 | 2021-10-02T19:23:52Z | 2021-10-02T19:23:52Z | OWNER | I suspect the root cause of this may be in this code: https://github.com/simonw/datasette/blob/63886178a649586b403966a27a45881709d2b868/datasette/utils/init.py#L673-L677 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Win32 "used by another process" error with datasette publish 1010112818 | |
932808216 | https://github.com/simonw/datasette/issues/1479#issuecomment-932808216 | https://api.github.com/repos/simonw/datasette/issues/1479 | IC_kwDOBm6k_c43mYYY | simonw 9599 | 2021-10-02T19:25:09Z | 2021-10-02T19:25:09Z | OWNER | Actually no, from that stack trace you provided:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Win32 "used by another process" error with datasette publish 1010112818 | |
953334718 | https://github.com/simonw/datasette/issues/1380#issuecomment-953334718 | https://api.github.com/repos/simonw/datasette/issues/1380 | IC_kwDOBm6k_c440ru- | glasnt 813732 | 2021-10-27T21:45:04Z | 2021-10-27T21:45:04Z | CONTRIBUTOR | I am also getting this issue, using the currently most recent version of datasette
If I run
Adding new files while datasette is running shows no new files, and removing files causes datasette to return 500 errors.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve all db files in a folder 924748955 | |
953366110 | https://github.com/simonw/datasette/issues/1380#issuecomment-953366110 | https://api.github.com/repos/simonw/datasette/issues/1380 | IC_kwDOBm6k_c440zZe | glasnt 813732 | 2021-10-27T22:48:55Z | 2021-10-27T22:48:55Z | CONTRIBUTOR | It looks like if the files argument is a directory, I tried seeing if I could get
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve all db files in a folder 924748955 | |
953508979 | https://github.com/simonw/datasette/issues/1497#issuecomment-953508979 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c441WRz | simonw 9599 | 2021-10-28T05:13:49Z | 2021-10-28T05:13:49Z | OWNER | Wrote about this in my weeknotes: https://simonwillison.net/2021/Oct/28/weeknotes-kubernetes-web-components/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
954384496 | https://github.com/simonw/datasette/pull/1495#issuecomment-954384496 | https://api.github.com/repos/simonw/datasette/issues/1495 | IC_kwDOBm6k_c444sBw | fgregg 536941 | 2021-10-29T03:07:13Z | 2021-10-29T03:07:13Z | CONTRIBUTOR | okay @simonw, made the requested changes. tests are running locally. i think this is ready for you to look at again. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow routes to have extra options 1033678984 | |
955384545 | https://github.com/simonw/datasette/issues/1253#issuecomment-955384545 | https://api.github.com/repos/simonw/datasette/issues/1253 | IC_kwDOBm6k_c448gLh | dufferzafar 1449512 | 2021-10-30T16:00:42Z | 2021-10-30T16:00:42Z | NONE | Yeah, I was pressing Ctrl + Enter as well. Came here to open this issue and found out Shift + Enter works. @simonw Any way to configure this? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Capture "Ctrl + Enter" or "⌘ + Enter" to send SQL query? 826064552 | |
940023938 | https://github.com/simonw/datasette/pull/1485#issuecomment-940023938 | https://api.github.com/repos/simonw/datasette/issues/1485 | IC_kwDOBm6k_c44B6CC | codecov[bot] 22429695 | 2021-10-11T13:18:16Z | 2021-10-11T13:18:16Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1485 +/-=======================================
Coverage 91.83% 91.83% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update pytest-timeout requirement from <1.5,>=1.4.2 to >=1.4.2,<2.1 1022688960 | |
941002127 | https://github.com/simonw/datasette/issues/1432#issuecomment-941002127 | https://api.github.com/repos/simonw/datasette/issues/1432 | IC_kwDOBm6k_c44Fo2P | ashishdotme 5802411 | 2021-10-12T13:14:31Z | 2021-10-12T13:14:39Z | NONE | Any workaround for making it work with datasette-publish-vercel. Currently getting below error module initialization error: init() got an unexpected keyword argument 'config' module initialization error init() got an unexpected keyword argument 'config' |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rename Datasette.__init__(config=) parameter to settings= 969855774 | |
941585767 | https://github.com/simonw/datasette/issues/1432#issuecomment-941585767 | https://api.github.com/repos/simonw/datasette/issues/1432 | IC_kwDOBm6k_c44H3Vn | ashishdotme 5802411 | 2021-10-12T21:23:19Z | 2021-10-12T21:23:19Z | NONE | Nevermind, had to remove the branch argument in the workflow to make vercel publish work |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rename Datasette.__init__(config=) parameter to settings= 969855774 | |
942722595 | https://github.com/simonw/datasette/pull/1487#issuecomment-942722595 | https://api.github.com/repos/simonw/datasette/issues/1487 | IC_kwDOBm6k_c44MM4j | simonw 9599 | 2021-10-13T21:08:53Z | 2021-10-13T21:08:53Z | OWNER | Thanks for this! |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Added instructions for installing plugins via pipx, #1486 1023245060 | |
942725632 | https://github.com/simonw/datasette/issues/1469#issuecomment-942725632 | https://api.github.com/repos/simonw/datasette/issues/1469 | IC_kwDOBm6k_c44MNoA | simonw 9599 | 2021-10-13T21:13:30Z | 2021-10-13T21:13:30Z | OWNER | The core problem here is treating the Instead, I could use a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Column cog shows "facet by this" when already default faceted 994450961 | |
942779926 | https://github.com/simonw/datasette/issues/1488#issuecomment-942779926 | https://api.github.com/repos/simonw/datasette/issues/1488 | IC_kwDOBm6k_c44Ma4W | simonw 9599 | 2021-10-13T22:59:05Z | 2021-10-13T22:59:05Z | OWNER | This is weird - as far as I can tell |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125 | |
942777414 | https://github.com/simonw/datasette/issues/1488#issuecomment-942777414 | https://api.github.com/repos/simonw/datasette/issues/1488 | IC_kwDOBm6k_c44MaRG | simonw 9599 | 2021-10-13T22:52:40Z | 2021-10-13T22:52:40Z | OWNER | Upgrading to 0.20.0 gives me lots of the following errors:
It looks like the full query string is now being treated as the name of the database. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125 | |
942778382 | https://github.com/simonw/datasette/issues/1488#issuecomment-942778382 | https://api.github.com/repos/simonw/datasette/issues/1488 | IC_kwDOBm6k_c44MagO | simonw 9599 | 2021-10-13T22:55:01Z | 2021-10-13T22:55:01Z | OWNER | I think the issue is in
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user >30