issue_comments
25 rows where "updated_at" is on date 2022-02-03 sorted by author_association
This data as json, CSV (advanced)
Suggested facets: issue_url, reactions, created_at (date)
user 3
- simonw 17
- eyeseast 7
- codecov[bot] 1
id | html_url | issue_url | node_id | user | created_at | updated_at | author_association ▼ | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1029175907 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029175907 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49V_pj | eyeseast 25778 | 2022-02-03T16:36:54Z | 2022-02-03T16:36:54Z | CONTRIBUTOR | @simonw Not sure if you've seen this, but any chance you can run the tests? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029180984 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029180984 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49WA44 | eyeseast 25778 | 2022-02-03T16:42:04Z | 2022-02-03T16:42:04Z | CONTRIBUTOR | Fixed my spelling. That's a useful thing. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029306428 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029306428 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49Wfg8 | eyeseast 25778 | 2022-02-03T19:03:43Z | 2022-02-03T19:03:43Z | CONTRIBUTOR | I thought about adding these as methods on I do sort of like having all the Spatialite stuff in its own module, just because it's built around an extension you might not have or want, but I don't know if that's a good reason to have a different API. You could have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029317527 | https://github.com/simonw/sqlite-utils/issues/79#issuecomment-1029317527 | https://api.github.com/repos/simonw/sqlite-utils/issues/79 | IC_kwDOCGYnMM49WiOX | eyeseast 25778 | 2022-02-03T19:18:02Z | 2022-02-03T19:18:02Z | CONTRIBUTOR | Taking part of the conversation from #385 here.
Yes. And also |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Helper methods for working with SpatiaLite 557842245 | |
1029326568 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029326568 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49Wkbo | eyeseast 25778 | 2022-02-03T19:28:26Z | 2022-02-03T19:28:26Z | CONTRIBUTOR |
This is fixed now. I had to take out the type annotations for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029338360 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029338360 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49WnT4 | eyeseast 25778 | 2022-02-03T19:43:56Z | 2022-02-03T19:43:56Z | CONTRIBUTOR | Works for me. I was just looking at how the FTS extensions work and they're just methods, too. So this can be consistent with that. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029370537 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029370537 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49WvKp | eyeseast 25778 | 2022-02-03T20:25:58Z | 2022-02-03T20:25:58Z | CONTRIBUTOR | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | ||
1028419517 | https://github.com/simonw/datasette/pull/1617#issuecomment-1028419517 | https://api.github.com/repos/simonw/datasette/issues/1617 | IC_kwDOBm6k_c49TG-9 | codecov[bot] 22429695 | 2022-02-02T22:30:26Z | 2022-02-03T01:36:07Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1617 +/-==========================================
+ Coverage 92.09% 92.16% +0.06% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/app.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure template_path always uses "/" to match jinja 1120990806 | |
1028515161 | https://github.com/simonw/datasette/pull/1626#issuecomment-1028515161 | https://api.github.com/repos/simonw/datasette/issues/1626 | IC_kwDOBm6k_c49TeVZ | simonw 9599 | 2022-02-03T01:22:43Z | 2022-02-03T01:22:43Z | OWNER | OK, the tests do NOT pass against Windows! https://github.com/simonw/datasette/runs/5044105941 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Try test suite against macOS and Windows 1122451096 | |
1028517073 | https://github.com/simonw/datasette/pull/1617#issuecomment-1028517073 | https://api.github.com/repos/simonw/datasette/issues/1617 | IC_kwDOBm6k_c49TezR | simonw 9599 | 2022-02-03T01:26:32Z | 2022-02-03T01:26:32Z | OWNER | Aha I understand the problem now! https://github.com/pallets/jinja/issues/1378#issuecomment-812410922
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure template_path always uses "/" to match jinja 1120990806 | |
1028517268 | https://github.com/simonw/datasette/issues/1545#issuecomment-1028517268 | https://api.github.com/repos/simonw/datasette/issues/1545 | IC_kwDOBm6k_c49Te2U | simonw 9599 | 2022-02-03T01:26:53Z | 2022-02-03T01:26:53Z | OWNER | I understand the problem now! https://github.com/pallets/jinja/issues/1378#issuecomment-812410922
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Custom pages don't work on windows 1075893249 | |
1028519382 | https://github.com/simonw/datasette/pull/1617#issuecomment-1028519382 | https://api.github.com/repos/simonw/datasette/issues/1617 | IC_kwDOBm6k_c49TfXW | simonw 9599 | 2022-02-03T01:31:25Z | 2022-02-03T01:31:25Z | OWNER | I was hoping to get the test suite running on Windows before merging this PR but that looks like it will be a BIG job, see: - #1627 So I'm going to merge this one as-is for the moment. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure template_path always uses "/" to match jinja 1120990806 | |
1028535868 | https://github.com/simonw/datasette/issues/1545#issuecomment-1028535868 | https://api.github.com/repos/simonw/datasette/issues/1545 | IC_kwDOBm6k_c49TjY8 | simonw 9599 | 2022-02-03T02:08:30Z | 2022-02-03T02:08:30Z | OWNER | Filed an issue with Jinja suggesting a documentation update: - https://github.com/pallets/jinja/issues/1578 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Custom pages don't work on windows 1075893249 | |
1029177015 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029177015 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49V_63 | simonw 9599 | 2022-02-03T16:38:02Z | 2022-02-03T16:38:02Z | OWNER | Sorry had missed this - tests should run now. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029273853 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029273853 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49WXj9 | simonw 9599 | 2022-02-03T18:23:30Z | 2022-02-03T18:31:21Z | OWNER | OK, this change makes a bunch of sense to me - and also raises some interesting questions about future additions to I see you've already talked about that in #79 - moving this conversation there! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029285985 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029285985 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49Wahh | simonw 9599 | 2022-02-03T18:37:48Z | 2022-02-03T18:37:48Z | OWNER |
https://sqlite-utils.datasette.io/en/3.22.1/python-api.html#finding-spatialite To avoid needing to bump the major version number to 4 to indicate a backwards incompatible change, we should keep a |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029296782 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029296782 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49WdKO | simonw 9599 | 2022-02-03T18:51:21Z | 2022-02-03T18:51:21Z | OWNER | What do you think about adding these as methods on the ```python This is with an optional argument, which if omitted runs find_spatialite() for you:db.init_spatialite() Instead of:init_spatialite(db, find_spatialite())
Instead of this:add_geometry_column(db["locations"], "POINT", "geometry") create_spatial_index(db["locations"], "geometry") Could have this:db["locations"].add_geometry_column("POINT")
db["locations"].create_spatial_index("geometry")
But on the other hand... this is mixing SpatiaLite functionality directly into the core classes. Is that a good idea, seeing as SpatiaLite is both an optional extension (which can be tricky to install) AND something that has a very different release cadence and quality-of-documentation from SQLite itself? There's a third option: the SpatiaLite could exist on subclasses of ```python from sqlite_utils.gis import SpatiaLiteDatabase db = SpatiaLiteDatabase("geo.db") db.init_spatialite() db["locations"].add_geometry_column("POINT") db["locations"].create_spatial_index("geometry") ``` On the one hand, this would keep the SpatiaLite-specific stuff out of the core Database/Table classes. But it feels a bit untidy to me, especially since it raises the spectre of someone who was already subclassing Database for some reason now needing to instead subclass So I don't have a strong opinion formed on this question yet! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029297971 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029297971 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49Wdcz | simonw 9599 | 2022-02-03T18:52:50Z | 2022-02-03T18:52:50Z | OWNER | I'm not sure I like |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029335225 | https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029335225 | https://api.github.com/repos/simonw/sqlite-utils/issues/385 | IC_kwDOCGYnMM49Wmi5 | simonw 9599 | 2022-02-03T19:39:40Z | 2022-02-03T19:39:40Z | OWNER |
Yeah that's too clever. You know what? I'm pretty confident we are both massively over-thinking this. We should put the methods on |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add new spatialite helper methods 1102899312 | |
1029402029 | https://github.com/simonw/sqlite-utils/issues/394#issuecomment-1029402029 | https://api.github.com/repos/simonw/sqlite-utils/issues/394 | IC_kwDOCGYnMM49W22t | simonw 9599 | 2022-02-03T21:06:35Z | 2022-02-03T21:06:35Z | OWNER | This broke on Windows: https://github.com/simonw/sqlite-utils/runs/5056912641 ``` if recreate and os.path.exists(filename_or_conn):
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Test against Python 3.11-dev 1122446693 | |
1029402837 | https://github.com/simonw/sqlite-utils/issues/369#issuecomment-1029402837 | https://api.github.com/repos/simonw/sqlite-utils/issues/369 | IC_kwDOCGYnMM49W3DV | simonw 9599 | 2022-02-03T21:07:35Z | 2022-02-03T21:07:35Z | OWNER | Closing this - it was something I was curious about, but evidently not curious enough to actually do the work! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Research how much of a difference analyze / sqlite_stat1 makes 1097091527 | |
1029450617 | https://github.com/simonw/sqlite-utils/issues/393#issuecomment-1029450617 | https://api.github.com/repos/simonw/sqlite-utils/issues/393 | IC_kwDOCGYnMM49XCt5 | simonw 9599 | 2022-02-03T22:13:24Z | 2022-02-03T22:13:24Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better documentation for insert-replace 1118585417 | ||
1029469630 | https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1029469630 | https://api.github.com/repos/simonw/sqlite-utils/issues/363 | IC_kwDOCGYnMM49XHW- | simonw 9599 | 2022-02-03T22:42:36Z | 2022-02-03T22:42:36Z | OWNER |
Actually no that doesn't work, because this line causes an error before we even get to |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better error message if `--convert` code fails to return a dict 1094981339 | |
1029475387 | https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1029475387 | https://api.github.com/repos/simonw/sqlite-utils/issues/363 | IC_kwDOCGYnMM49XIw7 | simonw 9599 | 2022-02-03T22:52:30Z | 2022-02-03T22:52:30Z | OWNER | Demos:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better error message if `--convert` code fails to return a dict 1094981339 | |
1029479388 | https://github.com/simonw/sqlite-utils/issues/352#issuecomment-1029479388 | https://api.github.com/repos/simonw/sqlite-utils/issues/352 | IC_kwDOCGYnMM49XJvc | simonw 9599 | 2022-02-03T22:59:35Z | 2022-02-03T22:59:35Z | OWNER | Ran into this bug again while writing tests for this: - #186 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`sqlite-utils insert --extract colname` 1072792507 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 10