issue_comments
8,358 rows where author_association = "OWNER" sorted by updated_at descending
This data as json, CSV (advanced)
user 1
- simonw 3,422
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
719110808 | https://github.com/simonw/datasette/issues/1064#issuecomment-719110808 | https://api.github.com/repos/simonw/datasette/issues/1064 | MDEyOklzc3VlQ29tbWVudDcxOTExMDgwOA== | simonw 9599 | 2020-10-30T01:12:09Z | 2020-10-30T01:12:19Z | OWNER | Or... plugins could return HTML - maybe optionally using helper functions to generate common HTML such that plugins which use the helpers can have their HTML modified in the future. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Navigation menu plus plugin hook 732798913 | |
719110582 | https://github.com/simonw/datasette/issues/1064#issuecomment-719110582 | https://api.github.com/repos/simonw/datasette/issues/1064 | MDEyOklzc3VlQ29tbWVudDcxOTExMDU4Mg== | simonw 9599 | 2020-10-30T01:11:13Z | 2020-10-30T01:11:13Z | OWNER | Should plugins be able to add forms like the logout form here, or should they be restricted to adding navigation links? I can't think of a reason a plugin would need to add a form. The logout form is a special case to protect against logout-csrf attacks. So I think plugins get to return a list of dictionaries, each with a
I think so. I also like the idea that a default plugin checks for the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Navigation menu plus plugin hook 732798913 | |
719109770 | https://github.com/simonw/datasette/issues/1064#issuecomment-719109770 | https://api.github.com/repos/simonw/datasette/issues/1064 | MDEyOklzc3VlQ29tbWVudDcxOTEwOTc3MA== | simonw 9599 | 2020-10-30T01:08:14Z | 2020-10-30T01:08:14Z | OWNER | How should the plugin hook work? Here's the first version of the HTML:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Navigation menu plus plugin hook 732798913 | |
719106174 | https://github.com/simonw/datasette/issues/1064#issuecomment-719106174 | https://api.github.com/repos/simonw/datasette/issues/1064 | MDEyOklzc3VlQ29tbWVudDcxOTEwNjE3NA== | simonw 9599 | 2020-10-30T00:55:12Z | 2020-10-30T00:55:12Z | OWNER | So what should go in this menu? If the user is logged in as root, I'll link to the various debug pages. If they're not logged in at all I don't think the menu should appear. If they are logged in as anyone, it should display to give them access to the "log out" button. Plugins can add links to it. If those plugins add links, the menu will display. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Navigation menu plus plugin hook 732798913 | |
719105641 | https://github.com/simonw/datasette/issues/1064#issuecomment-719105641 | https://api.github.com/repos/simonw/datasette/issues/1064 | MDEyOklzc3VlQ29tbWVudDcxOTEwNTY0MQ== | simonw 9599 | 2020-10-30T00:53:00Z | 2020-10-30T00:53:00Z | OWNER | Tips for making this accessible: https://css-tricks.com/accessible-svgs/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Navigation menu plus plugin hook 732798913 | |
719104883 | https://github.com/simonw/datasette/issues/1064#issuecomment-719104883 | https://api.github.com/repos/simonw/datasette/issues/1064 | MDEyOklzc3VlQ29tbWVudDcxOTEwNDg4Mw== | simonw 9599 | 2020-10-30T00:50:01Z | 2020-10-30T00:52:29Z | OWNER | Here's what the prototype looks like so far: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Navigation menu plus plugin hook 732798913 | |
719105197 | https://github.com/simonw/datasette/issues/1064#issuecomment-719105197 | https://api.github.com/repos/simonw/datasette/issues/1064 | MDEyOklzc3VlQ29tbWVudDcxOTEwNTE5Nw== | simonw 9599 | 2020-10-30T00:51:16Z | 2020-10-30T00:51:16Z | OWNER | I used a I added a bit of JavaScript so that clicking outside the menu would close it: https://github.com/simonw/datasette/blob/0d7ac764861d84be24d661cf4104ce61ea11a82a/datasette/templates/base.html#L59-L74 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Navigation menu plus plugin hook 732798913 | |
719094027 | https://github.com/simonw/datasette/issues/1034#issuecomment-719094027 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxOTA5NDAyNw== | simonw 9599 | 2020-10-30T00:11:17Z | 2020-10-30T00:11:17Z | OWNER | Demos: https://latest.datasette.io/fixtures/binary_data.csv?_size=max
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
719066706 | https://github.com/simonw/datasette/issues/1063#issuecomment-719066706 | https://api.github.com/repos/simonw/datasette/issues/1063 | MDEyOklzc3VlQ29tbWVudDcxOTA2NjcwNg== | simonw 9599 | 2020-10-29T22:46:28Z | 2020-10-29T22:46:28Z | OWNER | I'm not going to do the base64 thing unless someone asks for it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
.csv should link to .blob downloads 732685643 | |
719053669 | https://github.com/simonw/datasette/issues/1051#issuecomment-719053669 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxOTA1MzY2OQ== | simonw 9599 | 2020-10-29T22:12:16Z | 2020-10-29T22:12:16Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | ||
719050754 | https://github.com/simonw/datasette/issues/1034#issuecomment-719050754 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxOTA1MDc1NA== | simonw 9599 | 2020-10-29T22:04:52Z | 2020-10-29T22:04:52Z | OWNER | I'm going to link to. the new |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
719050390 | https://github.com/simonw/datasette/issues/1063#issuecomment-719050390 | https://api.github.com/repos/simonw/datasette/issues/1063 | MDEyOklzc3VlQ29tbWVudDcxOTA1MDM5MA== | simonw 9599 | 2020-10-29T22:04:00Z | 2020-10-29T22:04:00Z | OWNER | This will close #1034. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
.csv should link to .blob downloads 732685643 | |
719042601 | https://github.com/simonw/datasette/pull/1061#issuecomment-719042601 | https://api.github.com/repos/simonw/datasette/issues/1061 | MDEyOklzc3VlQ29tbWVudDcxOTA0MjYwMQ== | simonw 9599 | 2020-10-29T21:45:35Z | 2020-10-29T21:50:42Z | OWNER | Moving the CSV work to a separate issue. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
.blob output renderer 732634375 | |
719043108 | https://github.com/simonw/datasette/issues/1063#issuecomment-719043108 | https://api.github.com/repos/simonw/datasette/issues/1063 | MDEyOklzc3VlQ29tbWVudDcxOTA0MzEwOA== | simonw 9599 | 2020-10-29T21:46:48Z | 2020-10-29T21:46:48Z | OWNER | Remove this |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
.csv should link to .blob downloads 732685643 | |
719035336 | https://github.com/simonw/datasette/pull/1061#issuecomment-719035336 | https://api.github.com/repos/simonw/datasette/issues/1061 | MDEyOklzc3VlQ29tbWVudDcxOTAzNTMzNg== | simonw 9599 | 2020-10-29T21:29:29Z | 2020-10-29T21:29:29Z | OWNER | Those display_rows have already been processed by the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
.blob output renderer 732634375 | |
719033013 | https://github.com/simonw/datasette/pull/1061#issuecomment-719033013 | https://api.github.com/repos/simonw/datasette/issues/1061 | MDEyOklzc3VlQ29tbWVudDcxOTAzMzAxMw== | simonw 9599 | 2020-10-29T21:27:14Z | 2020-10-29T21:27:14Z | OWNER | Next challenge: link to This will be a bit tricky. Here's how that template works at the moment: https://github.com/simonw/datasette/blob/d6f9ff71378c4eab34dad181c23cfc143a4aef2d/datasette/templates/query.html#L69-L77 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
.blob output renderer 732634375 | |
719031901 | https://github.com/simonw/datasette/issues/1062#issuecomment-719031901 | https://api.github.com/repos/simonw/datasette/issues/1062 | MDEyOklzc3VlQ29tbWVudDcxOTAzMTkwMQ== | simonw 9599 | 2020-10-29T21:25:54Z | 2020-10-29T21:25:54Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor .csv to be an output renderer - and teach register_output_renderer to stream all rows 732674148 | ||
719021514 | https://github.com/simonw/datasette/issues/1050#issuecomment-719021514 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxOTAyMTUxNA== | simonw 9599 | 2020-10-29T21:05:08Z | 2020-10-29T21:05:08Z | OWNER | Idea: what if Datasette had a custom SQLite function that could be used to generate URLs to the row-level BLOB download for a value? Then custom SQL query authors could use that function to link to the relevant content. This could be expanded to exposing other |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
719001701 | https://github.com/simonw/datasette/issues/1050#issuecomment-719001701 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxOTAwMTcwMQ== | simonw 9599 | 2020-10-29T20:26:44Z | 2020-10-29T20:26:44Z | OWNER | I'll do the rest of the work on this in the pull request #1061. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
718989895 | https://github.com/simonw/datasette/issues/1050#issuecomment-718989895 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxODk4OTg5NQ== | simonw 9599 | 2020-10-29T20:04:15Z | 2020-10-29T20:04:15Z | OWNER | I'll use |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
718987852 | https://github.com/simonw/datasette/issues/1050#issuecomment-718987852 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxODk4Nzg1Mg== | simonw 9599 | 2020-10-29T20:00:32Z | 2020-10-29T20:00:32Z | OWNER | The reason I like the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
718980944 | https://github.com/simonw/datasette/issues/1050#issuecomment-718980944 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxODk4MDk0NA== | simonw 9599 | 2020-10-29T19:46:19Z | 2020-10-29T19:46:19Z | OWNER | Had an idea in https://github.com/simonw/datasette/issues/1051#issuecomment-718980659
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
718980659 | https://github.com/simonw/datasette/issues/1051#issuecomment-718980659 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxODk4MDY1OQ== | simonw 9599 | 2020-10-29T19:45:42Z | 2020-10-29T19:45:42Z | OWNER | OK, alternative idea. The For an arbitrary SQL query, how about if I link to this?
Then the output renderer loops through all of the If no matches are found it can show an error message telling you that the link has expired (presumably because the underlying database has changed since the link was generated). I think this might be the best solution to the problem. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
718976679 | https://github.com/simonw/datasette/issues/1053#issuecomment-718976679 | https://api.github.com/repos/simonw/datasette/issues/1053 | MDEyOklzc3VlQ29tbWVudDcxODk3NjY3OQ== | simonw 9599 | 2020-10-29T19:37:57Z | 2020-10-29T19:37:57Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Document recommendations for plugin authors to design URLs 729604838 | ||
718346019 | https://github.com/simonw/datasette/issues/1050#issuecomment-718346019 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxODM0NjAxOQ== | simonw 9599 | 2020-10-29T04:05:07Z | 2020-10-29T04:05:07Z | OWNER | Yes, confirmed - this is a bug where if the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
718342036 | https://github.com/simonw/datasette/issues/1050#issuecomment-718342036 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxODM0MjAzNg== | simonw 9599 | 2020-10-29T03:49:57Z | 2020-10-29T03:49:57Z | OWNER | @thadk from that error it looks like the problem may have been that you had a BLOB column containing a |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
718340847 | https://github.com/simonw/datasette/pull/1049#issuecomment-718340847 | https://api.github.com/repos/simonw/datasette/issues/1049 | MDEyOklzc3VlQ29tbWVudDcxODM0MDg0Nw== | simonw 9599 | 2020-10-29T03:45:47Z | 2020-10-29T03:48:26Z | OWNER | thebe is the first time I've seen a library that requires you to set up some global JavaScript configuration before loading the script itself. I'm hesitant to add an extra template block just to cover that one case since it's such a rare pattern. But it's important that Would this pattern work for you instead? ```html+jinja {% block extra_head %} <script type="text/x-thebe-config"> { requestKernel: true, binderOptions: { repo: "binder-examples/requirements", }, } </script> <script src="https://unpkg.com/thebelab@latest/lib/index.js"></script>{% endblock %} ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add template block prior to extra URL loaders 729017519 | |
718341542 | https://github.com/simonw/datasette/pull/1049#issuecomment-718341542 | https://api.github.com/repos/simonw/datasette/issues/1049 | MDEyOklzc3VlQ29tbWVudDcxODM0MTU0Mg== | simonw 9599 | 2020-10-29T03:48:12Z | 2020-10-29T03:48:12Z | OWNER | You could use Datasette's new ```html+jinja {% block extra_head %} <script type="text/x-thebe-config"> { requestKernel: true, binderOptions: { repo: "binder-examples/requirements", }, } </script> <script src="{{ urls.static_plugins("datasette-thebelab-plugin", "thebelab-index.js")"></script>{% endblock %} ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add template block prior to extra URL loaders 729017519 | |
718170295 | https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718170295 | https://api.github.com/repos/simonw/sqlite-utils/issues/191 | MDEyOklzc3VlQ29tbWVudDcxODE3MDI5NQ== | simonw 9599 | 2020-10-28T19:50:16Z | 2020-10-28T19:50:16Z | OWNER | I think I made a mistake when I designed the initial decorator. I should have had it work like this:
To avoid breaking backwards compatibility I'll use the hack that detects the argument this time, but in the future I'll try to remember to always design decorators to be called like |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: @db.register_function(deterministic=True) 731740458 | |
718168730 | https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718168730 | https://api.github.com/repos/simonw/sqlite-utils/issues/191 | MDEyOklzc3VlQ29tbWVudDcxODE2ODczMA== | simonw 9599 | 2020-10-28T19:47:20Z | 2020-10-28T19:47:20Z | OWNER | https://stackoverflow.com/a/3931903 looks useful:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: @db.register_function(deterministic=True) 731740458 | |
718078447 | https://github.com/simonw/datasette/pull/1059#issuecomment-718078447 | https://api.github.com/repos/simonw/datasette/issues/1059 | MDEyOklzc3VlQ29tbWVudDcxODA3ODQ0Nw== | simonw 9599 | 2020-10-28T17:07:59Z | 2020-10-28T17:08:14Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update aiofiles requirement from <0.6,>=0.4 to >=0.4,<0.7 731445447 | ||
717531272 | https://github.com/simonw/datasette/issues/1057#issuecomment-717531272 | https://api.github.com/repos/simonw/datasette/issues/1057 | MDEyOklzc3VlQ29tbWVudDcxNzUzMTI3Mg== | simonw 9599 | 2020-10-27T20:51:09Z | 2020-10-27T20:51:09Z | OWNER | That works! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--cors should enable /fixtures.db CORS access 730797787 | |
717527606 | https://github.com/simonw/datasette/issues/1058#issuecomment-717527606 | https://api.github.com/repos/simonw/datasette/issues/1058 | MDEyOklzc3VlQ29tbWVudDcxNzUyNzYwNg== | simonw 9599 | 2020-10-27T20:44:06Z | 2020-10-27T20:44:06Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Database download should implement cascading permissions 730802994 | ||
717361487 | https://github.com/simonw/sqlite-utils/pull/189#issuecomment-717361487 | https://api.github.com/repos/simonw/sqlite-utils/issues/189 | MDEyOklzc3VlQ29tbWVudDcxNzM2MTQ4Nw== | simonw 9599 | 2020-10-27T16:24:04Z | 2020-10-27T16:24:04Z | OWNER | This is great, thank you very much. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow iterables other than Lists in m2m records 729818242 | |
717051707 | https://github.com/simonw/datasette/issues/1054#issuecomment-717051707 | https://api.github.com/repos/simonw/datasette/issues/1054 | MDEyOklzc3VlQ29tbWVudDcxNzA1MTcwNw== | simonw 9599 | 2020-10-27T07:41:21Z | 2020-10-27T07:41:21Z | OWNER | Essentially it's this problem: https://github.com/python-versioneer/python-versioneer/issues/140 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch from versioneer to concrete version in setup.py 730199464 | |
717050585 | https://github.com/simonw/datasette/issues/1054#issuecomment-717050585 | https://api.github.com/repos/simonw/datasette/issues/1054 | MDEyOklzc3VlQ29tbWVudDcxNzA1MDU4NQ== | simonw 9599 | 2020-10-27T07:38:50Z | 2020-10-27T07:38:50Z | OWNER | Maybe imitate how Django does this, e.g. https://github.com/django/django/commit/6b9b2af7352908d40ca4d31bdb1b80c013cab29a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch from versioneer to concrete version in setup.py 730199464 | |
716756103 | https://github.com/simonw/sqlite-utils/pull/189#issuecomment-716756103 | https://api.github.com/repos/simonw/sqlite-utils/issues/189 | MDEyOklzc3VlQ29tbWVudDcxNjc1NjEwMw== | simonw 9599 | 2020-10-26T18:56:19Z | 2020-10-26T18:56:19Z | OWNER | This is a great fix, thanks! If you add a unit test somewhere in here I'll merge the PR: https://github.com/simonw/sqlite-utils/blob/main/tests/test_m2m.py |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow iterables other than Lists in m2m records 729818242 | |
716681602 | https://github.com/simonw/datasette/issues/1051#issuecomment-716681602 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjY4MTYwMg== | simonw 9599 | 2020-10-26T16:51:58Z | 2020-10-26T16:51:58Z | OWNER | I still need to improve the current binary display on the query page though, where it outputs a Python |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716681167 | https://github.com/simonw/datasette/issues/1051#issuecomment-716681167 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjY4MTE2Nw== | simonw 9599 | 2020-10-26T16:51:15Z | 2020-10-26T16:51:15Z | OWNER | Crazy idea: generate a signed URL containing a base64 of the gzip of the binary content (to try and reduce size). No: this will blow through URL limits in various hosting providers and possibly even browsers. It could be made to work a little bit more reliably with some extra JavaScript that turns it into a download on the browser-side, but that would be hideously complicated. Also the signed bit doesn't prevent people from generating SQL queries that generate nasty binary blobs for download. I'm beginning to think that restricting this feature to just table view, not query view, is a better idea. Query view can still get at the binary using JSON and base64. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716305890 | https://github.com/simonw/datasette/issues/976#issuecomment-716305890 | https://api.github.com/repos/simonw/datasette/issues/976 | MDEyOklzc3VlQ29tbWVudDcxNjMwNTg5MA== | simonw 9599 | 2020-10-26T05:07:10Z | 2020-10-26T05:07:10Z | OWNER | I used the new https://github.com/simonw/datasette/blob/f5dbe61a4568c0915ec6be820095c2960cf0857c/datasette/utils/init.py#L996-L1008 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: -o could open to a more convenient location 708289783 | |
716265360 | https://github.com/simonw/datasette/issues/1052#issuecomment-716265360 | https://api.github.com/repos/simonw/datasette/issues/1052 | MDEyOklzc3VlQ29tbWVudDcxNjI2NTM2MA== | simonw 9599 | 2020-10-26T02:17:58Z | 2020-10-26T02:17:58Z | OWNER | The default z-index values for Leaflet are defined here: https://github.com/Leaflet/Leaflet/blob/b346bb8bf7bb80899baa1f4fc1536bae58e7e3e6/dist/leaflet.css#L81-L91 ```css .leaflet-pane { z-index: 400; } .leaflet-tile-pane { z-index: 200; } .leaflet-overlay-pane { z-index: 400; } .leaflet-shadow-pane { z-index: 500; } .leaflet-marker-pane { z-index: 600; } .leaflet-tooltip-pane { z-index: 650; } .leaflet-popup-pane { z-index: 700; } .leaflet-map-pane canvas { z-index: 100; }
.leaflet-map-pane svg { z-index: 200; }
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Column action menu overlapped by Leaflet maps 729183332 | |
716204271 | https://github.com/simonw/datasette/issues/1051#issuecomment-716204271 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjIwNDI3MQ== | simonw 9599 | 2020-10-25T20:08:04Z | 2020-10-25T20:08:04Z | OWNER | This is bad though, because if I want to provide binary data in CSV as requested in #1034 I need some way of providing that data. Which suggests to me that the base64 option is the only one that can make sense for arbitrary SQL queries represented as CSV. Download links won't work. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716204090 | https://github.com/simonw/datasette/issues/1051#issuecomment-716204090 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjIwNDA5MA== | simonw 9599 | 2020-10-25T20:06:42Z | 2020-10-25T20:06:42Z | OWNER | Providing a binary download link here is actually extremely difficult. The problem is that the SQL query itself represents data that can change from one moment to the next. It's no good showing a "Binary: 55 bytes" message that links to that same SQL query but with a So providing a download link risks being misleading. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716174203 | https://github.com/simonw/datasette/issues/1050#issuecomment-716174203 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxNjE3NDIwMw== | simonw 9599 | 2020-10-25T16:27:39Z | 2020-10-25T16:53:27Z | OWNER | Idea: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
716175236 | https://github.com/simonw/datasette/issues/1050#issuecomment-716175236 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxNjE3NTIzNg== | simonw 9599 | 2020-10-25T16:35:20Z | 2020-10-25T16:35:20Z | OWNER | This is clearly a better solution than the one I implemented in #1040 - I don't have to add a new route, I don't have to implement permission checks, it reuses mechanism. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
716078777 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078777 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODc3Nw== | simonw 9599 | 2020-10-25T01:25:11Z | 2020-10-25T01:25:11Z | OWNER | SQLite actually has APIs that could help here: https://www.sqlite.org/c3ref/column_database_name.html - for any given SQL query they identify the origin/table/column that is the source of each resulting column. Those aren't exposed in the Python |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716078605 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078605 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODYwNQ== | simonw 9599 | 2020-10-25T01:22:22Z | 2020-10-25T01:22:22Z | OWNER | For arbitrary CSV the only solution I can think of is to embed the base64 value. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716078512 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078512 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODUxMg== | simonw 9599 | 2020-10-25T01:21:11Z | 2020-10-25T01:21:11Z | OWNER | What should happen for CSV export of arbitrary SQL queries, where there's no obvious BLOB to link to? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716078420 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078420 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODQyMA== | simonw 9599 | 2020-10-25T01:20:00Z | 2020-10-25T01:20:00Z | OWNER | That documentation: https://docs.datasette.io/en/latest/internals.html#absolute-url-request-path |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716077541 | https://github.com/simonw/datasette/issues/1034#issuecomment-716077541 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3NzU0MQ== | simonw 9599 | 2020-10-25T01:09:38Z | 2020-10-25T01:10:04Z | OWNER | I should turn |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716077508 | https://github.com/simonw/datasette/issues/1034#issuecomment-716077508 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3NzUwOA== | simonw 9599 | 2020-10-25T01:09:17Z | 2020-10-25T01:09:17Z | OWNER | Here's how those absolute |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716077436 | https://github.com/simonw/datasette/issues/1034#issuecomment-716077436 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3NzQzNg== | simonw 9599 | 2020-10-25T01:08:35Z | 2020-10-25T01:08:42Z | OWNER | This is actually a bit tricky to implement, for a few reasons:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
713277810 | https://github.com/simonw/datasette/issues/1034#issuecomment-713277810 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxMzI3NzgxMA== | simonw 9599 | 2020-10-21T03:40:50Z | 2020-10-25T01:01:23Z | OWNER | Blocked awaiting #1036 (update: now unblocked) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716071507 | https://github.com/simonw/datasette/issues/1046#issuecomment-716071507 | https://api.github.com/repos/simonw/datasette/issues/1046 | MDEyOklzc3VlQ29tbWVudDcxNjA3MTUwNw== | simonw 9599 | 2020-10-25T00:06:47Z | 2020-10-25T00:06:47Z | OWNER | I used https://primer.style/octicons/download-16 instead. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Link to blob downloads in the right places 728895193 | |
716066342 | https://github.com/simonw/datasette/issues/1046#issuecomment-716066342 | https://api.github.com/repos/simonw/datasette/issues/1046 | MDEyOklzc3VlQ29tbWVudDcxNjA2NjM0Mg== | simonw 9599 | 2020-10-24T23:02:07Z | 2020-10-24T23:02:25Z | OWNER | A download icon would be nice for the links in the table display. I like this one https://primer.style/octicons/download-24
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Link to blob downloads in the right places 728895193 | |
716048564 | https://github.com/simonw/datasette/issues/1033#issuecomment-716048564 | https://api.github.com/repos/simonw/datasette/issues/1033 | MDEyOklzc3VlQ29tbWVudDcxNjA0ODU2NA== | simonw 9599 | 2020-10-24T20:08:31Z | 2020-10-24T20:08:31Z | OWNER | Documentation here: https://docs.datasette.io/en/latest/internals.html#datasette-urls |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.urls.static_plugins(...) method 725099777 | |
716048199 | https://github.com/simonw/datasette/issues/575#issuecomment-716048199 | https://api.github.com/repos/simonw/datasette/issues/575 | MDEyOklzc3VlQ29tbWVudDcxNjA0ODE5OQ== | simonw 9599 | 2020-10-24T20:05:44Z | 2020-10-24T20:05:44Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin documentation should cover how to bundle static/templates in setup.py 497162288 | ||
715643763 | https://github.com/simonw/datasette/issues/1042#issuecomment-715643763 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTY0Mzc2Mw== | simonw 9599 | 2020-10-24T00:34:31Z | 2020-10-24T00:34:52Z | OWNER | I'm going to rename that to template variable from |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715643646 | https://github.com/simonw/datasette/issues/1042#issuecomment-715643646 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTY0MzY0Ng== | simonw 9599 | 2020-10-24T00:33:46Z | 2020-10-24T00:33:46Z | OWNER | I'd like to do this all in the This code is the problem: https://github.com/simonw/datasette/blob/d3e9b0aecb6f8e9b2befd9c654ccb7ce852db3e7/datasette/views/base.py#L114-L133 I think I'll fix this by moving the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715641183 | https://github.com/simonw/datasette/issues/1045#issuecomment-715641183 | https://api.github.com/repos/simonw/datasette/issues/1045 | MDEyOklzc3VlQ29tbWVudDcxNTY0MTE4Mw== | simonw 9599 | 2020-10-24T00:19:29Z | 2020-10-24T00:19:29Z | OWNER | It turns out it already does that: But the documentation doesn't reflect that:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Document that datasette.render_template(template, ...) also accepts a list of templates 728600048 | |
715618333 | https://github.com/simonw/datasette/issues/1042#issuecomment-715618333 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxODMzMw== | simonw 9599 | 2020-10-23T22:33:24Z | 2020-10-23T22:33:24Z | OWNER | It wouldn't be a disaster if template-loading plugins were unable to hook into the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715618077 | https://github.com/simonw/datasette/issues/1042#issuecomment-715618077 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxODA3Nw== | simonw 9599 | 2020-10-23T22:32:24Z | 2020-10-23T22:32:24Z | OWNER | Another option: the first version of the plugin hook could accept only the template filename. Subsequent releases could add more arguments, since Pluggy allows new arguments to be added without breaking backwards compatibility. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715617830 | https://github.com/simonw/datasette/issues/1042#issuecomment-715617830 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNzgzMA== | simonw 9599 | 2020-10-23T22:31:26Z | 2020-10-23T22:31:26Z | OWNER | So maybe this should be a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715617405 | https://github.com/simonw/datasette/issues/1042#issuecomment-715617405 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNzQwNQ== | simonw 9599 | 2020-10-23T22:29:53Z | 2020-10-23T22:29:53Z | OWNER | Also consider that For that to work with the new plugin hook, custom template providing plugins will need a way to provide a list of templates that they know about. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715616757 | https://github.com/simonw/datasette/issues/1042#issuecomment-715616757 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNjc1Nw== | simonw 9599 | 2020-10-23T22:27:28Z | 2020-10-23T22:27:28Z | OWNER | Almost all of the core template loading happens in the The one exception is the 404 handling code here: https://github.com/simonw/datasette/blob/976e5f74aae1fa0d406df6691dc8b5feeebe8788/datasette/app.py#L1034-L1042 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715614971 | https://github.com/simonw/datasette/issues/1042#issuecomment-715614971 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNDk3MQ== | simonw 9599 | 2020-10-23T22:20:14Z | 2020-10-23T22:23:51Z | OWNER | Alternative plugin hook idea:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715587715 | https://github.com/simonw/datasette/pull/1040#issuecomment-715587715 | https://api.github.com/repos/simonw/datasette/issues/1040 | MDEyOklzc3VlQ29tbWVudDcxNTU4NzcxNQ== | simonw 9599 | 2020-10-23T21:01:07Z | 2020-10-23T21:03:10Z | OWNER | A download icon would be nice for the links in the table display. I like this one https://primer.style/octicons/download-24 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
/db/table/-/blob/pk/column.blob download URL 726910999 | |
715586711 | https://github.com/simonw/datasette/pull/1043#issuecomment-715586711 | https://api.github.com/repos/simonw/datasette/issues/1043 | MDEyOklzc3VlQ29tbWVudDcxNTU4NjcxMQ== | simonw 9599 | 2020-10-23T20:58:26Z | 2020-10-23T20:58:26Z | OWNER | I misunderstood - |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Include LICENSE in sdist 727915394 | |
715585140 | https://github.com/simonw/datasette/pull/1043#issuecomment-715585140 | https://api.github.com/repos/simonw/datasette/issues/1043 | MDEyOklzc3VlQ29tbWVudDcxNTU4NTE0MA== | simonw 9599 | 2020-10-23T20:54:29Z | 2020-10-23T20:54:29Z | OWNER | Thanks. I'll push a source release of |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Include LICENSE in sdist 727915394 | |
715584579 | https://github.com/simonw/datasette/pull/1044#issuecomment-715584579 | https://api.github.com/repos/simonw/datasette/issues/1044 | MDEyOklzc3VlQ29tbWVudDcxNTU4NDU3OQ== | simonw 9599 | 2020-10-23T20:53:01Z | 2020-10-23T20:53:01Z | OWNER | Thanks for this! |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add minimum supported python 727916744 | |
715556545 | https://github.com/simonw/datasette/issues/745#issuecomment-715556545 | https://api.github.com/repos/simonw/datasette/issues/745 | MDEyOklzc3VlQ29tbWVudDcxNTU1NjU0NQ== | simonw 9599 | 2020-10-23T19:47:10Z | 2020-10-23T19:47:10Z | OWNER | Dupe of #647 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Extract the hash-URL mechanism out into a plugin 608613033 | |
715497419 | https://github.com/simonw/datasette/issues/1042#issuecomment-715497419 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTQ5NzQxOQ== | simonw 9599 | 2020-10-23T18:12:40Z | 2020-10-23T18:12:40Z | OWNER | Maybe the template loader can optionally return some extra context to pass to the template. That could be used to solve the templates considered comment. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715496859 | https://github.com/simonw/datasette/issues/1042#issuecomment-715496859 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTQ5Njg1OQ== | simonw 9599 | 2020-10-23T18:11:27Z | 2020-10-23T18:11:27Z | OWNER | When loading a template the filename is required, but you can optionally also send a set of extra arguments which the template loader can take into consideration. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715490532 | https://github.com/simonw/datasette/issues/1042#issuecomment-715490532 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTQ5MDUzMg== | simonw 9599 | 2020-10-23T17:57:34Z | 2020-10-23T17:57:34Z | OWNER | A better version of this hook would be passed the database, table and query name depending on what was being rendered. This would require some re-thinking of how core templates are loaded, especially since I would want the templates considered comment to continue working. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
714868867 | https://github.com/simonw/datasette/issues/1042#issuecomment-714868867 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNDg2ODg2Nw== | simonw 9599 | 2020-10-23T02:31:17Z | 2020-10-23T02:31:17Z | OWNER | I'll build this in conjunction with a plugin that supports editing templates stored in SQLite. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
714868624 | https://github.com/simonw/datasette/issues/1042#issuecomment-714868624 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNDg2ODYyNA== | simonw 9599 | 2020-10-23T02:30:27Z | 2020-10-23T02:30:37Z | OWNER | Maybe |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
714868207 | https://github.com/simonw/datasette/issues/1042#issuecomment-714868207 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNDg2ODIwNw== | simonw 9599 | 2020-10-23T02:29:12Z | 2020-10-23T02:29:12Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | ||
714758139 | https://github.com/simonw/sqlite-utils/issues/173#issuecomment-714758139 | https://api.github.com/repos/simonw/sqlite-utils/issues/173 | MDEyOklzc3VlQ29tbWVudDcxNDc1ODEzOQ== | simonw 9599 | 2020-10-22T20:57:56Z | 2020-10-22T20:57:56Z | OWNER | I could use Here's how to iterate through a list of objects being read from a file:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Progress bar for sqlite-utils insert 707478649 | |
714683801 | https://github.com/simonw/datasette/issues/1041#issuecomment-714683801 | https://api.github.com/repos/simonw/datasette/issues/1041 | MDEyOklzc3VlQ29tbWVudDcxNDY4MzgwMQ== | simonw 9599 | 2020-10-22T18:37:47Z | 2020-10-22T18:37:47Z | OWNER | I think I'll do this by looking for URLs that start with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_js_urls and extra_css_urls should respect base_url setting 727627923 | |
714682825 | https://github.com/simonw/datasette/issues/1041#issuecomment-714682825 | https://api.github.com/repos/simonw/datasette/issues/1041 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjgyNQ== | simonw 9599 | 2020-10-22T18:36:10Z | 2020-10-22T18:36:10Z | OWNER | I'll need to update these docs once there's a solution for this in place: https://docs.datasette.io/en/latest/custom_templates.html#serving-static-files |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_js_urls and extra_css_urls should respect base_url setting 727627923 | |
714682288 | https://github.com/simonw/datasette/issues/1041#issuecomment-714682288 | https://api.github.com/repos/simonw/datasette/issues/1041 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjI4OA== | simonw 9599 | 2020-10-22T18:35:15Z | 2020-10-22T18:35:15Z | OWNER | @psychemedia said: https://github.com/simonw/datasette/issues/1033#issuecomment-714657366
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_js_urls and extra_css_urls should respect base_url setting 727627923 | |
714681365 | https://github.com/simonw/datasette/issues/1033#issuecomment-714681365 | https://api.github.com/repos/simonw/datasette/issues/1033 | MDEyOklzc3VlQ29tbWVudDcxNDY4MTM2NQ== | simonw 9599 | 2020-10-22T18:33:48Z | 2020-10-22T18:33:48Z | OWNER | That's a good question - I hadn't considered that. I'm going to open a new issue to have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.urls.static_plugins(...) method 725099777 | |
714208848 | https://github.com/simonw/sqlite-utils/issues/171#issuecomment-714208848 | https://api.github.com/repos/simonw/sqlite-utils/issues/171 | MDEyOklzc3VlQ29tbWVudDcxNDIwODg0OA== | simonw 9599 | 2020-10-22T04:07:14Z | 2020-10-22T04:07:14Z | OWNER | I made the It's a bit too obscure for me to want to add direct Python library support relating to that extension though. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: transitive closure tables for tree structures 707407567 | |
714206875 | https://github.com/simonw/datasette/pull/1031#issuecomment-714206875 | https://api.github.com/repos/simonw/datasette/issues/1031 | MDEyOklzc3VlQ29tbWVudDcxNDIwNjg3NQ== | simonw 9599 | 2020-10-22T04:01:19Z | 2020-10-22T04:01:19Z | OWNER | I don't fully understand the bug you're fixing here. Could you provide a bit more explanation? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fallback to databases in inspect-data.json when no -i options are passed 724369025 | |
714206533 | https://github.com/simonw/datasette/pull/1040#issuecomment-714206533 | https://api.github.com/repos/simonw/datasette/issues/1040 | MDEyOklzc3VlQ29tbWVudDcxNDIwNjUzMw== | simonw 9599 | 2020-10-22T04:00:25Z | 2020-10-22T04:00:25Z | OWNER | I've decided not to offer a configuration option to turn this off. I'll reconsider if someone asks for it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
/db/table/-/blob/pk/column.blob download URL 726910999 | |
714205783 | https://github.com/simonw/datasette/issues/998#issuecomment-714205783 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDIwNTc4Mw== | simonw 9599 | 2020-10-22T03:58:13Z | 2020-10-22T03:58:13Z | OWNER | This is now live here: https://global-power-plants.datasettes.com/global-power-plants/global-power-plants |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
714117534 | https://github.com/simonw/datasette/issues/998#issuecomment-714117534 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDExNzUzNA== | simonw 9599 | 2020-10-22T01:12:06Z | 2020-10-22T01:12:06Z | OWNER | Demo: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
714092002 | https://github.com/simonw/datasette/issues/998#issuecomment-714092002 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDA5MjAwMg== | simonw 9599 | 2020-10-22T00:55:10Z | 2020-10-22T00:55:10Z | OWNER | This isn't blocked on #987 - it just means that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
714090965 | https://github.com/simonw/datasette/issues/998#issuecomment-714090965 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDA5MDk2NQ== | simonw 9599 | 2020-10-22T00:54:30Z | 2020-10-22T00:54:30Z | OWNER | Easiest fix for the column action menu positioning - hide them when the user scrolls the containing div:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
713920461 | https://github.com/simonw/datasette/pull/1038#issuecomment-713920461 | https://api.github.com/repos/simonw/datasette/issues/1038 | MDEyOklzc3VlQ29tbWVudDcxMzkyMDQ2MQ== | simonw 9599 | 2020-10-21T22:43:51Z | 2020-10-21T22:43:51Z | OWNER | Thanks for spotting this! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
DOC: Fix syntax error 726154220 | |
713899530 | https://github.com/simonw/datasette/issues/1036#issuecomment-713899530 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzg5OTUzMA== | simonw 9599 | 2020-10-21T21:55:00Z | 2020-10-21T21:55:00Z | OWNER | This code needs these permission checks: https://github.com/simonw/datasette/blob/bf82b3d6a605c9ddadd5fb739249dfe6defaf635/datasette/views/table.py#L911-L913 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713821656 | https://github.com/simonw/datasette/issues/1036#issuecomment-713821656 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgyMTY1Ng== | simonw 9599 | 2020-10-21T19:22:45Z | 2020-10-21T19:41:48Z | OWNER | So for https://latest.datasette.io/fixtures/binary_data the BLOB download URLs would be:
With these headers:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713830842 | https://github.com/simonw/datasette/issues/1036#issuecomment-713830842 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgzMDg0Mg== | simonw 9599 | 2020-10-21T19:41:20Z | 2020-10-21T19:41:20Z | OWNER | Another useful demo database: https://datasette-render-images-demo.datasette.io/favicons/favicons - see https://datasette-render-images-demo.datasette.io/favicons/favicons.csv |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713829629 | https://github.com/simonw/datasette/issues/1036#issuecomment-713829629 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgyOTYyOQ== | simonw 9599 | 2020-10-21T19:38:43Z | 2020-10-21T19:38:43Z | OWNER | Should this work just for BLOB columns, or should it work for other columns too? For the moment I'm going to restrict it to BLOBs, since data from other columns is available through the UI whereas BLOB columns are not. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713818817 | https://github.com/simonw/datasette/issues/1036#issuecomment-713818817 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgxODgxNw== | simonw 9599 | 2020-10-21T19:17:01Z | 2020-10-21T19:17:01Z | OWNER | Actually I like |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713818178 | https://github.com/simonw/datasette/issues/1036#issuecomment-713818178 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgxODE3OA== | simonw 9599 | 2020-10-21T19:15:38Z | 2020-10-21T19:16:34Z | OWNER | What should the suggested filename be? I think something that includes the table name, primary key and the name of the column would work. How about a file extension? I guess |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713754844 | https://github.com/simonw/datasette/issues/1039#issuecomment-713754844 | https://api.github.com/repos/simonw/datasette/issues/1039 | MDEyOklzc3VlQ29tbWVudDcxMzc1NDg0NA== | simonw 9599 | 2020-10-21T17:58:27Z | 2020-10-21T17:58:27Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add an animation to the column actions menu 726687572 | ||
713278349 | https://github.com/simonw/datasette/issues/1036#issuecomment-713278349 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzI3ODM0OQ== | simonw 9599 | 2020-10-21T03:42:29Z | 2020-10-21T03:42:29Z | OWNER | Possible URL for this: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713269155 | https://github.com/simonw/datasette/issues/998#issuecomment-713269155 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxMzI2OTE1NQ== | simonw 9599 | 2020-10-21T03:17:07Z | 2020-10-21T03:17:07Z | OWNER | This may require updates to the column action menu JavaScript too, since it was not built with scrolling sideways in mind. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
713268905 | https://github.com/simonw/datasette/issues/1037#issuecomment-713268905 | https://api.github.com/repos/simonw/datasette/issues/1037 | MDEyOklzc3VlQ29tbWVudDcxMzI2ODkwNQ== | simonw 9599 | 2020-10-21T03:16:36Z | 2020-10-21T03:16:36Z | OWNER | Dupe of #998. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add horizontal scrollbar to tables 726094754 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue >30