issue_comments
10,495 rows sorted by updated_at descending
This data as json, CSV (advanced)
issue >30
- Show column metadata plus links for foreign keys on arbitrary query results 51
- Redesign default .json format 48
- Rethink how .ext formats (v.s. ?_format=) works before 1.0 48
- Upgrade to CodeMirror 6, add SQL autocomplete 48
- JavaScript plugin hooks mechanism similar to pluggy 47
- Updated Dockerfile with SpatiaLite version 5.0 45
- Complete refactor of TableView and table.html template 45
- Port Datasette to ASGI 42
- Authentication (and permissions) as a core concept 40
- Deploy a live instance of demos/apache-proxy 34
- await datasette.client.get(path) mechanism for executing internal requests 33
- Maintain an in-memory SQLite table of connected databases and their tables 32
- Research: demonstrate if parallel SQL queries are worthwhile 32
- Ability to sort (and paginate) by column 31
- Default API token authentication mechanism 30
- link_or_copy_directory() error - Invalid cross-device link 28
- Export to CSV 27
- base_url configuration setting 27
- Documentation with recommendations on running Datasette in production without using Docker 27
- Optimize all those calls to index_list and foreign_key_list 27
- Support cross-database joins 26
- Ability for a canned query to write to the database 26
- table.transform() method for advanced alter table 26
- New pattern for views that return either JSON or HTML, available for plugins 26
- Proof of concept for Datasette on AWS Lambda with EFS 25
- WIP: Add Gmail takeout mbox import 25
- Redesign register_output_renderer callback 24
- Make it easier to insert geometries, with documentation and maybe code 24
- API explorer tool 24
- Stream all results for arbitrary SQL and canned queries 23
- …
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1331208206 | https://github.com/simonw/datasette/issues/1913#issuecomment-1331208206 | https://api.github.com/repos/simonw/datasette/issues/1913 | IC_kwDOBm6k_c5PWKAO | simonw 9599 | 2022-11-29T19:51:31Z | 2022-11-29T19:51:31Z | OWNER | https://pypi.org/project/pkginfo/#history - 1.9.0 came out 39 minutes ago! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Release Datasette 1.0a0 1468603401 | |
1331207334 | https://github.com/simonw/datasette/issues/1913#issuecomment-1331207334 | https://api.github.com/repos/simonw/datasette/issues/1913 | IC_kwDOBm6k_c5PWJym | simonw 9599 | 2022-11-29T19:50:37Z | 2022-11-29T19:50:37Z | OWNER | https://pypi.org/project/setuptools/65.6.3/ came out most recently - 23rd November (wheel and twine are older). No search results at all for that error message. This is very weird, I would have expected it to have been reported by now. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Release Datasette 1.0a0 1468603401 | |
1331205613 | https://github.com/simonw/datasette/issues/1913#issuecomment-1331205613 | https://api.github.com/repos/simonw/datasette/issues/1913 | IC_kwDOBm6k_c5PWJXt | simonw 9599 | 2022-11-29T19:48:52Z | 2022-11-29T19:48:52Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Release Datasette 1.0a0 1468603401 | ||
1331204360 | https://github.com/simonw/datasette/issues/1913#issuecomment-1331204360 | https://api.github.com/repos/simonw/datasette/issues/1913 | IC_kwDOBm6k_c5PWJEI | simonw 9599 | 2022-11-29T19:47:40Z | 2022-11-29T19:47:40Z | OWNER | ... but the last step of the deploy failed, when it was meant to push to PyPI!
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Release Datasette 1.0a0 1468603401 | |
1331203997 | https://github.com/simonw/datasette/issues/1913#issuecomment-1331203997 | https://api.github.com/repos/simonw/datasette/issues/1913 | IC_kwDOBm6k_c5PWI-d | simonw 9599 | 2022-11-29T19:47:13Z | 2022-11-29T19:47:13Z | OWNER | Weird, retrying the tests DID get them to pass. https://github.com/simonw/datasette/actions/runs/3577355358/jobs/6016518244 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Release Datasette 1.0a0 1468603401 | |
1331201207 | https://github.com/simonw/datasette/issues/1877#issuecomment-1331201207 | https://api.github.com/repos/simonw/datasette/issues/1877 | IC_kwDOBm6k_c5PWIS3 | simonw 9599 | 2022-11-29T19:44:07Z | 2022-11-29T19:44:07Z | OWNER | I fixed the duplicate logic issue here: https://github.com/simonw/datasette/commit/ee64130fa8a5ff4a24791916c696e10cf2375102
Decided not to address |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor and tidy up final write API code 1432012302 | |
1331196531 | https://github.com/simonw/datasette/pull/1912#issuecomment-1331196531 | https://api.github.com/repos/simonw/datasette/issues/1912 | IC_kwDOBm6k_c5PWHJz | simonw 9599 | 2022-11-29T19:39:10Z | 2022-11-29T19:39:10Z | OWNER | Annoyingly it looks like I can't rebase this one, and I don't want to squash-merge and lose the commits, so I'm going to do a regular merge instead. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Merge 1.0-dev (with initial write API) back into main 1468592292 | |
1331187551 | https://github.com/simonw/datasette/issues/1605#issuecomment-1331187551 | https://api.github.com/repos/simonw/datasette/issues/1605 | IC_kwDOBm6k_c5PWE9f | eyeseast 25778 | 2022-11-29T19:29:42Z | 2022-11-29T19:29:42Z | CONTRIBUTOR | Interesting. I started a version using metadata like I outlined up top, but I realized that there's no documented way for a plugin to access either metadata or canned queries. Or at least, I couldn't find a way. There is this method: https://github.com/simonw/datasette/blob/main/datasette/app.py#L472 but I don't want to rely on it if it's not documented. Same with this: https://github.com/simonw/datasette/blob/main/datasette/app.py#L544 If those are safe, I'll build on them. I'm also happy to document them, if that greases the wheels. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Scripted exports 1108671952 | |
1331181922 | https://github.com/simonw/datasette/issues/1891#issuecomment-1331181922 | https://api.github.com/repos/simonw/datasette/issues/1891 | IC_kwDOBm6k_c5PWDli | simonw 9599 | 2022-11-29T19:23:41Z | 2022-11-29T19:23:41Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1.0a0 release notes 1450303205 | ||
1331143292 | https://github.com/simonw/datasette/issues/1891#issuecomment-1331143292 | https://api.github.com/repos/simonw/datasette/issues/1891 | IC_kwDOBm6k_c5PV6J8 | simonw 9599 | 2022-11-29T18:57:40Z | 2022-11-29T18:57:40Z | OWNER | I'm going to keep these short - they'll mostly be links to the documentation for the new features. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1.0a0 release notes 1450303205 | |
1331140747 | https://github.com/simonw/datasette/issues/1891#issuecomment-1331140747 | https://api.github.com/repos/simonw/datasette/issues/1891 | IC_kwDOBm6k_c5PV5iL | simonw 9599 | 2022-11-29T18:55:42Z | 2022-11-29T18:55:42Z | OWNER | All features for the alpha are complete now. Release notes should be based on these commits: https://github.com/simonw/datasette/compare/0.63.2...6bda2257868a2cbd70b84b7a86a5bcb47dcc4874 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1.0a0 release notes 1450303205 | |
1331135709 | https://github.com/simonw/datasette/issues/1911#issuecomment-1331135709 | https://api.github.com/repos/simonw/datasette/issues/1911 | IC_kwDOBm6k_c5PV4Td | simonw 9599 | 2022-11-29T18:50:58Z | 2022-11-29T18:50:58Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`/db/-/create` should support creating tables with compound primary keys 1468519699 | ||
1331120055 | https://github.com/simonw/datasette/issues/1911#issuecomment-1331120055 | https://api.github.com/repos/simonw/datasette/issues/1911 | IC_kwDOBm6k_c5PV0e3 | simonw 9599 | 2022-11-29T18:36:01Z | 2022-11-29T18:36:01Z | OWNER | Current API design:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`/db/-/create` should support creating tables with compound primary keys 1468519699 | |
1331089156 | https://github.com/simonw/datasette/issues/1863#issuecomment-1331089156 | https://api.github.com/repos/simonw/datasette/issues/1863 | IC_kwDOBm6k_c5PVs8E | simonw 9599 | 2022-11-29T18:08:53Z | 2022-11-29T18:08:53Z | OWNER | I do think this needs type checking - I just tried and you really can send a string to an integer column and have it work, which feels bad. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update a single record in an existing table 1425029242 | |
1330974099 | https://github.com/simonw/datasette/issues/1863#issuecomment-1330974099 | https://api.github.com/repos/simonw/datasette/issues/1863 | IC_kwDOBm6k_c5PVQ2T | simonw 9599 | 2022-11-29T17:03:00Z | 2022-11-29T17:11:05Z | OWNER | I've decided that I won't do that validation for the first version of this - I'm going to teach |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update a single record in an existing table 1425029242 | |
1329624931 | https://github.com/simonw/datasette/issues/1909#issuecomment-1329624931 | https://api.github.com/repos/simonw/datasette/issues/1909 | IC_kwDOBm6k_c5PQHdj | simonw 9599 | 2022-11-28T19:19:26Z | 2022-11-28T19:19:26Z | OWNER | The list of states here is a good example of somewhere this might be useful: https://congress-legislators.datasettes.com/legislators/legislator_terms?_facet=state&_facet_size=max |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Option to sort facets alphabetically 1466952626 | |
1328169472 | https://github.com/simonw/datasette/issues/1605#issuecomment-1328169472 | https://api.github.com/repos/simonw/datasette/issues/1605 | IC_kwDOBm6k_c5PKkIA | simonw 9599 | 2022-11-27T04:32:14Z | 2022-11-27T04:32:14Z | OWNER | @eyeseast I started work on that plugin: https://github.com/simonw/datasette-export |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Scripted exports 1108671952 | |
1325164933 | https://github.com/simonw/datasette/issues/1706#issuecomment-1325164933 | https://api.github.com/repos/simonw/datasette/issues/1706 | IC_kwDOBm6k_c5O_GmF | ar-jan 1176293 | 2022-11-23T14:34:54Z | 2022-11-23T14:34:54Z | NONE | This would be helpful. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
[feature] immutable mode for a directory, not just individual sqlite file 1198822563 | |
1324539030 | https://github.com/simonw/datasette/issues/1863#issuecomment-1324539030 | https://api.github.com/repos/simonw/datasette/issues/1863 | IC_kwDOBm6k_c5O8tyW | simonw 9599 | 2022-11-23T04:35:14Z | 2022-11-23T04:35:14Z | OWNER | If I do that I should probably update |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update a single record in an existing table 1425029242 | |
1324531750 | https://github.com/simonw/datasette/issues/1863#issuecomment-1324531750 | https://api.github.com/repos/simonw/datasette/issues/1863 | IC_kwDOBm6k_c5O8sAm | simonw 9599 | 2022-11-23T04:20:47Z | 2022-11-23T04:20:47Z | OWNER | ... which does imply that I'm going to do an extra layer of validation over what SQLite provides. SQLite will happily allow a text string to be added to a supposedly integer column. I'm not going to allow that - I'll return a validation error instead, unless the string can be safely coerced to the correct type. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update a single record in an existing table 1425029242 | |
1324531085 | https://github.com/simonw/datasette/issues/1863#issuecomment-1324531085 | https://api.github.com/repos/simonw/datasette/issues/1863 | IC_kwDOBm6k_c5O8r2N | simonw 9599 | 2022-11-23T04:19:28Z | 2022-11-23T04:19:28Z | OWNER | Had a design conversation with myself in https://github.com/simonw/dclient/issues/6 where I decided that the API should allow string values to be sent to integer columns which would be automatically converted if possible to do so - as an API usability feature. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update a single record in an existing table 1425029242 | |
1321460293 | https://github.com/simonw/datasette/issues/1884#issuecomment-1321460293 | https://api.github.com/repos/simonw/datasette/issues/1884 | IC_kwDOBm6k_c5Ow-JF | asg017 15178711 | 2022-11-21T04:40:55Z | 2022-11-21T04:40:55Z | CONTRIBUTOR | Counting any virtual tables can be pretty tricky. On one hand, counting a CSV virtual table would return the number of rows in the CSV, which is helpful (but can be I/O intensive). Counting a FTS5 virtual table would return the number of entries in the FTS index, which is kindof helpful, but can be misleading in some cases. On the other hand, arbitrarily running The Personally, I wouldnt try to |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Exclude virtual tables from datasette inspect 1439009231 | |
1321262142 | https://github.com/simonw/datasette/issues/1903#issuecomment-1321262142 | https://api.github.com/repos/simonw/datasette/issues/1903 | IC_kwDOBm6k_c5OwNw- | simonw 9599 | 2022-11-20T22:35:01Z | 2022-11-20T22:35:01Z | OWNER | A want to call this |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor all error classes into a datasette.exceptions module 1455928469 | |
1321241426 | https://github.com/simonw/datasette/issues/1886#issuecomment-1321241426 | https://api.github.com/repos/simonw/datasette/issues/1886 | IC_kwDOBm6k_c5OwItS | fgregg 536941 | 2022-11-20T20:58:54Z | 2022-11-20T20:58:54Z | CONTRIBUTOR | i wrote up a blog post of how i'm using it! https://bunkum.us/2022/11/20/mgdo-stack.html |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Call for birthday presents: if you're using Datasette, let us know how you're using it here 1447050738 | |
1321003094 | https://github.com/simonw/datasette/issues/1886#issuecomment-1321003094 | https://api.github.com/repos/simonw/datasette/issues/1886 | IC_kwDOBm6k_c5OvOhW | hydrosquall 9020979 | 2022-11-20T00:52:05Z | 2022-11-20T00:52:05Z | CONTRIBUTOR | Happy birthday to datasette and thank you Simon for your continued effort on this project! I use datasette (python) as a fast layer on top of search for github projects using https://github.com/dogsheep/github-to-sqlite , and use the JSON API it provides to serve sample data to make Vega-Lite graphing workshop examples that don't require authentication/API keys. It's awesome to have a full SQL API support working without needing to develop any custom API middleware for both filtering and grouping. I've also enjoyed using it as a teaching tool for working with public dataset in civic data workshops and as a platform for making visualization plugins . I I'm especially excited about datasette-lite, as it will let people participate in future editions of this workshop without having to install anything to make use of their own tables :) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Call for birthday presents: if you're using Datasette, let us know how you're using it here 1447050738 | |
1320721241 | https://github.com/simonw/datasette/issues/1905#issuecomment-1320721241 | https://api.github.com/repos/simonw/datasette/issues/1905 | IC_kwDOBm6k_c5OuJtZ | simonw 9599 | 2022-11-19T01:12:05Z | 2022-11-19T01:12:05Z | OWNER | Used it to deploy this: https://fivethirtyeight.datasettes.com/-/versions |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`publish heroku` failing due to old Python version 1456012874 | |
1320689643 | https://github.com/simonw/datasette/issues/1905#issuecomment-1320689643 | https://api.github.com/repos/simonw/datasette/issues/1905 | IC_kwDOBm6k_c5OuB_r | simonw 9599 | 2022-11-19T00:17:19Z | 2022-11-19T00:41:54Z | OWNER | The tests don't cover this bit at the moment. Would be easier to write tests if there was a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`publish heroku` failing due to old Python version 1456012874 | |
1320706596 | https://github.com/simonw/datasette/issues/1905#issuecomment-1320706596 | https://api.github.com/repos/simonw/datasette/issues/1905 | IC_kwDOBm6k_c5OuGIk | simonw 9599 | 2022-11-19T00:41:44Z | 2022-11-19T00:41:44Z | OWNER | Tested a deploy: ``` % datasette publish heroku fixtures.db -n datasette-issue-1905 › Warning: heroku update available from 7.63.0 to 7.66.4. › Warning: heroku update available from 7.63.0 to 7.66.4. › Warning: heroku update available from 7.63.0 to 7.66.4. Creating datasette-issue-1905... done › Warning: heroku update available from 7.63.0 to 7.66.4. ▸ Couldn't detect GNU tar. Builds could fail due to decompression errors ▸ See https://devcenter.heroku.com/articles/platform-api-deploying-slugs#create-slug-archive ▸ Please install it, or specify the '--tar' option ▸ Falling back to node's built-in compressor -----> Building on the Heroku-22 stack -----> Determining which buildpack to use for this app -----> Python app detected -----> Using Python version specified in runtime.txt -----> Installing python-3.11.0 -----> Installing pip 22.3.1, setuptools 63.4.3 and wheel 0.37.1 -----> Installing SQLite3 -----> Installing requirements with pip Collecting datasette Downloading datasette-0.63.1-py3-none-any.whl (231 kB) ... -----> Running post-compile hook -----> Discovering process types Procfile declares types -> web -----> Compressing... Done: 28M -----> Launching... Released v3 https://datasette-issue-1905.herokuapp.com/ deployed to Heroku Starting November 28th, 2022, free Heroku Dynos, free Heroku Postgres, and free Heroku Data for Redis® will no longer be available. If you have apps using any of these resources, you must upgrade to paid plans by this date to ensure your apps continue to run and to retain your data. For students, we will announce a new program by the end of September. Learn more at https://blog.heroku.com/next-chapter ``` I had to then pay for the dino because I'd run out of free hours. https://datasette-issue-1905.herokuapp.com/-/versions shows:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`publish heroku` failing due to old Python version 1456012874 | |
1320678715 | https://github.com/simonw/datasette/issues/1905#issuecomment-1320678715 | https://api.github.com/repos/simonw/datasette/issues/1905 | IC_kwDOBm6k_c5Ot_U7 | simonw 9599 | 2022-11-19T00:02:28Z | 2022-11-19T00:02:28Z | OWNER | This is a strong argument for extracting the Heroku support out to a plugin - it would allow this to be fixed with a plugin release without needing to push a full release of Datasette itself. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
`publish heroku` failing due to old Python version 1456012874 | |
1320625260 | https://github.com/simonw/datasette/issues/1891#issuecomment-1320625260 | https://api.github.com/repos/simonw/datasette/issues/1891 | IC_kwDOBm6k_c5OtyRs | simonw 9599 | 2022-11-18T23:01:03Z | 2022-11-18T23:01:48Z | OWNER | I think this actually needs to include a whole section of the documentation about the road to 1.0 - what to expect (planned breaking changes) etc. I can add that to the https://docs.datasette.io/en/stable/contributing.html page perhaps - or even create a Roadmap page. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1.0a0 release notes 1450303205 | |
1320616559 | https://github.com/simonw/datasette/issues/1896#issuecomment-1320616559 | https://api.github.com/repos/simonw/datasette/issues/1896 | IC_kwDOBm6k_c5OtwJv | simonw 9599 | 2022-11-18T22:51:14Z | 2022-11-18T22:51:14Z | OWNER | New methods are documented here: https://docs.datasette.io/en/1.0-dev/internals.html#resolve-database-request |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Extract logic for resolving a URL to a database / table / row 1452364777 | |
1320614541 | https://github.com/simonw/datasette/issues/1903#issuecomment-1320614541 | https://api.github.com/repos/simonw/datasette/issues/1903 | IC_kwDOBm6k_c5OtvqN | simonw 9599 | 2022-11-18T22:47:41Z | 2022-11-18T22:47:41Z | OWNER | When I do this it's important to update the documentation for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor all error classes into a datasette.exceptions module 1455928469 | |
1320588299 | https://github.com/simonw/datasette/issues/1896#issuecomment-1320588299 | https://api.github.com/repos/simonw/datasette/issues/1896 | IC_kwDOBm6k_c5OtpQL | simonw 9599 | 2022-11-18T22:16:59Z | 2022-11-18T22:17:06Z | OWNER | Found myself needing an |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Extract logic for resolving a URL to a database / table / row 1452364777 | |
1317757949 | https://github.com/simonw/datasette/issues/1896#issuecomment-1317757949 | https://api.github.com/repos/simonw/datasette/issues/1896 | IC_kwDOBm6k_c5Oi2P9 | simonw 9599 | 2022-11-16T22:27:47Z | 2022-11-18T21:48:29Z | OWNER | Open question: should I think not, at least for the moment. Feels a bit too specialist to expose in a documented API. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Extract logic for resolving a URL to a database / table / row 1452364777 | |
1320563197 | https://github.com/simonw/datasette/issues/1863#issuecomment-1320563197 | https://api.github.com/repos/simonw/datasette/issues/1863 | IC_kwDOBm6k_c5OtjH9 | simonw 9599 | 2022-11-18T21:47:35Z | 2022-11-18T21:48:07Z | OWNER | Incomplete implementation of this view: ```python class RowUpdateView(BaseView): name = "row-update"
``` This is before the refactor in: - #1896 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update a single record in an existing table 1425029242 | |
1320394127 | https://github.com/simonw/sqlite-utils/issues/510#issuecomment-1320394127 | https://api.github.com/repos/simonw/sqlite-utils/issues/510 | IC_kwDOCGYnMM5Os52P | ar-jan 1176293 | 2022-11-18T18:37:51Z | 2022-11-18T18:37:51Z | NONE | I guess it is not incorrect when it says the version is |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Cannot enable FTS5 despite it being available 1434911255 | |
1319664697 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319664697 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5OqHw5 | rdmurphy 419145 | 2022-11-18T07:59:36Z | 2022-11-18T08:00:38Z | NONE | Okay, my final observations for the night! I've been pushing and pulling the various levers in Unfortunately cannot audit that for (It was actually this comment from back in 2018 in an entirely unrelated repo that nudged me to try this, ha.) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319642535 | https://github.com/simonw/datasette/pull/1898#issuecomment-1319642535 | https://api.github.com/repos/simonw/datasette/issues/1898 | IC_kwDOBm6k_c5OqCWn | simonw 9599 | 2022-11-18T07:28:45Z | 2022-11-18T07:28:45Z | OWNER | Thanks! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Use DOMContentLoaded instead of load event for CodeMirror initialization 1452485922 | |
1319642338 | https://github.com/simonw/datasette/issues/1899#issuecomment-1319642338 | https://api.github.com/repos/simonw/datasette/issues/1899 | IC_kwDOBm6k_c5OqCTi | simonw 9599 | 2022-11-18T07:28:28Z | 2022-11-18T07:28:28Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Clicking within the CodeMirror area below the SQL (i.e. when there's only a single line) doesn't cause the editor to get focused 1452495049 | ||
1319641636 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319641636 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5OqCIk | rdmurphy 419145 | 2022-11-18T07:27:26Z | 2022-11-18T07:27:26Z | NONE | Can confirm that my
I'm in |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319639462 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319639462 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5OqBmm | rdmurphy 419145 | 2022-11-18T07:24:19Z | 2022-11-18T07:24:19Z | NONE | Is it, uh, possible we are on different architectures? 😅 I'm using an Apple M1 Pro. I jumped into a bash shell of an unmodified I swapped that directory in here in a local copy of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319525520 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319525520 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5OplyQ | simonw 9599 | 2022-11-18T04:21:14Z | 2022-11-18T07:22:37Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | ||
1319631421 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319631421 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Op_o9 | simonw 9599 | 2022-11-18T07:13:00Z | 2022-11-18T07:13:00Z | OWNER | You get:
I get:
For my machine: ``` ~ % docker --version Docker version 20.10.12, build e91ed57 ~ % uname -a Darwin Simons-MacBook-Pro-2.local 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct 9 20:14:54 PDT 2022; root:xnu-8792.41.9~2/RELEASE_X86_64 x86_64 ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319629469 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319629469 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Op_Kd | simonw 9599 | 2022-11-18T07:10:17Z | 2022-11-18T07:10:17Z | OWNER | This is so weird! What version of Datasette do you get from |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319627012 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319627012 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5Op-kE | simonw 9599 | 2022-11-18T07:07:03Z | 2022-11-18T07:07:03Z | OWNER | Here's the full list of 10 plugin releases for this issue: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | |
1319493475 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319493475 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5Opd9j | simonw 9599 | 2022-11-18T03:19:25Z | 2022-11-18T07:03:03Z | OWNER | Other plugins this looks like it will affect:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | |
1319623911 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319623911 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5Op9zn | simonw 9599 | 2022-11-18T07:02:56Z | 2022-11-18T07:02:56Z | OWNER | That's all of them! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | |
1319596087 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319596087 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Op3A3 | rdmurphy 419145 | 2022-11-18T06:16:33Z | 2022-11-18T06:16:33Z | NONE | Interesting! So I tried this locally using your copy of ```
❯ datasette package nps-spatialite.db --spatialite
[+] Building 27.5s (10/10) FINISHED
10 0.681 Traceback (most recent call last):10 0.681 File "/usr/local/bin/datasette", line 8, in <module>10 0.681 sys.exit(cli())10 0.681 ^^^^^10 0.681 File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1130, in call10 0.682 return self.main(args, *kwargs)10 0.682 ^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.682 File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1055, in main10 0.682 rv = self.invoke(ctx)10 0.682 ^^^^^^^^^^^^^^^^10 0.682 File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1657, in invoke10 0.682 return _process_result(sub_ctx.command.invoke(sub_ctx))10 0.682 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.682 File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1404, in invoke10 0.682 return ctx.invoke(self.callback, **ctx.params)10 0.682 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.682 File "/usr/local/lib/python3.11/site-packages/click/core.py", line 760, in invoke10 0.682 return __callback(args, *kwargs)10 0.682 ^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/cli.py", line 164, in inspect10 0.683 inspect_data = loop.run_until_complete(inspect_(files, sqlite_extensions))10 0.683 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/asyncio/base_events.py", line 650, in run_until_complete10 0.683 return future.result()10 0.683 ^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/cli.py", line 179, in inspect_10 0.683 counts = await database.table_counts(limit=3600 * 1000)10 0.683 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/database.py", line 304, in table_counts10 0.683 for table in await self.table_names():10 0.683 ^^^^^^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/database.py", line 342, in table_names10 0.683 results = await self.execute(10 0.683 ^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/database.py", line 267, in execute10 0.683 results = await self.execute_fn(sql_operation_in_thread)10 0.683 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/database.py", line 213, in execute_fn10 0.683 return await asyncio.get_event_loop().run_in_executor(10 0.683 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run10 0.683 result = self.fn(self.args, *self.kwargs)10 0.683 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/database.py", line 209, in in_thread10 0.683 self.ds._prepare_connection(conn, self.name)10 0.683 File "/usr/local/lib/python3.11/site-packages/datasette/app.py", line 593, in _prepare_connection10 0.683 conn.execute("SELECT load_extension(?)", [extension])10 0.683 sqlite3.OperationalError: /usr/lib/x86_64-linux-gnu/mod_spatialite.so.so: cannot open shared object file: No such file or directoryexecutor failed running [/bin/sh -c datasette inspect nps-spatialite.db --inspect-file inspect-data.json]: exit code: 1 ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319588163 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319588163 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5Op1FD | simonw 9599 | 2022-11-18T06:05:11Z | 2022-11-18T06:05:11Z | OWNER | For
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | |
1319584553 | https://github.com/simonw/datasette/issues/1899#issuecomment-1319584553 | https://api.github.com/repos/simonw/datasette/issues/1899 | IC_kwDOBm6k_c5Op0Mp | simonw 9599 | 2022-11-18T06:00:10Z | 2022-11-18T06:01:50Z | OWNER | I can't actually remember where that I ran this in the DevTools console:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Clicking within the CodeMirror area below the SQL (i.e. when there's only a single line) doesn't cause the editor to get focused 1452495049 | |
1319583703 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319583703 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Opz_X | simonw 9599 | 2022-11-18T05:58:31Z | 2022-11-18T05:58:31Z | OWNER | Could you provide full steps to reproduce plus a SpatiaLite database file that triggered this for you? I'm not able to recreate the problem. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319583281 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319583281 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Opz4x | simonw 9599 | 2022-11-18T05:57:44Z | 2022-11-18T05:57:44Z | OWNER | Did you use the I just tried this:
It built the image OK (I didn't see the error you reported), but running the container failed with an error: ``` /tmp % docker run -p 8001:8001 7298e8e6bbfb Usage: datasette serve [OPTIONS] [FILES]... Try 'datasette serve --help' for help. Error: It looks like you're trying to load a SpatiaLite database without first loading the SpatiaLite module. Read more: https://docs.datasette.io/en/stable/spatialite.html ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319582239 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319582239 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Opzof | simonw 9599 | 2022-11-18T05:55:38Z | 2022-11-18T05:55:38Z | OWNER | Trying this out locally with this 69MB SpatiaLite file I happened to have lying around (from testing
This worked fine for me. I ran |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319574972 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319574972 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Opx28 | simonw 9599 | 2022-11-18T05:41:28Z | 2022-11-18T05:41:28Z | OWNER | Oh this is with |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319571220 | https://github.com/simonw/datasette/issues/1900#issuecomment-1319571220 | https://api.github.com/repos/simonw/datasette/issues/1900 | IC_kwDOBm6k_c5Opw8U | simonw 9599 | 2022-11-18T05:34:35Z | 2022-11-18T05:34:35Z | OWNER | Which Docker image are you using here? It looks like it's missing SpatiaLite from the image. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette package --spatialite throws error during build 1452572348 | |
1319570586 | https://github.com/simonw/datasette/issues/1897#issuecomment-1319570586 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5Opwya | simonw 9599 | 2022-11-18T05:33:20Z | 2022-11-18T05:33:20Z | OWNER | One of the big changes still left to do for Datasette 1.0 is to unify the JSON representation with the context psssed to the templates (via an As such I expect to do quite a bit of refactoring and cleanup on how the template context works later on. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1319533445 | https://github.com/simonw/datasette/issues/1897#issuecomment-1319533445 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OpnuF | bgrins 95570 | 2022-11-18T04:38:03Z | 2022-11-18T04:38:03Z | CONTRIBUTOR | Are you tracking the change to send the JSON over to the frontend separately or was that part of this? Something like this is probably pretty close https://github.com/bgrins/datasette/commit/8431c98850c7a552dbcde2a4dd0c3dc942a97d25#diff-0c93232bfd5477eeac96382e52769108b41433d960d5277ffcccf2f464e60abdR9 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1319528359 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319528359 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5Opmen | simonw 9599 | 2022-11-18T04:27:00Z | 2022-11-18T04:27:00Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | ||
1319483555 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319483555 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5Opbij | simonw 9599 | 2022-11-18T03:02:35Z | 2022-11-18T03:02:35Z | OWNER | Looks like this issue could affect a bunch of other plugins too: https://cs.github.com/?scopeName=All+repos&scope=&q=%3Cp+class%3D%22crumbs%22%3E+user%3Asimonw |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | |
1319482791 | https://github.com/simonw/datasette/issues/1901#issuecomment-1319482791 | https://api.github.com/repos/simonw/datasette/issues/1901 | IC_kwDOBm6k_c5OpbWn | simonw 9599 | 2022-11-18T03:01:36Z | 2022-11-18T03:01:36Z | OWNER | Good catch. Looks like that bug was introduced by this change: https://github.com/simonw/datasette/commit/1a5e5f2aa951e5bd731067a49819efba68fbe8ef From: The search all plugin includes this code which interacts poorly with that refactor:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Some plugins show "home" breadcrumbs twice in the top left 1453813400 | |
1319478811 | https://github.com/simonw/datasette/issues/1897#issuecomment-1319478811 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OpaYb | simonw 9599 | 2022-11-18T02:53:57Z | 2022-11-18T02:53:57Z | OWNER | I decided to just go for the view names, not their columns. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1319477721 | https://github.com/simonw/datasette/issues/1897#issuecomment-1319477721 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OpaHZ | simonw 9599 | 2022-11-18T02:51:40Z | 2022-11-18T02:51:40Z | OWNER | Views aren't currently available in the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1319435374 | https://github.com/simonw/datasette/issues/1897#issuecomment-1319435374 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OpPxu | simonw 9599 | 2022-11-18T01:33:30Z | 2022-11-18T01:33:30Z | OWNER | Just noticed that this isn't including views, which it should. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1319401843 | https://github.com/simonw/datasette/issues/1897#issuecomment-1319401843 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OpHlz | simonw 9599 | 2022-11-18T00:42:03Z | 2022-11-18T00:42:23Z | OWNER | This function works even if the SQLite JSON functions are not available:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1318897922 | https://github.com/simonw/datasette/issues/1899#issuecomment-1318897922 | https://api.github.com/repos/simonw/datasette/issues/1899 | IC_kwDOBm6k_c5OnMkC | bgrins 95570 | 2022-11-17T16:32:42Z | 2022-11-17T16:32:42Z | CONTRIBUTOR | Another idea would be to just not set a min-height and allow the 1 line input to be 1 line heigh |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Clicking within the CodeMirror area below the SQL (i.e. when there's only a single line) doesn't cause the editor to get focused 1452495049 | |
1297788531 | https://github.com/simonw/sqlite-utils/pull/508#issuecomment-1297788531 | https://api.github.com/repos/simonw/sqlite-utils/issues/508 | IC_kwDOCGYnMM5NWq5z | chapmanjacobd 7908073 | 2022-10-31T22:54:33Z | 2022-11-17T15:11:16Z | CONTRIBUTOR | Maybe this is actually a problem in the python sqlite bindings. Given SQLITE's stance on this they should probably use |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow surrogates in parameters 1430563092 | |
1318777114 | https://github.com/simonw/sqlite-utils/issues/510#issuecomment-1318777114 | https://api.github.com/repos/simonw/sqlite-utils/issues/510 | IC_kwDOCGYnMM5OmvEa | chapmanjacobd 7908073 | 2022-11-17T15:09:47Z | 2022-11-17T15:09:47Z | CONTRIBUTOR | why close? is the only problem that the _config table that incorrectly says 4 for fts5? if so, that's still something that should be fixed |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Cannot enable FTS5 despite it being available 1434911255 | |
1318431389 | https://github.com/simonw/sqlite-utils/issues/510#issuecomment-1318431389 | https://api.github.com/repos/simonw/sqlite-utils/issues/510 | IC_kwDOCGYnMM5Olaqd | ar-jan 1176293 | 2022-11-17T10:36:28Z | 2022-11-17T10:36:28Z | NONE | The virtual table's _config |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Cannot enable FTS5 despite it being available 1434911255 | |
1317889323 | https://github.com/simonw/datasette/issues/1890#issuecomment-1317889323 | https://api.github.com/repos/simonw/datasette/issues/1890 | IC_kwDOBm6k_c5OjWUr | fgregg 536941 | 2022-11-17T00:47:36Z | 2022-11-17T00:47:36Z | CONTRIBUTOR | amazing! thanks @simonw |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Autocomplete text entry for filter values that correspond to facets 1448143294 | |
1317873458 | https://github.com/simonw/datasette/issues/1899#issuecomment-1317873458 | https://api.github.com/repos/simonw/datasette/issues/1899 | IC_kwDOBm6k_c5OjScy | bgrins 95570 | 2022-11-17T00:31:07Z | 2022-11-17T00:31:07Z | CONTRIBUTOR | This is one way to fix it
I don't love it but it seems to work for the default case. You can still retrigger the bug by resizing the editor to be > 70px high. The other approach would be to listen for a click on that empty region and move focus to the editor, or something |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Clicking within the CodeMirror area below the SQL (i.e. when there's only a single line) doesn't cause the editor to get focused 1452495049 | |
1317870550 | https://github.com/simonw/datasette/pull/1898#issuecomment-1317870550 | https://api.github.com/repos/simonw/datasette/issues/1898 | IC_kwDOBm6k_c5OjRvW | codecov[bot] 22429695 | 2022-11-17T00:27:55Z | 2022-11-17T00:27:55Z | NONE | Codecov ReportBase: 92.55% // Head: 92.55% // No change to project coverage :thumbsup:
Additional details and impacted files```diff @@ Coverage Diff @@ ## main #1898 +/- ## ======================================= Coverage 92.55% 92.55% ======================================= Files 35 35 Lines 4432 4432 ======================================= Hits 4102 4102 Misses 330 330 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison):umbrella: View full report at Codecov. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Use DOMContentLoaded instead of load event for CodeMirror initialization 1452485922 | |
1317840727 | https://github.com/simonw/datasette/issues/1897#issuecomment-1317840727 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OjKdX | simonw 9599 | 2022-11-16T23:57:52Z | 2022-11-16T23:57:52Z | OWNER | In terms of permissions: if you have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1317839781 | https://github.com/simonw/datasette/issues/1897#issuecomment-1317839781 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OjKOl | simonw 9599 | 2022-11-16T23:56:47Z | 2022-11-16T23:56:47Z | OWNER | I'm going to call this |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1317838892 | https://github.com/simonw/datasette/issues/1897#issuecomment-1317838892 | https://api.github.com/repos/simonw/datasette/issues/1897 | IC_kwDOBm6k_c5OjKAs | simonw 9599 | 2022-11-16T23:55:42Z | 2022-11-16T23:55:42Z | OWNER | Here's where the schema is hard-coded at the moment: https://github.com/simonw/datasette/blob/00e233d7a7f6443cb95fb5227c23580c48551cad/datasette/templates/_codemirror_foot.html#L2-L7 I figured out how to extract that data from the Although that used JSON functions which may (in a real edge-case) not be available in the version of SQLite that Datasette is running on, so probably going to use a regular SQL query and then assemble the JSON separately. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Serve schema JSON to the SQL editor to enable autocomplete 1452457263 | |
1317837416 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317837416 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OjJpo | simonw 9599 | 2022-11-16T23:54:02Z | 2022-11-16T23:54:02Z | OWNER | I'm going to tackle #1897 in the next few minutes. Tests failed due to Prettier check, just pushed a fix so it would ignore |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317834838 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317834838 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OjJBW | bgrins 95570 | 2022-11-16T23:50:58Z | 2022-11-16T23:50:58Z | CONTRIBUTOR | Should we empty out the fixture schema to avoid fixture autocomplete showing up on live databases in the interim, or are you planning to tackle #1897 shortly? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317831555 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317831555 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OjIOD | simonw 9599 | 2022-11-16T23:47:13Z | 2022-11-16T23:47:13Z | OWNER | I'll open a follow-up issue to fix the schema. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317831425 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317831425 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OjIMB | simonw 9599 | 2022-11-16T23:47:05Z | 2022-11-16T23:47:05Z | OWNER | OK, let's do it! Thanks so much for this. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317829214 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317829214 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OjHpe | simonw 9599 | 2022-11-16T23:44:36Z | 2022-11-16T23:44:36Z | OWNER | Deployed that to https://datasette-pr-1893.vercel.app/fixtures - looks good to me! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1316297347 | https://github.com/simonw/datasette/pull/1893#issuecomment-1316297347 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OdRqD | codecov[bot] 22429695 | 2022-11-16T04:05:12Z | 2022-11-16T23:27:45Z | NONE | Codecov ReportBase: 92.55% // Head: 92.55% // No change to project coverage :thumbsup:
Additional details and impacted files```diff @@ Coverage Diff @@ ## main #1893 +/- ## ======================================= Coverage 92.55% 92.55% ======================================= Files 35 35 Lines 4432 4432 ======================================= Hits 4102 4102 Misses 330 330 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison):umbrella: View full report at Codecov. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317805482 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317805482 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OjB2q | bgrins 95570 | 2022-11-16T23:18:17Z | 2022-11-16T23:18:17Z | CONTRIBUTOR | Alright with https://github.com/simonw/datasette/pull/1893/commits/f254be4b38936e95e7a7f25866e7c6b0520db96f we should be getting autocomplete on fixture data. Give that a test and see what you think |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317797044 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317797044 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Oi_y0 | simonw 9599 | 2022-11-16T23:08:34Z | 2022-11-16T23:08:34Z | OWNER |
Yeah, push that up. I'm happy to wire in the query right after we land this. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317789308 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317789308 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Oi958 | bgrins 95570 | 2022-11-16T22:59:57Z | 2022-11-16T22:59:57Z | CONTRIBUTOR | I can push up a commit that uses the static fixtures schema for testing, but given that the query used to generate it is authed we would still need some work to make that work on live data, right? Ideally it could come down to db and query views directly to avoid waiting on an extra xhr and managing that state change.On Nov 16, 2022, at 2:16 PM, Simon Willison @.***> wrote: Honestly I'm not too bothered if table names with weird characters don't work correctly here - I care about those in the Datasette fixtures.db database because Datasette aims to support ANY valid SQLite database, so I need stuff in the test suite that includes weird edge cases like this. But I would hope very few people actually create tables with spaces in their names, so it's not a huge concern to me if autocompletion doesn't work properly for those. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***> |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317757112 | https://github.com/simonw/datasette/issues/1896#issuecomment-1317757112 | https://api.github.com/repos/simonw/datasette/issues/1896 | IC_kwDOBm6k_c5Oi2C4 | simonw 9599 | 2022-11-16T22:26:52Z | 2022-11-16T22:33:13Z | OWNER | Some ideas from walking the dog: Challenge: standard URL routing of request to database/table/row Standardize on the named components of the URL patterns - Async function that takes the request and the Datasette instance and returns a Resolved instance with:
await datasette.resolve_request(request)
Methods raise |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Extract logic for resolving a URL to a database / table / row 1452364777 | |
1317755263 | https://github.com/simonw/datasette/issues/1863#issuecomment-1317755263 | https://api.github.com/repos/simonw/datasette/issues/1863 | IC_kwDOBm6k_c5Oi1l_ | simonw 9599 | 2022-11-16T22:24:59Z | 2022-11-16T22:24:59Z | OWNER | In trying to write this I realize that there's a lot of duplicated code with delete row, specifically around resolving the incoming URL into a row (or a database or a table). Since this is so common, I think it's worth extracting the logic out first. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update a single record in an existing table 1425029242 | |
1317746206 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317746206 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OizYe | simonw 9599 | 2022-11-16T22:17:24Z | 2022-11-16T22:17:24Z | OWNER | Deployed 0a649e8f78c23e8db6869442eeb0dfe36a5443da: https://datasette-pr-1893.vercel.app/fixtures |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317744563 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317744563 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Oiy-z | simonw 9599 | 2022-11-16T22:16:03Z | 2022-11-16T22:16:03Z | OWNER | Honestly I'm not too bothered if table names with weird characters don't work correctly here - I care about those in the Datasette |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317715580 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317715580 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Oir58 | bgrins 95570 | 2022-11-16T21:49:51Z | 2022-11-16T21:49:51Z | CONTRIBUTOR | I think the table completion still has some quirks to work out. Something like
Seems to work alright, although it will append it after any other numbers you've started typing - so you end up with You can do
Which is pretty neat and will show the non-escaped string but complete to the escaped one. You can't easily do that with the table names themselves (you can pass a It's buggy enough (bad output for these unusual table names) that I'd suggest that work gets moved into a follow up to the upgrade to 6. That would give space to sort out how to deliver that to the view directly, figure out where name escaping should happen, and have overall testing to uncover bugs and fix papercuts before enabling it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317681193 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317681193 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Oijgp | bgrins 95570 | 2022-11-16T21:19:13Z | 2022-11-16T21:19:13Z | CONTRIBUTOR | Alright, added Cmd+Enter to submit (Ctrl+Enter on Windows as well bc of using Meta-Enter on codemirror). We can make that MacOS only by changing the combo to Cmd+Enter specifically but I think it's probably fine to have both. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317522323 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317522323 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Oh8uT | bgrins 95570 | 2022-11-16T18:59:49Z | 2022-11-16T18:59:49Z | CONTRIBUTOR | Or I guess you could return only the escaped table name and then we could derive the unescaped from the client side (removing the outer |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317520304 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317520304 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Oh8Ow | bgrins 95570 | 2022-11-16T18:58:43Z | 2022-11-16T18:58:43Z | CONTRIBUTOR | Nice. And is it possible to include another field which is an escaped table name (only when necessary) - i.e. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317475720 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317475720 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OhxWI | simonw 9599 | 2022-11-16T18:25:16Z | 2022-11-16T18:25:16Z | OWNER | Here's a query that returns the exact JSON we need to pass to the schema:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317465874 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317465874 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Ohu8S | simonw 9599 | 2022-11-16T18:21:17Z | 2022-11-16T18:21:54Z | OWNER | I was worrying about the server-side overhead of collecting together all of the tables and column names for databases that might have hundreds of tables... but then I remember that I built the https://latest.datasette.io/login-as-root and then visit this page for an example query: https://latest.datasette.io/_internal?sql=select%0D%0A++database_name%2C%0D%0A++table_name%2C%0D%0A++json_group_array%28name%29%0D%0Afrom%0D%0A++columns%0D%0Awhere%0D%0A++database_name+%21%3D+%27_internal%27%0D%0Agroup+by%0D%0A++database_name%2C%0D%0A++table_name
database_name | table_name | json_group_array(name) -- | -- | -- extra_database | searchable | ["pk","text1","text2"] extra_database | searchable_fts | ["__langid","content","docid","searchable_fts","text1","text2"] extra_database | searchable_fts_content | ["c0text1","c1text2","c2content","docid"] extra_database | searchable_fts_segdir | ["end_block","idx","leaves_end_block","level","root","start_block"] extra_database | searchable_fts_segments | ["block","blockid"] fixtures | 123_starts_with_digits | ["content"] fixtures | Table With Space In Name | ["content","pk"] fixtures | attraction_characteristic | ["name","pk"] fixtures | binary_data | ["data"] fixtures | complex_foreign_keys | ["f1","f2","f3","pk"] fixtures | compound_primary_key | ["content","pk1","pk2"] |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317456909 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317456909 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OhswN | simonw 9599 | 2022-11-16T18:17:39Z | 2022-11-16T18:17:39Z | OWNER | Tiny feature request (since you're in this code already) - I keep hitting Command+Enter on my macOS keyboard to submit the query, but the correct shortcut is Shift+Enter. Would be great if both worked! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317452541 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317452541 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Ohrr9 | simonw 9599 | 2022-11-16T18:15:52Z | 2022-11-16T18:15:52Z | OWNER | Deployed latest copy with:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317449610 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317449610 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5Ohq-K | simonw 9599 | 2022-11-16T18:14:28Z | 2022-11-16T18:14:28Z | OWNER |
Huh, yeah we should definitely have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317420812 | https://github.com/simonw/datasette/issues/1880#issuecomment-1317420812 | https://api.github.com/repos/simonw/datasette/issues/1880 | IC_kwDOBm6k_c5Ohj8M | amitkoth 525934 | 2022-11-16T17:50:29Z | 2022-11-16T17:50:29Z | NONE | I appreciate your response @simonw - thanks! I'll clarify what we need further - let's imagine we have 2000 SQLLite databases (for 2000 tenants), but we only want to run one datasette instance for each of those tenants to query/use datasette against their own database only. This means the "connection" between datasette and the SQLLite database would be dynamic, based on the tenantID that's required on an incoming request. Is there any specific config or other considerations in this use case, to minimize memory use on a single, efficient VM and serve queries to all these tenants? cc @muadham |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette with many and large databases > Memory use 1433576351 | |
1317329157 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317329157 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OhNkF | bgrins 95570 | 2022-11-16T16:46:52Z | 2022-11-16T16:46:52Z | CONTRIBUTOR |
I checked and if I empty out app.css the bug goes away, so there's some kind of inheritance issue there. It's hard to debug bc the autocomplete popup goes away on blur (i.e. when trying to inspect it in devtools), but at least it's narrowed down a bit. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317326406 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317326406 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OhM5G | bgrins 95570 | 2022-11-16T16:45:09Z | 2022-11-16T16:45:09Z | CONTRIBUTOR | For escaped table names it looks like we could pass a Completion object (https://codemirror.net/docs/ref/#autocomplete) instead of a string which would allow the non escaped name to be a label and then the escaped name to actually complete in the editor, which might help with some of the funkiness I was seeing w/ completion |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 | |
1317314064 | https://github.com/simonw/datasette/pull/1893#issuecomment-1317314064 | https://api.github.com/repos/simonw/datasette/issues/1893 | IC_kwDOBm6k_c5OhJ4Q | bgrins 95570 | 2022-11-16T16:36:46Z | 2022-11-16T16:36:46Z | CONTRIBUTOR | With
we get table autocompletion and column completion if you name the table in the query (see screencast). I do see bugs with escaped table names like https://user-images.githubusercontent.com/95570/202238521-e613b4e2-ba92-4418-9068-fc022edaee93.mp4 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Upgrade to CodeMirror 6, add SQL autocomplete 1450363982 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user >30