issue_comments
14 rows where "created_at" is on date 2022-01-21 sorted by created_at
This data as json, CSV (advanced)
Suggested facets: issue_url, updated_at (date)
id | html_url | issue_url | node_id | user | created_at ▼ | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1018063681 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018063681 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rmtB | simonw 9599 | 2022-01-21T00:58:25Z | 2022-01-21T00:58:32Z | OWNER | On Twitter: https://twitter.com/simonw/status/1484317711672877065 Here's the problem: Uvicorn only added |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018064620 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018064620 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rm7s | simonw 9599 | 2022-01-21T01:00:12Z | 2022-01-21T01:00:12Z | OWNER | I think there are two possible solutions then:
I've made the request for 1) in Uvicorn Gitter here: https://gitter.im/encode/community?at=61ea044a6d9ba23328d0fa28 I'm going to investigate option 2) myself now. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018075357 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018075357 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rpjd | simonw 9599 | 2022-01-21T01:20:56Z | 2022-01-21T01:20:56Z | OWNER | I used the combo of
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018077009 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018077009 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rp9R | simonw 9599 | 2022-01-21T01:24:15Z | 2022-01-21T01:24:43Z | OWNER | Problem: if I ship this, it will be the most recent release of Datasette - but unlike other previous releases it has exactly pinned versions of all of the dependencies. Which is bad for people who run So maybe I ship this as 0.60.1, then ship a 0.60.2 release directly afterwards which unpins the dependencies again and requires Python 3.7? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018082792 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018082792 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rrXo | simonw 9599 | 2022-01-21T01:37:11Z | 2022-01-21T01:37:11Z | OWNER | Another option from https://twitter.com/samuel_hames/status/1484327636860293121 - environment markers, described in https://www.python.org/dev/peps/pep-0508/#environment-markers Found some examples of those in use using GitHub code search: https://cs.github.com/?scopeName=All+repos&scope=&q=%22%3Bpython_version%22+path%3Asetup.py - in particular https://github.com/xmendez/wfuzz/blob/1b695ee9a87d66a7d7bf6cae70d60a33fae51541/setup.py#L31-L38
Here's my One other problem: there might be packages in that list right now which don't specify their 3.6 Python version but which will, at some point in the future, release a new version that doesn't work with 3.6 (like Uvicorn did) - in which case Python 3.6 installs would break in the future. I think what I'll do then is ship the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018086273 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018086273 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rsOB | simonw 9599 | 2022-01-21T01:45:46Z | 2022-01-21T01:45:46Z | OWNER | This whole thing reminds me of my ongoing internal debate about version pinning: should the Datasette package released to PyPI pin to the exact versions of the dependencies that are known to work, or should it allow a range of dependencies so users can pick other versions of the dependencies to use in their environment? As I understand it, the general rule is to use exact pinning for applications but use ranges for libraries. Datasette is almost entirely an application... but it can also be used as a library - and in fact I'm hoping to encourage that usage more in the future, see: - #1398 I'd also like to release a packaged version of Datasette that doesn't require Uvicorn, for running on AWS Lambda and other function-as-a-service platforms. Those platforms have their own HTTP layer and hence don't need the Uvicorn dependency. Maybe the answer is to have a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018086697 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018086697 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rsUp | simonw 9599 | 2022-01-21T01:46:43Z | 2022-01-21T01:46:43Z | OWNER | https://github.com/simonw/datasette/runs/4890775227?check_suite_focus=true - the tests passed on Python 3.6 for this commit with the pinned dependencies: https://github.com/simonw/datasette/commit/41060e7e7cb838328c879de6a98ae794dc1886d0 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018091322 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018091322 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rtc6 | simonw 9599 | 2022-01-21T01:56:42Z | 2022-01-21T01:56:42Z | OWNER | OK, the environment markers approach seems to work! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018092984 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018092984 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rt24 | simonw 9599 | 2022-01-21T02:00:38Z | 2022-01-21T02:00:38Z | OWNER | Out of curiosity, I installed this latest From that, it looks like the Python packages in my dependencies which have released new versions that don't work with Python 3.6 are:
Sure enough, for the first three of those browsing through their recent versions on PyPI confirms that they switched from e.g. "Requires: Python >=3.6" on https://pypi.org/project/janus/0.7.0/ to "Requires: Python >=3.7" on https://pypi.org/project/janus/1.0.0/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018094767 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018094767 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48ruSv | simonw 9599 | 2022-01-21T02:04:14Z | 2022-01-21T02:04:14Z | OWNER | So I don't need to release 0.60.1 AND 0.60.2 after all - I can just release 0.60.1 with a bug fix that it no longer breaks installation for Python 3.6. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018104868 | https://github.com/simonw/datasette/issues/1609#issuecomment-1018104868 | https://api.github.com/repos/simonw/datasette/issues/1609 | IC_kwDOBm6k_c48rwwk | simonw 9599 | 2022-01-21T02:24:13Z | 2022-01-21T02:24:13Z | OWNER | Just shipped 0.60.1 with the fix - and tested that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ensure "pip install datasette" still works with Python 3.6 1109884720 | |
1018741262 | https://github.com/simonw/datasette/issues/1605#issuecomment-1018741262 | https://api.github.com/repos/simonw/datasette/issues/1605 | IC_kwDOBm6k_c48uMIO | eyeseast 25778 | 2022-01-21T18:05:09Z | 2022-01-21T18:05:09Z | CONTRIBUTOR | Thinking about this more, as well as #1356 and various other tickets related to output formats, I think there's a missing plugin hook for formatting results, separate from Right now, as I understand it, getting output in any format goes through the normal view stack -- a table, a row or a query -- and so by the time It's possible this could be done using Another option is some kind of registry of serializers, which |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Scripted exports 1108671952 | |
1018766727 | https://github.com/simonw/datasette/issues/1605#issuecomment-1018766727 | https://api.github.com/repos/simonw/datasette/issues/1605 | IC_kwDOBm6k_c48uSWH | simonw 9599 | 2022-01-21T18:41:21Z | 2022-01-21T18:42:03Z | OWNER | Yeah I think this all hinges on: - #1101 Also this comment about streaming full JSON arrays (not just newline-delimited) using this trick: - https://github.com/simonw/datasette/issues/1356#issuecomment-1017016553 I'm about ready to figure these out, as with so much it's still a little bit blocked on the refactor stuff from: - #1518 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Scripted exports 1108671952 | |
1018778667 | https://github.com/simonw/datasette/issues/1605#issuecomment-1018778667 | https://api.github.com/repos/simonw/datasette/issues/1605 | IC_kwDOBm6k_c48uVQr | eyeseast 25778 | 2022-01-21T19:00:01Z | 2022-01-21T19:00:01Z | CONTRIBUTOR | Let me know if you want help prototyping any of this, because I'm thinking about it and trying stuff out. Happy to be a sounding board, if it helps. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Scripted exports 1108671952 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 2