issue_comments
19 rows where "created_at" is on date 2022-03-07 sorted by created_at
This data as json, CSV (advanced)
Suggested facets: issue_url, updated_at (date)
id | html_url | issue_url | node_id | user | created_at ▼ | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1060836262 | https://github.com/simonw/datasette/issues/1650#issuecomment-1060836262 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_OxOm | simonw 9599 | 2022-03-07T15:52:09Z | 2022-03-07T15:52:09Z | OWNER | This is a bit tricky. I tried this, sending a redirect only if a 404 happens: ```diff diff --git a/datasette/app.py b/datasette/app.py index 8c5480c..420664c 100644 --- a/datasette/app.py +++ b/datasette/app.py @@ -1211,6 +1211,10 @@ class DatasetteRouter: return await self.handle_404(request, send)
I was expecting that to redirect to this page:
But instead it took me to another 404:
This is because that URL contains both a %-escaped |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1060853226 | https://github.com/simonw/datasette/issues/1651#issuecomment-1060853226 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_O1Xq | simonw 9599 | 2022-03-07T16:04:26Z | 2022-03-07T16:04:26Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | ||
1060863311 | https://github.com/simonw/datasette/issues/1650#issuecomment-1060863311 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_O31P | simonw 9599 | 2022-03-07T16:13:17Z | 2022-03-07T16:13:17Z | OWNER | This doesn't seem to work. https://latest.datasette.io/fixtures/table%2Fwith%2Fslashes.csv should be redirecting now that this is deployed - which it is, because https://latest.datasette.io/-/versions shows 644d25d1de78a36b105cca479e7b3e4375a6eadc - but I'm not getting that redirect. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1060864823 | https://github.com/simonw/datasette/issues/1650#issuecomment-1060864823 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_O4M3 | simonw 9599 | 2022-03-07T16:14:33Z | 2022-03-07T16:14:33Z | OWNER | Same problem here: https://fivethirtyeight.datasettes.com/fivethirtyeight/ahca-2Dpolls%2Fahca_polls should redirect but doesn't. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1060870237 | https://github.com/simonw/datasette/issues/1439#issuecomment-1060870237 | https://api.github.com/repos/simonw/datasette/issues/1439 | IC_kwDOBm6k_c4_O5hd | simonw 9599 | 2022-03-07T16:19:22Z | 2022-03-07T16:19:22Z | OWNER | I didn't need to do any of the fancy regular expression routing stuff after all, since the new dash encoding format avoids using |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rethink how .ext formats (v.s. ?_format=) works before 1.0 973139047 | |
1061038414 | https://github.com/simonw/datasette/issues/1650#issuecomment-1061038414 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_PilO | simonw 9599 | 2022-03-07T19:14:04Z | 2022-03-07T19:14:04Z | OWNER | The problem seems to be that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1061041034 | https://github.com/simonw/datasette/issues/1650#issuecomment-1061041034 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_PjOK | simonw 9599 | 2022-03-07T19:16:51Z | 2022-03-07T19:16:51Z | OWNER | Here's the problem: https://github.com/simonw/datasette/blob/020effe47bf89f35182960a9645f2383a42ebd54/datasette/utils/init.py#L1173-L1175 Which is called here: So |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1061053094 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061053094 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_PmKm | simonw 9599 | 2022-03-07T19:29:01Z | 2022-03-07T19:29:01Z | OWNER | I found an obscure bug in #1650 which I can fix with this too. The following test should pass:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061148807 | https://github.com/simonw/datasette/issues/1653#issuecomment-1061148807 | https://api.github.com/repos/simonw/datasette/issues/1653 | IC_kwDOBm6k_c4_P9iH | simonw 9599 | 2022-03-07T21:21:23Z | 2022-03-07T21:21:23Z | OWNER | This is currently blocked on the fact that Datasette doesn't have a mechanism for sorting by more than one column: - #197 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to default a table to sorting by multiple columns 1161937073 | |
1061150672 | https://github.com/simonw/datasette/issues/1653#issuecomment-1061150672 | https://api.github.com/repos/simonw/datasette/issues/1653 | IC_kwDOBm6k_c4_P9_Q | simonw 9599 | 2022-03-07T21:23:39Z | 2022-03-07T21:23:39Z | OWNER | There may be a short-term fix for this: table view could start accepting a That fragment could then be pre-populated in |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to default a table to sorting by multiple columns 1161937073 | |
1061169528 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061169528 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_QCl4 | simonw 9599 | 2022-03-07T21:47:01Z | 2022-03-07T21:47:01Z | OWNER | Wow, this code is difficult to follow! Look at this bit inside the That's modifying the arguments that were extracted from the path by the routing regular expressions to have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061170897 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061170897 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_QC7R | simonw 9599 | 2022-03-07T21:48:35Z | 2022-03-07T21:48:35Z | OWNER | My attempts to simplify |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061181089 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061181089 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QFah | simonw 9599 | 2022-03-07T22:01:38Z | 2022-03-07T22:01:38Z | OWNER | I'm going to use the widely adopted Contributor Covenant: https://www.contributor-covenant.org/version/1/4/code-of-conduct/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061181530 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061181530 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QFha | simonw 9599 | 2022-03-07T22:02:06Z | 2022-03-07T22:02:06Z | OWNER | https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-code-of-conduct-to-your-project says this should be called |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061182132 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061182132 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QFq0 | simonw 9599 | 2022-03-07T22:02:43Z | 2022-03-07T22:02:43Z | OWNER | Neat, GitHub have a template for this https://github.com/simonw/datasette/community/code-of-conduct/new?template=contributor-covenant |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061184206 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061184206 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QGLO | simonw 9599 | 2022-03-07T22:04:51Z | 2022-03-07T22:04:51Z | OWNER | I'm going to add this to the main Datasette repo (done) and the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061197133 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061197133 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QJVN | simonw 9599 | 2022-03-07T22:19:35Z | 2022-03-07T22:19:35Z | OWNER | Also now live on https://datasette.io |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061223822 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061223822 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_QP2O | simonw 9599 | 2022-03-07T22:54:54Z | 2022-03-07T22:54:54Z | OWNER | I'm going to do a review of how URL routing works at the moment for the various views. I edited down the full list a bit - these are the most relevant:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061226942 | https://github.com/simonw/datasette/issues/647#issuecomment-1061226942 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_QQm- | simonw 9599 | 2022-03-07T23:00:06Z | 2022-03-07T23:00:06Z | OWNER | This needs to take into account the changes made here: - #1439 In the new encoding scheme, I think So the plugin could check for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 6