issue_comments
27 rows where "created_at" is on date 2022-11-30 sorted by reactions
This data as json, CSV (advanced)
id | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions ▼ | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1331476246 | https://github.com/simonw/datasette/issues/1915#issuecomment-1331476246 | https://api.github.com/repos/simonw/datasette/issues/1915 | IC_kwDOBm6k_c5PXLcW | simonw 9599 | 2022-11-30T00:04:35Z | 2022-11-30T00:08:24Z | OWNER | The new https://github.com/simonw/datasette-ephemeral-tables plugin is live now: https://latest.datasette.io/ephemeral - you have to navigate through https://latest.datasette.io/login-as-root first The table should vanish in a few minutes. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Interactive demo of Datasette 1.0 write APIs 1468709531 | |
1331478611 | https://github.com/simonw/datasette/issues/1915#issuecomment-1331478611 | https://api.github.com/repos/simonw/datasette/issues/1915 | IC_kwDOBm6k_c5PXMBT | simonw 9599 | 2022-11-30T00:07:37Z | 2022-11-30T00:07:37Z | OWNER | Then I created an API token at https://latest.datasette.io/-/create-token and ran this:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Interactive demo of Datasette 1.0 write APIs 1468709531 | |
1331479328 | https://github.com/simonw/datasette/issues/1915#issuecomment-1331479328 | https://api.github.com/repos/simonw/datasette/issues/1915 | IC_kwDOBm6k_c5PXMMg | simonw 9599 | 2022-11-30T00:08:41Z | 2022-11-30T00:08:41Z | OWNER | Five minute has now passed and https://latest.datasette.io/ephemeral/new_table is gone. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Interactive demo of Datasette 1.0 write APIs 1468709531 | |
1331479606 | https://github.com/simonw/datasette/issues/1915#issuecomment-1331479606 | https://api.github.com/repos/simonw/datasette/issues/1915 | IC_kwDOBm6k_c5PXMQ2 | simonw 9599 | 2022-11-30T00:09:06Z | 2022-11-30T00:09:06Z | OWNER | One last feature: I want to show an indication on the table page that the table has X seconds left to live. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Interactive demo of Datasette 1.0 write APIs 1468709531 | |
1331644078 | https://github.com/simonw/datasette/issues/1917#issuecomment-1331644078 | https://api.github.com/repos/simonw/datasette/issues/1917 | IC_kwDOBm6k_c5PX0au | simonw 9599 | 2022-11-30T04:58:06Z | 2022-11-30T04:58:06Z | OWNER | The problem might actually be here:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Don't allow writable API to edit the `_memory` database 1469043836 | |
1331644751 | https://github.com/simonw/datasette/issues/1917#issuecomment-1331644751 | https://api.github.com/repos/simonw/datasette/issues/1917 | IC_kwDOBm6k_c5PX0lP | simonw 9599 | 2022-11-30T04:59:22Z | 2022-11-30T04:59:22Z | OWNER | Yeah it looks like I introduced this bug here: https://github.com/simonw/datasette/commit/fb7e70d5e72a951efe4b29ad999d8915c032d021 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Don't allow writable API to edit the `_memory` database 1469043836 | |
1331651721 | https://github.com/simonw/datasette/issues/1916#issuecomment-1331651721 | https://api.github.com/repos/simonw/datasette/issues/1916 | IC_kwDOBm6k_c5PX2SJ | simonw 9599 | 2022-11-30T05:10:27Z | 2022-11-30T05:10:27Z | OWNER | They should return 405 method not allowed with an |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
GET requests against POST endpoints should not 500 error 1469015001 | |
1331657404 | https://github.com/simonw/datasette/issues/1919#issuecomment-1331657404 | https://api.github.com/repos/simonw/datasette/issues/1919 | IC_kwDOBm6k_c5PX3q8 | simonw 9599 | 2022-11-30T05:19:43Z | 2022-11-30T05:19:43Z | OWNER | This is the test: https://github.com/simonw/datasette/blob/8404b21556d133c89eda4bd1bf5335ed9a0785d6/tests/test_api_write.py#L342-L401 I'm suspicious that there's a timing error of some sort but I can't think what it might be. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Intermittent `test_delete_row` test failure 1469062686 | |
1331658629 | https://github.com/simonw/datasette/issues/1918#issuecomment-1331658629 | https://api.github.com/repos/simonw/datasette/issues/1918 | IC_kwDOBm6k_c5PX3-F | simonw 9599 | 2022-11-30T05:21:51Z | 2022-11-30T05:21:51Z | OWNER | Much better: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
API explorer should list mutable databases first 1469044738 | |
1331694246 | https://github.com/simonw/datasette/issues/1605#issuecomment-1331694246 | https://api.github.com/repos/simonw/datasette/issues/1605 | IC_kwDOBm6k_c5PYAqm | simonw 9599 | 2022-11-30T06:18:41Z | 2022-11-30T06:18:41Z | OWNER | Those sounds to me like they should be promoted to documented, supported internals. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Scripted exports 1108671952 | |
1332310772 | https://github.com/simonw/datasette/issues/1605#issuecomment-1332310772 | https://api.github.com/repos/simonw/datasette/issues/1605 | IC_kwDOBm6k_c5PaXL0 | eyeseast 25778 | 2022-11-30T15:06:37Z | 2022-11-30T15:06:37Z | CONTRIBUTOR | I'll add issues for both and do a documentation PR. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Scripted exports 1108671952 | |
1332492092 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332492092 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbDc8 | simonw 9599 | 2022-11-30T17:17:21Z | 2022-11-30T17:17:21Z | OWNER | I tried running |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332493004 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332493004 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbDrM | simonw 9599 | 2022-11-30T17:18:10Z | 2022-11-30T17:18:10Z | OWNER | Here's why: That's code in |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332504654 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332504654 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbGhO | simonw 9599 | 2022-11-30T17:27:39Z | 2022-11-30T17:27:39Z | OWNER | I'll test this once it's deployed to https://latest.datasette.io/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332561059 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332561059 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbUSj | simonw 9599 | 2022-11-30T18:19:20Z | 2022-11-30T18:19:20Z | OWNER | Two test failures: ``` ____ test_homepage_options _____ [gw0] linux -- Python 3.11.0 /opt/hostedtoolcache/Python/3.11.0/x64/bin/python app_client = <datasette.utils.testing.TestClient object at 0x7f4c489269d0>
/home/runner/work/datasette/datasette/tests/test_html.py:58: AssertionError ___ test_client_methods[options-/-405] ___ [gw1] linux -- Python 3.11.0 /opt/hostedtoolcache/Python/3.11.0/x64/bin/python datasette = <datasette.app.Datasette object at 0x7fc33c227550> method = 'options', path = '/', expected_status = 405
/home/runner/work/datasette/datasette/tests/test_internals_datasette_client.py:29: AssertionError =============================== warnings summary =============================== tests/test_cli.py::test_inspect_cli_writes_to_file tests/test_cli.py::test_inspect_cli /home/runner/work/datasette/datasette/datasette/cli.py:163: DeprecationWarning: There is no current event loop loop = asyncio.get_event_loop() tests/test_cli_serve_get.py: 2 warnings tests/test_cli.py: 12 warnings tests/test_crossdb.py: 1 warning /home/runner/work/datasette/datasette/datasette/cli.py:591: DeprecationWarning: There is no current event loop asyncio.get_event_loop().run_until_complete(ds.invoke_startup()) tests/test_cli_serve_get.py: 2 warnings tests/test_cli.py: 12 warnings tests/test_crossdb.py: 1 warning /home/runner/work/datasette/datasette/datasette/cli.py:594: DeprecationWarning: There is no current event loop asyncio.get_event_loop().run_until_complete(check_databases(ds)) -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_html.py::test_homepage_options - assert 200 == 405
+ where 200 = <datasette.utils.testing.TestResponse object at 0x7f4c4892f4d0>.status
FAILED tests/test_internals_datasette_client.py::test_client_methods[options-/-405] - assert 200 == 405
+ where 200 = <Response [200 OK]>.status_code
====== 2 failed, 1195 passed, 1 skipped, 32 warnings in 191.06s (0:03:11) ======
Error: Process completed with exit code 1.
Comparing a few different sites: ``` ~ % curl -X OPTIONS https://www.google.com/ -i HTTP/2 405 allow: GET, HEAD date: Wed, 30 Nov 2022 18:18:15 GMT content-type: text/html; charset=UTF-8 server: gws content-length: 1592 x-xss-protection: 0 x-frame-options: SAMEORIGIN alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43" <html lang=en> <meta charset=utf-8> <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width"> <title>Error 405 (Method Not Allowed)!!1</title> <style> *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px} </style>405. <ins>That’s an error.</ins> The request method |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332561813 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332561813 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbUeV | simonw 9599 | 2022-11-30T18:20:05Z | 2022-11-30T18:20:05Z | OWNER | Weird, GitHub reply with a 404!
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332572453 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332572453 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbXEl | simonw 9599 | 2022-11-30T18:30:38Z | 2022-11-30T18:30:54Z | OWNER | Started a conversation about how OPTIONS should work on Mastodon: https://fedi.simonwillison.net/@simon/109434148676475291 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332580395 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332580395 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbZAr | simonw 9599 | 2022-11-30T18:38:22Z | 2022-11-30T18:38:22Z | OWNER |
https://mastodon.social/@daniellindsley/109434186252099323 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332585861 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332585861 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbaWF | simonw 9599 | 2022-11-30T18:43:46Z | 2022-11-30T18:43:46Z | OWNER | Here's what Django Rest Framework does: https://github.com/encode/django-rest-framework/blob/1ae812ea209392ad76cc5d2f35f9f7fb337f63e4/rest_framework/views.py#L514-L521
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332688245 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332688245 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbzV1 | simonw 9599 | 2022-11-30T20:15:08Z | 2022-11-30T20:15:08Z | OWNER | Still getting a CORS error: My hunch is this is because I'm not sending |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332689547 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332689547 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PbzqL | simonw 9599 | 2022-11-30T20:16:21Z | 2022-11-30T20:16:46Z | OWNER | That notebook:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332698636 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332698636 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5Pb14M | simonw 9599 | 2022-11-30T20:25:50Z | 2022-11-30T20:25:50Z | OWNER | I just shipped this:
I'll try this out on |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332835664 | https://github.com/simonw/datasette/issues/1923#issuecomment-1332835664 | https://api.github.com/repos/simonw/datasette/issues/1923 | IC_kwDOBm6k_c5PcXVQ | simonw 9599 | 2022-11-30T22:50:10Z | 2022-11-30T22:51:25Z | OWNER | https://stackoverflow.com/questions/74490465/github-actions-failing-for-setup-gcloud/74562526#74562526 suggests setting |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
latest.datasette.io Cloud Run deploys failing 1470320227 | |
1332842435 | https://github.com/simonw/datasette/issues/1923#issuecomment-1332842435 | https://api.github.com/repos/simonw/datasette/issues/1923 | IC_kwDOBm6k_c5PcY_D | simonw 9599 | 2022-11-30T22:58:33Z | 2022-11-30T22:58:33Z | OWNER | https://stackoverflow.com/questions/74490465/github-actions-failing-for-setup-gcloud/74562740#74562740 suggests trying Python 3.9. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
latest.datasette.io Cloud Run deploys failing 1470320227 | |
1332851215 | https://github.com/simonw/datasette/issues/1923#issuecomment-1332851215 | https://api.github.com/repos/simonw/datasette/issues/1923 | IC_kwDOBm6k_c5PcbIP | simonw 9599 | 2022-11-30T23:04:56Z | 2022-11-30T23:04:56Z | OWNER | That fixed it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
latest.datasette.io Cloud Run deploys failing 1470320227 | |
1332855687 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332855687 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5PccOH | simonw 9599 | 2022-11-30T23:09:31Z | 2022-11-30T23:09:31Z | OWNER | Still getting a CORS header. I tried it in Chrome, which outputs helpful messages to the console: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 | |
1332903011 | https://github.com/simonw/datasette/issues/1922#issuecomment-1332903011 | https://api.github.com/repos/simonw/datasette/issues/1922 | IC_kwDOBm6k_c5Pcnxj | simonw 9599 | 2022-11-30T23:45:29Z | 2022-11-30T23:45:29Z | OWNER | That worked for the preflight request - got this now: So it looks like error responses (in this case for permission denied) are missing CORS headers. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make sure CORS works for write APIs 1469973742 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 8