issue_comments

Table actions

2 rows where author_association = "CONTRIBUTOR", issue = 1078702875 and user = 3556 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • davidbgk · 2 ✖

issue 1

  • Allow to set `facets_array` in metadata (like current `facets`) · 2 ✖

author_association 1

  • CONTRIBUTOR · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
996229007 https://github.com/simonw/datasette/issues/1552#issuecomment-996229007 https://api.github.com/repos/simonw/datasette/issues/1552 IC_kwDOBm6k_c47YT-P davidbgk 3556 2021-12-16T22:04:39Z 2021-12-16T22:04:39Z CONTRIBUTOR

Wow, that was fast, thank you so much @simonw !

I'm also not convinced that this configuration syntax is right. It's a bit weird having a "facets" list that can either by column-name-strings or {"type-of-facet": "column-name"} objects. Maybe there's a better design for this?

I agree that it's not ideal, my initial naive approach was to detect if it's an array, like what is done here:

https://github.com/simonw/datasette/blob/2c07327d23d9c5cf939ada9ba4091c1b8b2ba42d/datasette/facets.py#L312-L313

But it requires an extra query to determine the type, which is a bit problematic, especially for big tables I guess.

Taking a look at #510, I wonder if a facet_delimiter should be defined for that kind of columns (that would help our team not to have an intermediary conversion step from foo|bar to ["foo","bar"] for instance).

To be consistent with the --extract-column parameter, maybe an explicit casting/delimiter would be useful: --set-column 'Foo:Array:|'.

Throwing a lot of ideas without knowing the big picture… but sometimes newcomers have superpowers :).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow to set `facets_array` in metadata (like current `facets`) 1078702875  
995296725 https://github.com/simonw/datasette/issues/1552#issuecomment-995296725 https://api.github.com/repos/simonw/datasette/issues/1552 IC_kwDOBm6k_c47UwXV davidbgk 3556 2021-12-15T23:29:32Z 2021-12-15T23:29:32Z CONTRIBUTOR

@simonw thank you for your fast answer and your guidance!

While digging into the code, I found an undocumented way of doing it:

yaml facets: ["Facet for a column", {"array": "Facet for an array"}]

The only remaining problem with that solution is here: https://github.com/simonw/datasette/blob/250db8192cb8aba5eb8cd301ccc2a49525bc3d24/datasette/facets.py#L33

We have:

python type, metadata_config = metadata_config.items()[0]

But it requires to cast the dict_items as a list prior to access the first element:

python type, metadata_config = list(metadata_config.items())[0]

I guess it's an unspotted bug? (I mean, independently of the facets-with-arrays issue.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow to set `facets_array` in metadata (like current `facets`) 1078702875  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);