issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and issue = 1163369515 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • query result page is using 400mb of browser memory 40x size of html page and 400x size of csv data · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1767219901 https://github.com/simonw/datasette/issues/1655#issuecomment-1767219901 https://api.github.com/repos/simonw/datasette/issues/1655 IC_kwDOBm6k_c5pVaK9 fgregg 536941 2023-10-17T21:29:03Z 2023-10-17T21:29:03Z CONTRIBUTOR

@yejiyang why don’t you move this discussion to my fork to spare simon’s notifications 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 query result page is using 400mb of browser memory 40x size of html page and 400x size of csv data 1163369515  
1766994810 https://github.com/simonw/datasette/issues/1655#issuecomment-1766994810 https://api.github.com/repos/simonw/datasette/issues/1655 IC_kwDOBm6k_c5pUjN6 fgregg 536941 2023-10-17T19:01:59Z 2023-10-17T19:01:59Z CONTRIBUTOR

hi @yejiyang, have your tried using my fork of datasette: https://github.com/fgregg/datasette/tree/no_limit_csv_publish

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 query result page is using 400mb of browser memory 40x size of html page and 400x size of csv data 1163369515  
1258166572 https://github.com/simonw/datasette/issues/1655#issuecomment-1258166572 https://api.github.com/repos/simonw/datasette/issues/1655 IC_kwDOBm6k_c5K_hks fgregg 536941 2022-09-26T14:57:04Z 2022-09-26T14:57:04Z CONTRIBUTOR

I think that paginating, even in javascript, could be very helpful. Maybe render json or csv into the page and let javascript loading that into the dom?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 query result page is using 400mb of browser memory 40x size of html page and 400x size of csv data 1163369515  
1062450649 https://github.com/simonw/datasette/issues/1655#issuecomment-1062450649 https://api.github.com/repos/simonw/datasette/issues/1655 IC_kwDOBm6k_c4_U7XZ fgregg 536941 2022-03-09T01:10:46Z 2022-03-09T01:10:46Z CONTRIBUTOR

i increased the max_returned_row, because I have some scripts that get CSVs from this site, and this makes doing pagination of CSVs less annoying for many cases. i know that's streaming csvs is something you are hoping to address in 1.0. let me know if there's anything i can do to help with that.

as for what if anything can be done about the size of the dom, I don't have any ideas right now, but i'll poke around.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 query result page is using 400mb of browser memory 40x size of html page and 400x size of csv data 1163369515  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);