issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR", issue = 991191951 and user = 7476523 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • bobwhitelock · 3 ✖

issue 1

  • clean checkout & clean environment has test failures · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
918621705 https://github.com/simonw/datasette/issues/1464#issuecomment-918621705 https://api.github.com/repos/simonw/datasette/issues/1464 IC_kwDOBm6k_c42wQ4J bobwhitelock 7476523 2021-09-13T22:17:17Z 2021-09-13T22:17:17Z CONTRIBUTOR

haven't had time to get back to this, but idle thought that I'm recording for later investigation: how does the continuous integration handle this installation issue? Is it documented there?

Not certain, but I think tests in CI run on Ubuntu and don't appear to install any additional Sqlite-related dependencies, and so my guess is the version of Sqlite installed by default on Ubuntu has the SQLITE_ENABLE_FTS3_PARENTHESIS option enabled and so doesn't run into this issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 clean checkout & clean environment has test failures 991191951  
915343886 https://github.com/simonw/datasette/issues/1464#issuecomment-915343886 https://api.github.com/repos/simonw/datasette/issues/1464 IC_kwDOBm6k_c42jwoO bobwhitelock 7476523 2021-09-08T15:32:06Z 2021-09-08T15:32:06Z CONTRIBUTOR

Thanks, that does look similar!

Unfortunately, pysqlite3-binary isn't available for Mac OS X, so I can't quickly check that that fixes it; will do so later.

Ah that makes sense, I guess that's why this isn't just always installed already. I wonder if a possible solution to this issue could be doing feature detection on whether this feature is supported by the current Sqlite version, and if not these tests could be disabled locally? But possibly there's a better way to handle this, will see what @simonw thinks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 clean checkout & clean environment has test failures 991191951  
915299013 https://github.com/simonw/datasette/issues/1464#issuecomment-915299013 https://api.github.com/repos/simonw/datasette/issues/1464 IC_kwDOBm6k_c42jlrF bobwhitelock 7476523 2021-09-08T14:40:28Z 2021-09-08T14:40:28Z CONTRIBUTOR

What are the full errors you're getting?

This may be the same issue as described in https://github.com/simonw/datasette/pull/1223 - essentially the test suite (and corresponding Datasette features I assume) are by default implicitly dependent on your Sqlite installation having been compiled with the SQLITE_ENABLE_FTS3_PARENTHESIS option. If this is the same issue then I think this can be fixed either by recompiling with that option or (probably more easily) by running pip install pysqlite3-binary, which will be used in preference to your system Sqlite installation and has this option enabled.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 clean checkout & clean environment has test failures 991191951  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);