issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR" and "updated_at" is on date 2018-05-22 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 3

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
391141391 https://github.com/simonw/datasette/pull/280#issuecomment-391141391 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTE0MTM5MQ== r4vi 565628 2018-05-22T21:08:39Z 2018-05-22T21:08:39Z CONTRIBUTOR

I'm going to clean this up for consistency tomorrow morning so hold off merging until then please

On Tue, May 22, 2018 at 6:34 PM, Simon Willison notifications@github.com wrote:

Yeah let's try this without pysqlite3 and see if we still get the correct version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/simonw/datasette/pull/280#issuecomment-391076458, or mute the thread https://github.com/notifications/unsubscribe-auth/AAihfMI-H6CBt-Py0xdBbH2xDK0KsjT2ks5t1EwYgaJpZM4UI_2m . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  
391077700 https://github.com/simonw/datasette/pull/279#issuecomment-391077700 https://api.github.com/repos/simonw/datasette/issues/279 MDEyOklzc3VlQ29tbWVudDM5MTA3NzcwMA== rgieseke 198537 2018-05-22T17:38:17Z 2018-05-22T17:38:17Z CONTRIBUTOR

Alright, that should work now -- let me know if you would prefer any different behaviour.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add version number support with Versioneer 325352370  
391073267 https://github.com/simonw/datasette/pull/279#issuecomment-391073267 https://api.github.com/repos/simonw/datasette/issues/279 MDEyOklzc3VlQ29tbWVudDM5MTA3MzI2Nw== rgieseke 198537 2018-05-22T17:24:16Z 2018-05-22T17:24:16Z CONTRIBUTOR

Sorry, just realised you rely on version being a module ...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add version number support with Versioneer 325352370  
391073009 https://github.com/simonw/datasette/pull/279#issuecomment-391073009 https://api.github.com/repos/simonw/datasette/issues/279 MDEyOklzc3VlQ29tbWVudDM5MTA3MzAwOQ== rgieseke 198537 2018-05-22T17:23:26Z 2018-05-22T17:23:26Z CONTRIBUTOR

I think I prefer the aesthetics of just "0.22" for the version string if it's a tagged release with no additional changes - does that work?

Yes! That's the default versioneer behaviour.

I'd like to continue to provide a tuple that can be imported from the version.py module as well, as seen here:

Should work now, it can be a two (for a tagged version), three or four items tuple.

``` In [2]: datasette.version Out[2]: '0.12+292.ga70c2a8.dirty'

In [3]: datasette.version_info Out[3]: ('0', '12+292', 'ga70c2a8', 'dirty') ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add version number support with Versioneer 325352370  
391059008 https://github.com/simonw/datasette/pull/280#issuecomment-391059008 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTA1OTAwOA== r4vi 565628 2018-05-22T16:40:27Z 2018-05-22T16:40:27Z CONTRIBUTOR

```python

import sqlite3 sqlite3.sqlite_version '3.23.1'

``` running the above in the container seems to show 3.23.1 too so maybe we don't need pysqlite3 at all?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  
391050113 https://github.com/simonw/datasette/issues/276#issuecomment-391050113 https://api.github.com/repos/simonw/datasette/issues/276 MDEyOklzc3VlQ29tbWVudDM5MTA1MDExMw== russss 45057 2018-05-22T16:13:00Z 2018-05-22T16:13:00Z CONTRIBUTOR

Yup, I'll have a think about it. My current thoughts are for spatialite we'll need to hook into the following places:

  • Inspection, so we can detect which columns are geometry columns. (We also currently ignore spatialite tables during inspection, it may be worth moving that to the plugin as well.)
  • After data load, so we can convert WKB into the correct intermediate format for display. The alternative here is to alter the select SQL itself and get spatialite to do this conversion, but that strikes me as a bit more complex and possibly not as useful.
  • HTML rendering.
  • Querying?

The rendering and querying hooks could also potentially be used to move the units support into a plugin.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Handle spatialite geometry columns better 324835838  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);