issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and user = 51016 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
917642487 https://github.com/simonw/datasette/issues/1464#issuecomment-917642487 https://api.github.com/repos/simonw/datasette/issues/1464 IC_kwDOBm6k_c42shz3 ctb 51016 2021-09-12T14:03:09Z 2021-09-12T14:03:09Z CONTRIBUTOR

haven't had time to get back to this, but idle thought that I'm recording for later investigation: how does the continuous integration handle this installation issue? Is it documented there?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 clean checkout & clean environment has test failures 991191951  
915302885 https://github.com/simonw/datasette/issues/1464#issuecomment-915302885 https://api.github.com/repos/simonw/datasette/issues/1464 IC_kwDOBm6k_c42jmnl ctb 51016 2021-09-08T14:44:50Z 2021-09-08T14:44:50Z CONTRIBUTOR

thanks for the response! full errors attached; excerpt:

``` ...

def test_searchmode(table_metadata, querystring, expected_rows):
    with make_app_client(
        metadata={"databases": {"fixtures": {"tables": {"searchable": table_metadata}}}}
    ) as client:
        response = client.get("/fixtures/searchable.json?" + querystring)

      assert expected_rows == response.json["rows"]

E AssertionError: assert [[1, 'barry c...sel', 'puma']] == [] E Left contains 2 more items, first extra item: [1, 'barry cat', 'terry dog', 'panther'] E Use -v to get the full diff

/Users/t/dev/datasette/tests/test_api.py:1115: AssertionError ```

errors.txt

A quick scan of #1223 suggests you're right. Unfortunately, pysqlite3-binary isn't available for Mac OS X, so I can't quickly check that that fixes it; will do so later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 clean checkout & clean environment has test failures 991191951  
915279711 https://github.com/simonw/datasette/issues/1464#issuecomment-915279711 https://api.github.com/repos/simonw/datasette/issues/1464 IC_kwDOBm6k_c42jg9f ctb 51016 2021-09-08T14:16:49Z 2021-09-08T14:16:49Z CONTRIBUTOR

on commit d57ab156b35ec642

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 clean checkout & clean environment has test failures 991191951  
913001282 https://github.com/simonw/datasette/pull/1455#issuecomment-913001282 https://api.github.com/repos/simonw/datasette/issues/1455 IC_kwDOBm6k_c42a0tC ctb 51016 2021-09-04T16:31:24Z 2021-09-04T16:31:24Z CONTRIBUTOR

I love it! maybe 'researchers' instead? Or 'scientists and researchers'?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add scientists to target groups 988325628  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);