issue_comments

Table actions

4 rows where author_association = "NONE", issue = 334190959 and user = 12617395 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • bsilverm · 4 ✖

issue 1

  • Wildcard support in query parameters · 4 ✖

author_association 1

  • NONE · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
399173916 https://github.com/simonw/datasette/issues/321#issuecomment-399173916 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTE3MzkxNg== bsilverm 12617395 2018-06-21T17:00:10Z 2018-06-21T17:00:10Z NONE

Oh I see.. My issue is that the query executes with an empty string prior to the user submitting the parameters. I'll try adding your workaround to some of my queries. Thanks again,

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  
399129220 https://github.com/simonw/datasette/issues/321#issuecomment-399129220 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTEyOTIyMA== bsilverm 12617395 2018-06-21T14:45:02Z 2018-06-21T14:45:02Z NONE

Those queries look identical. How can this be prevented if the queries are in a metadata.json file?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  
399106871 https://github.com/simonw/datasette/issues/321#issuecomment-399106871 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTEwNjg3MQ== bsilverm 12617395 2018-06-21T13:39:37Z 2018-06-21T13:39:37Z NONE

One thing I've noticed with this approach is that the query is executed with no parameters which I do not believe was the case previously. In the case the table contains a lot of data, this adds some time executing the query before the user can enter their input and run it with the parameters they want.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  
399098080 https://github.com/simonw/datasette/issues/321#issuecomment-399098080 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTA5ODA4MA== bsilverm 12617395 2018-06-21T13:10:48Z 2018-06-21T13:10:48Z NONE

Perfect, thank you!!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);