issue_comments

Table actions

3 rows where author_association = "NONE", issue = 396212021 and "updated_at" is on date 2019-12-18 sorted by updated_at descending

✖
✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • base_url configuration setting · 3 ✖

author_association 1

  • NONE · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
567219479 https://github.com/simonw/datasette/issues/394#issuecomment-567219479 https://api.github.com/repos/simonw/datasette/issues/394 MDEyOklzc3VlQ29tbWVudDU2NzIxOTQ3OQ== terrycojones 132978 2019-12-18T21:24:23Z 2019-12-18T21:24:23Z NONE

@simonw What about allowing a base url. The <base>....</base> tag has been around forever. Then just use all relative URLs, which I guess is likely what you already do. See https://www.w3schools.com/TAGs/tag_base.asp

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url configuration setting 396212021  
567128636 https://github.com/simonw/datasette/issues/394#issuecomment-567128636 https://api.github.com/repos/simonw/datasette/issues/394 MDEyOklzc3VlQ29tbWVudDU2NzEyODYzNg== terrycojones 132978 2019-12-18T17:19:46Z 2019-12-18T17:19:46Z NONE

Hmmm, wait, maybe my mindless (copy/paste) use of proxy_redirect is causing me grief...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url configuration setting 396212021  
567127981 https://github.com/simonw/datasette/issues/394#issuecomment-567127981 https://api.github.com/repos/simonw/datasette/issues/394 MDEyOklzc3VlQ29tbWVudDU2NzEyNzk4MQ== terrycojones 132978 2019-12-18T17:18:06Z 2019-12-18T17:18:06Z NONE

Agreed, this would be nice to have. I'm currently working around it in nginx with additional location blocks:

```

location /datasette/ {
    proxy_pass         http://127.0.0.1:8001/;
    proxy_redirect     off;
    include proxy_params;
}

location /dna-protein-genome/ {
    proxy_pass         http://127.0.0.1:8001/dna-protein-genome/;
    proxy_redirect     off;
    include proxy_params;
}

location /rna-protein-genome/ {
    proxy_pass         http://127.0.0.1:8001/rna-protein-genome/;
    proxy_redirect     off;
    include proxy_params;
}

```

The 2nd and 3rd above are my databases. This works, but I have a small problem with URLs like /rna-protein-genome?params.... that I could fix with some more nginx munging. I seem to do this sort of thing once every 5 years and then have to look it all up again.

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url configuration setting 396212021  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);