home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where author_association = "NONE" and "updated_at" is on date 2021-08-24 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date)

issue 4

  • [Enhancement] Please allow 'insert-files' to insert content as text. 3
  • SQLite does not have case sensitive columns 1
  • Make sure that case-insensitive column names are unique 1
  • Ability to insert file contents as text, in addition to blob 1

user 3

  • pjamargh 3
  • FabianHertwig 2
  • codecov[bot] 1

author_association 1

  • NONE · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
905022931 https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905022931 https://api.github.com/repos/simonw/sqlite-utils/issues/321 IC_kwDOCGYnMM418Y3T codecov[bot] 22429695 2021-08-24T22:38:38Z 2021-08-24T23:27:26Z NONE

Codecov Report

Merging #321 (db2dd6d) into main (9258f4b) will increase coverage by 0.16%. The diff coverage is 100.00%.

```diff @@ Coverage Diff @@

main #321 +/-

========================================== + Coverage 96.41% 96.58% +0.16%
========================================== Files 5 5
Lines 2206 2223 +17
========================================== + Hits 2127 2147 +20
+ Misses 79 76 -3
```

| Impacted Files | Coverage Δ | | |---|---|---| | sqlite_utils/cli.py | 95.69% <100.00%> (+0.42%) | :arrow_up: |


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9258f4b...db2dd6d. Read the comment docs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to insert file contents as text, in addition to blob 978537855  
905024066 https://github.com/simonw/sqlite-utils/issues/319#issuecomment-905024066 https://api.github.com/repos/simonw/sqlite-utils/issues/319 IC_kwDOCGYnMM418ZJC pjamargh 66709385 2021-08-24T22:41:39Z 2021-08-24T22:41:39Z NONE

I'm happy with this functionality left the way you describe. In my case the data is homogeneous but other cases would work just by being consistent on the encoding. Thanks a lot, Simon!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
[Enhancement] Please allow 'insert-files' to insert content as text. 976399638  
905021010 https://github.com/simonw/sqlite-utils/issues/319#issuecomment-905021010 https://api.github.com/repos/simonw/sqlite-utils/issues/319 IC_kwDOCGYnMM418YZS pjamargh 66709385 2021-08-24T22:33:42Z 2021-08-24T22:33:42Z NONE

Oh, I misread. Yes some files will not be valid UTF-8, I'd throw a warning and continue (not adding that file) but if you want to get more elaborate you could allow to define a policy on what to do. Not adding the file, index binary content or use a conversion policy like the ones available on Python's decode.

From https://stackoverflow.com/questions/24616678/unicodedecodeerror-in-python-when-reading-a-file-how-to-ignore-the-error-and-ju : - 'ignore' ignores errors. Note that ignoring encoding errors can lead to data loss. - 'replace' causes a replacement marker (such as '?') to be inserted where there is malformed data. - 'surrogateescape' will represent any incorrect bytes as code points in the Unicode Private Use Area ranging from U+DC80 to U+DCFF. These private code points will then be turned back into the same bytes when the surrogateescape error handler is used when writing data. This is useful for processing files in an unknown encoding. - 'xmlcharrefreplace' is only supported when writing to a file. Characters not supported by the encoding are replaced with the appropriate XML character reference &#nnn;. - 'backslashreplace' (also only supported when writing) replaces unsupported characters with Python’s backslashed escape sequences.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
[Enhancement] Please allow 'insert-files' to insert content as text. 976399638  
905003381 https://github.com/simonw/sqlite-utils/issues/319#issuecomment-905003381 https://api.github.com/repos/simonw/sqlite-utils/issues/319 IC_kwDOCGYnMM418UF1 pjamargh 66709385 2021-08-24T21:56:49Z 2021-08-24T21:56:49Z NONE

I was thinking that an approach could be making FILE_COLUMNS a generator (_get_file_columns(mode)) or you can just have a different set of columns (is there something else that makes sense to be changed on the text scenario?).

About UTF-8 I was referring to the encoding to use when reading files. This can be difficult to auto-detect but I believe that UTF-8 is pretty much the standard for text files.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
[Enhancement] Please allow 'insert-files' to insert content as text. 976399638  
904642396 https://github.com/dogsheep/healthkit-to-sqlite/pull/13#issuecomment-904642396 https://api.github.com/repos/dogsheep/healthkit-to-sqlite/issues/13 IC_kwDOC8tyDs41679c FabianHertwig 32016596 2021-08-24T13:27:40Z 2021-08-24T13:28:26Z NONE

This would fix #21 and make #22 obsolete.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
SQLite does not have case sensitive columns 743071410  
904641261 https://github.com/dogsheep/healthkit-to-sqlite/pull/22#issuecomment-904641261 https://api.github.com/repos/dogsheep/healthkit-to-sqlite/issues/22 IC_kwDOC8tyDs4167rt FabianHertwig 32016596 2021-08-24T13:26:20Z 2021-08-24T13:26:20Z NONE

Did not see that #13 fixes the same issue in a similar way. You can decide which one to merge ;)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Make sure that case-insensitive column names are unique 978086284  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 1009.488ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows