issue_comments

Table actions

3 rows where author_association = "OWNER", "created_at" is on date 2019-09-02 and "updated_at" is on date 2019-09-02 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date)

user 1

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
527258212 https://github.com/simonw/sqlite-utils/pull/57#issuecomment-527258212 https://api.github.com/repos/simonw/sqlite-utils/issues/57 MDEyOklzc3VlQ29tbWVudDUyNzI1ODIxMg== simonw 9599 2019-09-02T23:40:56Z 2019-09-02T23:40:56Z OWNER

This is fantastic, thanks so much.

I spotted a Datasette bug triggered by this: Datasette has its own version of the detect_fts function - at https://github.com/simonw/datasette/blob/d224ee2c98ac39c2c6e21a0ac0c62e5c3e1ccd11/datasette/utils/init.py#L466-L479 - which fails to pick up FTS tables created using the new escaping pattern.

It's a bug in Datasette, not sqlite-utils - so I'll open an issue there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add triggers while enabling FTS 487987958  
527091278 https://github.com/simonw/sqlite-utils/pull/57#issuecomment-527091278 https://api.github.com/repos/simonw/sqlite-utils/issues/57 MDEyOklzc3VlQ29tbWVudDUyNzA5MTI3OA== simonw 9599 2019-09-02T10:13:32Z 2019-09-02T10:13:32Z OWNER

This is brilliant!

One tiny suggestion: I like --create-triggers and create_triggers=True better for this as they are shorter but still capture what it dies - especially since the underlying SQL uses CREATE TRIGGER statements.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add triggers while enabling FTS 487987958  
527090411 https://github.com/simonw/sqlite-utils/pull/56#issuecomment-527090411 https://api.github.com/repos/simonw/sqlite-utils/issues/56 MDEyOklzc3VlQ29tbWVudDUyNzA5MDQxMQ== simonw 9599 2019-09-02T10:10:48Z 2019-09-02T10:10:48Z OWNER

Good spot, thanks!

Would be useful to add a test as well, derived from your above example.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Escape the table name in populate_fts and search. 487847945  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);