issue_comments
27 rows where author_association = "OWNER", "created_at" is on date 2020-02-14 and "updated_at" is on date 2020-02-14 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: issue_url, created_at (date)
user 1
- simonw 27
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
586455321 | https://github.com/simonw/datasette/issues/673#issuecomment-586455321 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ1NTMyMQ== | simonw 9599 | 2020-02-14T20:13:59Z | 2020-02-14T20:13:59Z | OWNER | Closing this in favour of rethinking how sanity checks work. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586454371 | https://github.com/simonw/datasette/issues/673#issuecomment-586454371 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ1NDM3MQ== | simonw 9599 | 2020-02-14T20:11:02Z | 2020-02-14T20:11:02Z | OWNER | The technique from |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586450571 | https://github.com/simonw/datasette/issues/673#issuecomment-586450571 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ1MDU3MQ== | simonw 9599 | 2020-02-14T19:59:41Z | 2020-02-14T20:01:14Z | OWNER | This helped:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586449286 | https://github.com/simonw/datasette/issues/673#issuecomment-586449286 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0OTI4Ng== | simonw 9599 | 2020-02-14T19:56:00Z | 2020-02-14T19:57:17Z | OWNER | I tried to make the smallest SpatiaLite database file I could (to use for the tests), but it ended up over 5MB!
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586448292 | https://github.com/simonw/datasette/issues/673#issuecomment-586448292 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0ODI5Mg== | simonw 9599 | 2020-02-14T19:53:05Z | 2020-02-14T19:53:05Z | OWNER | I may be re-inventing this code at the moment: https://github.com/simonw/datasette/blob/3ffb8f3b98252531d11897fd431711e9b8045ace/datasette/app.py#L219-L237 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586445210 | https://github.com/simonw/datasette/issues/673#issuecomment-586445210 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0NTIxMA== | simonw 9599 | 2020-02-14T19:44:27Z | 2020-02-14T19:44:27Z | OWNER | For the unit tests I think I'm going to have to create minimal binary SQLite file examples and include them in the repo. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586444970 | https://github.com/simonw/datasette/issues/673#issuecomment-586444970 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0NDk3MA== | simonw 9599 | 2020-02-14T19:43:46Z | 2020-02-14T19:43:46Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586444835 | https://github.com/simonw/datasette/issues/673#issuecomment-586444835 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0NDgzNQ== | simonw 9599 | 2020-02-14T19:43:27Z | 2020-02-14T19:43:27Z | OWNER | I can extend this function (maybe also rename it): https://github.com/simonw/datasette/blob/52ba34701cdbf510236de87d35b0e6df330626d1/datasette/utils/init.py#L595-L610 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586443837 | https://github.com/simonw/datasette/issues/673#issuecomment-586443837 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0MzgzNw== | simonw 9599 | 2020-02-14T19:40:42Z | 2020-02-14T19:41:56Z | OWNER | Here's how to test if the
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586442978 | https://github.com/simonw/datasette/issues/673#issuecomment-586442978 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0Mjk3OA== | simonw 9599 | 2020-02-14T19:38:19Z | 2020-02-14T19:38:19Z | OWNER | Amazingly, I get 0 search results on Google for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586442292 | https://github.com/simonw/datasette/issues/673#issuecomment-586442292 | https://api.github.com/repos/simonw/datasette/issues/673 | MDEyOklzc3VlQ29tbWVudDU4NjQ0MjI5Mg== | simonw 9599 | 2020-02-14T19:36:37Z | 2020-02-14T19:36:37Z | OWNER | This can be a function in |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for checking if a SQLite database file is safe to open 565518772 | |
586441484 | https://github.com/simonw/datasette/pull/672#issuecomment-586441484 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjQ0MTQ4NA== | simonw 9599 | 2020-02-14T19:34:25Z | 2020-02-14T19:34:25Z | OWNER | I've figured out how to tell if a database is safe to open or not:
Run this against a SpatiaLite database and you get the following:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586112662 | https://github.com/simonw/datasette/pull/672#issuecomment-586112662 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjExMjY2Mg== | simonw 9599 | 2020-02-14T06:05:27Z | 2020-02-14T06:05:27Z | OWNER | It think the fix is to use an old-fashioned |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586111619 | https://github.com/simonw/datasette/pull/672#issuecomment-586111619 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjExMTYxOQ== | simonw 9599 | 2020-02-14T06:01:24Z | 2020-02-14T06:01:24Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | ||
586111102 | https://github.com/simonw/datasette/pull/672#issuecomment-586111102 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjExMTEwMg== | simonw 9599 | 2020-02-14T05:59:24Z | 2020-02-14T06:00:36Z | OWNER | Interesting new problem: hitting Ctrl+C no longer terminates the problem provided that https://stackoverflow.com/questions/49992329/the-workers-in-threadpoolexecutor-is-not-really-daemon has clues. The workers are only meant to exit when their worker queues are empty. But... I want to run the worker every 10 seconds. How do I do that without having it loop forever and hence never quit? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586109784 | https://github.com/simonw/datasette/pull/672#issuecomment-586109784 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjEwOTc4NA== | simonw 9599 | 2020-02-14T05:53:50Z | 2020-02-14T05:54:21Z | OWNER | ... cheating like this seems to work:
Seems to work in my testing. Wish I could prove it with a unit test though. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586109238 | https://github.com/simonw/datasette/pull/672#issuecomment-586109238 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjEwOTIzOA== | simonw 9599 | 2020-02-14T05:51:12Z | 2020-02-14T05:51:12Z | OWNER | ... or maybe I can cheat and wrap the access to |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586109032 | https://github.com/simonw/datasette/pull/672#issuecomment-586109032 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjEwOTAzMg== | simonw 9599 | 2020-02-14T05:50:15Z | 2020-02-14T05:50:15Z | OWNER | So I need to ensure the Mainly I need to ensure that it is locked during iterations over it, then unlocked at the end. Trickiest part is probably ensuring there is a test that proves this is working - I feel like I got lucky encountering that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586107989 | https://github.com/simonw/datasette/pull/672#issuecomment-586107989 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjEwNzk4OQ== | simonw 9599 | 2020-02-14T05:45:12Z | 2020-02-14T05:45:12Z | OWNER | I tried running the Makes sense - I had a thread that added an item to that dictionary right while the homepage was attempting to run this code: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586069529 | https://github.com/simonw/datasette/pull/672#issuecomment-586069529 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjA2OTUyOQ== | simonw 9599 | 2020-02-14T02:37:17Z | 2020-02-14T02:37:17Z | OWNER | Another problem: if any of the found databases use SpatiaLite then Datasette will fail to start at all. It should skip them instead. The |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586068095 | https://github.com/simonw/datasette/pull/672#issuecomment-586068095 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjA2ODA5NQ== | simonw 9599 | 2020-02-14T02:30:37Z | 2020-02-14T02:30:46Z | OWNER | This can take a LONG time to run, and at the moment it's blocking and prevents Datasette from starting up. It would be much better if this ran in a thread, or an asyncio task. Probably have to be a thread because there's no easy |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586067794 | https://github.com/simonw/datasette/pull/672#issuecomment-586067794 | https://api.github.com/repos/simonw/datasette/issues/672 | MDEyOklzc3VlQ29tbWVudDU4NjA2Nzc5NA== | simonw 9599 | 2020-02-14T02:29:16Z | 2020-02-14T02:29:16Z | OWNER | One design issue: how to pick neat unique names for database files in a file hierarchy? Here's what I have so far: For these files:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--dirs option for scanning directories for SQLite databases 565064079 | |
586066798 | https://github.com/simonw/datasette/issues/417#issuecomment-586066798 | https://api.github.com/repos/simonw/datasette/issues/417 | MDEyOklzc3VlQ29tbWVudDU4NjA2Njc5OA== | simonw 9599 | 2020-02-14T02:24:54Z | 2020-02-14T02:24:54Z | OWNER | I'm going to move this over to a draft pull request. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Library 421546944 | |
586065843 | https://github.com/simonw/datasette/issues/417#issuecomment-586065843 | https://api.github.com/repos/simonw/datasette/issues/417 | MDEyOklzc3VlQ29tbWVudDU4NjA2NTg0Mw== | simonw 9599 | 2020-02-14T02:20:53Z | 2020-02-14T02:20:53Z | OWNER | MVP for this feature: just do it once on startup, don't scan for new files every X seconds. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Library 421546944 | |
586047525 | https://github.com/simonw/datasette/issues/417#issuecomment-586047525 | https://api.github.com/repos/simonw/datasette/issues/417 | MDEyOklzc3VlQ29tbWVudDU4NjA0NzUyNQ== | simonw 9599 | 2020-02-14T01:03:43Z | 2020-02-14T01:59:02Z | OWNER | OK, I have a plan. I'm going to try and implement this is a core Datasette feature (no plugins) with the following design:
To check if a file is valid SQLite, Datasette will first check if the first few bytes of the file are |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Library 421546944 | |
586054154 | https://github.com/simonw/datasette/issues/671#issuecomment-586054154 | https://api.github.com/repos/simonw/datasette/issues/671 | MDEyOklzc3VlQ29tbWVudDU4NjA1NDE1NA== | simonw 9599 | 2020-02-14T01:30:35Z | 2020-02-14T01:30:35Z | OWNER | Documented here: https://datasette.readthedocs.io/en/latest/datasette.html |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.add_database(name, db) and datasette.remove_database(name) methods 565041624 | |
586047995 | https://github.com/simonw/datasette/issues/417#issuecomment-586047995 | https://api.github.com/repos/simonw/datasette/issues/417 | MDEyOklzc3VlQ29tbWVudDU4NjA0Nzk5NQ== | simonw 9599 | 2020-02-14T01:05:20Z | 2020-02-14T01:05:20Z | OWNER | I'm going to add two methods to the Datasette class to help support this work (and to enable exciting new plugin opportunities in the future):
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Library 421546944 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 4