issue_comments

When I figure this out I'll update the https://github.com/simonw/datasette-plugin/blob/main/datasette-%7B%7Bcookiecutter.hyphenated%7D%7D/.github/workflows/publish.yml default workflow to do this - right now it runs the tests once on just a single version of Python as part of the package deploy to PyPI step.

https://docs.github.com/en/actions/getting-started-with-github-actions/core-concepts-for-github-actions#job

A set of steps that execute on the same runner. You can define the dependency rules for how jobs run in a workflow file. Jobs can run at the same time in parallel or run sequentially depending on the status of a previous job. For example, a workflow can have two sequential jobs that build and test code, where the test job is dependent on the status of the build job. If the build job fails, the test job will not run.

I'd like to set these up as different workflows that depend on each other, if that's possible.

I want to start three test runs in parallel (on three different Python versions), then if all three pass kick off the PyPI push (without running more tests), then if that passes do the Docker build and push.

Demo of the fix: https://latest.datasette.io/fixtures/binary_data.json?_sort_desc=data&_shape=array&_nl=on

{"rowid": 2, "data": {"$base64": true, "encoded": "FRwDx60F/g=="}} {"rowid": 1, "data": {"$base64": true, "encoded": "FRwCx60F/g=="}}

I need to figure out how to build and push the Docker image on releases. Here's the Travis code for that: https://github.com/simonw/datasette/blob/52eabb019d4051084b21524bd0fd9c2731126985/.travis.yml#L38-L47

Documentation: https://github.com/simonw/datasette/blob/3a4c8ed36aa97211e46849d32a09f2f386f342dd/docs/plugin_hooks.rst#extra-template-vars-template-database-table-columns-view-name-request-datasette

extra_tenplate_vars should he documented first and should be the only one to document the arguments and the async return feature. Others should refer back to it rather than duplicating that.

Docs also need to note that request may be None for all of these hooks.

And the docs need to be updated too.

Also: they should all be able to return async def inner functions. At the moment only extra_template_vars supports that pattern.

I'm going to implement this first as a single commit, then implement columns from #938 as a separate change.

They should also be next to each other in the documentation - right now they're a bit scattered in terms of page order:

They should all take:

template, database, table, view_name, request, datasette, columns

columns is new, see #938.

Four plugin hooks need this extra columns argument:

• extra_css_urls(template, database, table, datasette)
• extra_js_urls(template, database, table, datasette)
• extra_body_script(template, database, table, view_name, datasette)
• extra_template_vars(template, database, table, view_name, request, datasette)

It's weird that these take different arguments. I should fix that too.