issue_comments

Table actions

5 rows where author_association = "OWNER", "created_at" is on date 2020-10-26 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • simonw · 5 ✖

author_association 1

  • OWNER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
716756103 https://github.com/simonw/sqlite-utils/pull/189#issuecomment-716756103 https://api.github.com/repos/simonw/sqlite-utils/issues/189 MDEyOklzc3VlQ29tbWVudDcxNjc1NjEwMw== simonw 9599 2020-10-26T18:56:19Z 2020-10-26T18:56:19Z OWNER

This is a great fix, thanks! If you add a unit test somewhere in here I'll merge the PR: https://github.com/simonw/sqlite-utils/blob/main/tests/test_m2m.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow iterables other than Lists in m2m records 729818242  
716681602 https://github.com/simonw/datasette/issues/1051#issuecomment-716681602 https://api.github.com/repos/simonw/datasette/issues/1051 MDEyOklzc3VlQ29tbWVudDcxNjY4MTYwMg== simonw 9599 2020-10-26T16:51:58Z 2020-10-26T16:51:58Z OWNER

I still need to improve the current binary display on the query page though, where it outputs a Python b'...' literal.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Better display of binary data on arbitrary query results page 729096595  
716681167 https://github.com/simonw/datasette/issues/1051#issuecomment-716681167 https://api.github.com/repos/simonw/datasette/issues/1051 MDEyOklzc3VlQ29tbWVudDcxNjY4MTE2Nw== simonw 9599 2020-10-26T16:51:15Z 2020-10-26T16:51:15Z OWNER

Crazy idea: generate a signed URL containing a base64 of the gzip of the binary content (to try and reduce size).

No: this will blow through URL limits in various hosting providers and possibly even browsers. It could be made to work a little bit more reliably with some extra JavaScript that turns it into a download on the browser-side, but that would be hideously complicated.

Also the signed bit doesn't prevent people from generating SQL queries that generate nasty binary blobs for download.

I'm beginning to think that restricting this feature to just table view, not query view, is a better idea. Query view can still get at the binary using JSON and base64.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Better display of binary data on arbitrary query results page 729096595  
716305890 https://github.com/simonw/datasette/issues/976#issuecomment-716305890 https://api.github.com/repos/simonw/datasette/issues/976 MDEyOklzc3VlQ29tbWVudDcxNjMwNTg5MA== simonw 9599 2020-10-26T05:07:10Z 2020-10-26T05:07:10Z OWNER

I used the new datasette.urls methods to handle escaping table names.

https://github.com/simonw/datasette/blob/f5dbe61a4568c0915ec6be820095c2960cf0857c/datasette/utils/init.py#L996-L1008

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Idea: -o could open to a more convenient location 708289783  
716265360 https://github.com/simonw/datasette/issues/1052#issuecomment-716265360 https://api.github.com/repos/simonw/datasette/issues/1052 MDEyOklzc3VlQ29tbWVudDcxNjI2NTM2MA== simonw 9599 2020-10-26T02:17:58Z 2020-10-26T02:17:58Z OWNER

The default z-index values for Leaflet are defined here: https://github.com/Leaflet/Leaflet/blob/b346bb8bf7bb80899baa1f4fc1536bae58e7e3e6/dist/leaflet.css#L81-L91

```css .leaflet-pane { z-index: 400; }

.leaflet-tile-pane { z-index: 200; } .leaflet-overlay-pane { z-index: 400; } .leaflet-shadow-pane { z-index: 500; } .leaflet-marker-pane { z-index: 600; } .leaflet-tooltip-pane { z-index: 650; } .leaflet-popup-pane { z-index: 700; }

.leaflet-map-pane canvas { z-index: 100; } .leaflet-map-pane svg { z-index: 200; } `` So az-index` of 1000 on the menu should fix this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Column action menu overlapped by Leaflet maps 729183332  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);