issue_comments

Table actions

4 rows where author_association = "OWNER", "created_at" is on date 2022-11-16 and issue = 1448143294 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Autocomplete text entry for filter values that correspond to facets · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1316262169 https://github.com/simonw/datasette/issues/1890#issuecomment-1316262169 https://api.github.com/repos/simonw/datasette/issues/1890 IC_kwDOBm6k_c5OdJEZ simonw 9599 2022-11-16T03:22:40Z 2022-11-16T03:22:40Z OWNER

Actually this works as it should in desktop Safari:

I'm going to just put up with the weird behaviour in Mobile Safari.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Autocomplete text entry for filter values that correspond to facets 1448143294  
1316242752 https://github.com/simonw/datasette/issues/1890#issuecomment-1316242752 https://api.github.com/repos/simonw/datasette/issues/1890 IC_kwDOBm6k_c5OdEVA simonw 9599 2022-11-16T03:10:52Z 2022-11-16T03:12:47Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Autocomplete text entry for filter values that correspond to facets 1448143294  
1316240839 https://github.com/simonw/datasette/issues/1890#issuecomment-1316240839 https://api.github.com/repos/simonw/datasette/issues/1890 IC_kwDOBm6k_c5OdD3H simonw 9599 2022-11-16T03:09:11Z 2022-11-16T03:09:11Z OWNER

Here's a polyfill for <datalist>: https://github.com/mfranzke/datalist-polyfill

It shouldn't be necessary now that Safari has shipped support (apparently added in https://developer.apple.com/documentation/safari-release-notes/safari-12_1-release-notes#3130314 Safari 12.1 in March 2019).

But it does look like Safari doesn't support differing label and value attributes, though documentation about this is hard to come by.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Autocomplete text entry for filter values that correspond to facets 1448143294  
1316233532 https://github.com/simonw/datasette/issues/1890#issuecomment-1316233532 https://api.github.com/repos/simonw/datasette/issues/1890 IC_kwDOBm6k_c5OdCE8 simonw 9599 2022-11-16T03:00:58Z 2022-11-16T03:00:58Z OWNER

Oops, introduced a test failure:

``` def test_table_html_foreign_key_facets(app_client): response = app_client.get( "/fixtures/foreign_key_references?_facet=foreign_key_with_blank_label" ) assert response.status == 200

  assert (
        '<li><a href="http://localhost/fixtures/foreign_key_references?_facet=foreign_key_with_blank_label&amp;foreign_key_with_blank_label=3">'
        "-</a> 1</li>"
    ) in response.text

E assert '

  • - 1
    • ' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures: foreign_key_references: 2 rows</title>\n <link rel="styleshe.../script>\n\n\n<!-- Templates considered: table-fixtures-foreign_key_references.html, *table.html -->\n</body>\n</html>' E + where '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures: foreign_key_references: 2 rows</title>\n <link rel="styleshe.../script>\n\n\n\n</body>\n</html>' = <datasette.utils.testing.TestResponse object at 0x7fd1b0080640>.text ``` Need to fix this test:

    https://github.com/simonw/datasette/blob/eac028d3f77aa5473a5fcf59240635a1bca80f7d/tests/test_table_html.py#L616-L624

    		 
    {
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    		 Autocomplete text entry for filter values that correspond to facets 1448143294  

    Advanced export

    JSON shape: default, array, newline-delimited, object

    CSV options: 

    CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);