issue_comments

Table actions

7 rows where author_association = "OWNER" and "created_at" is on date 2023-01-09 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

author_association 1

  • OWNER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1375801928 https://github.com/simonw/datasette/issues/979#issuecomment-1375801928 https://api.github.com/repos/simonw/datasette/issues/979 IC_kwDOBm6k_c5SARJI simonw 9599 2023-01-09T15:32:22Z 2023-01-09T15:32:22Z OWNER

This will not be part of the new default JSON design. It will be handled by an ?_extra instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Default table view JSON should include CREATE TABLE 710650633  
1375800361 https://github.com/simonw/datasette/issues/1558#issuecomment-1375800361 https://api.github.com/repos/simonw/datasette/issues/1558 IC_kwDOBm6k_c5SAQwp simonw 9599 2023-01-09T15:31:17Z 2023-01-09T15:31:17Z OWNER

Related: - #782 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign `facet_results` JSON structure prior to Datasette 1.0 1082584499  
1375797856 https://github.com/simonw/datasette/issues/1983#issuecomment-1375797856 https://api.github.com/repos/simonw/datasette/issues/1983 IC_kwDOBm6k_c5SAQJg simonw 9599 2023-01-09T15:29:34Z 2023-01-09T15:29:34Z OWNER

I had forgotten this had special handling for cursors!

The default representation of a row as a tuple rather than a dictionary might not be the right thing to do based on: - #782 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make CustomJSONEncoder a documented public API 1525815985  
1375795441 https://github.com/simonw/datasette/issues/1983#issuecomment-1375795441 https://api.github.com/repos/simonw/datasette/issues/1983 IC_kwDOBm6k_c5SAPjx simonw 9599 2023-01-09T15:27:53Z 2023-01-09T15:27:53Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make CustomJSONEncoder a documented public API 1525815985  
1375142205 https://github.com/simonw/datasette/issues/1981#issuecomment-1375142205 https://api.github.com/repos/simonw/datasette/issues/1981 IC_kwDOBm6k_c5R9wE9 simonw 9599 2023-01-09T06:05:44Z 2023-01-09T06:05:44Z OWNER

I want the labels to take as much space as they need, but line up with each other.

If they are more than half the width of the page then the form fields should break to another line.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Canned query field labels truncated 1524983536  
1375062405 https://github.com/simonw/datasette/issues/1980#issuecomment-1375062405 https://api.github.com/repos/simonw/datasette/issues/1980 IC_kwDOBm6k_c5R9cmF simonw 9599 2023-01-09T03:23:53Z 2023-01-09T03:23:53Z OWNER

Some potential solutions: - Make it so the primary key is always sortable - not a bad idea, the sortable_columns thing was designed to protect against sorting GIANT tables by a non-indexed column, and the primary key always has an index - Make sure that <select> menu never includes keys that cannot be sorted - this would be a good fix anyway.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Cannot sort table by id" when sortable_columns is used 1524867951  
1375061747 https://github.com/simonw/datasette/issues/1980#issuecomment-1375061747 https://api.github.com/repos/simonw/datasette/issues/1980 IC_kwDOBm6k_c5R9cbz simonw 9599 2023-01-09T03:22:36Z 2023-01-09T03:22:36Z OWNER

The problem here is that the HTML ended up with this HTML in it: html <select name="_sort" id="sort_by"> <option value="">Sort...</option> <option value="id" selected>Sort by id</option> But id is not a valid sort option any more.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Cannot sort table by id" when sortable_columns is used 1524867951  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);