home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where author_association = "OWNER" and issue = 1055402144 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 6

issue 1

  • New pattern for async view classes · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
971056169 https://github.com/simonw/datasette/pull/1512#issuecomment-971056169 https://api.github.com/repos/simonw/datasette/issues/1512 IC_kwDOBm6k_c454SQp simonw 9599 2021-11-17T01:39:44Z 2021-11-17T01:39:44Z OWNER

Closing this PR because I shipped the code in it as a separate library instead.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
New pattern for async view classes 1055402144  
971055677 https://github.com/simonw/datasette/pull/1512#issuecomment-971055677 https://api.github.com/repos/simonw/datasette/issues/1512 IC_kwDOBm6k_c454SI9 simonw 9599 2021-11-17T01:39:25Z 2021-11-17T01:39:25Z OWNER

https://github.com/simonw/asyncinject version 0.1a0 is now live on PyPI: https://pypi.org/project/asyncinject/

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
New pattern for async view classes 1055402144  
971010724 https://github.com/simonw/datasette/pull/1512#issuecomment-971010724 https://api.github.com/repos/simonw/datasette/issues/1512 IC_kwDOBm6k_c454HKk simonw 9599 2021-11-17T01:12:22Z 2021-11-17T01:12:22Z OWNER

I'm going to extract out the asyncinject stuff into a separate library.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
New pattern for async view classes 1055402144  
970861628 https://github.com/simonw/datasette/pull/1512#issuecomment-970861628 https://api.github.com/repos/simonw/datasette/issues/1512 IC_kwDOBm6k_c453iw8 simonw 9599 2021-11-16T23:46:07Z 2021-11-16T23:46:07Z OWNER

I made the changes locally and tested them with Python 3.6 like so: cd /tmp mkdir v cd v pipenv shell --python=python3.6 cd ~/Dropbox/Development/datasette pip install -e '.[test]' pytest tests/test_asyncdi.py

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
New pattern for async view classes 1055402144  
970857411 https://github.com/simonw/datasette/pull/1512#issuecomment-970857411 https://api.github.com/repos/simonw/datasette/issues/1512 IC_kwDOBm6k_c453hvD simonw 9599 2021-11-16T23:43:21Z 2021-11-16T23:43:21Z OWNER

E File "/home/runner/work/datasette/datasette/datasette/utils/vendored_graphlib.py", line 56 E if (result := self._node2info.get(node)) is None: E ^ E SyntaxError: invalid syntax Oh no - the vendored code I use has := so doesn't work on Python 3.6! Will have to backport it more thoroughly.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
New pattern for async view classes 1055402144  
970718337 https://github.com/simonw/datasette/pull/1512#issuecomment-970718337 https://api.github.com/repos/simonw/datasette/issues/1512 IC_kwDOBm6k_c452_yB simonw 9599 2021-11-16T22:02:30Z 2021-11-16T22:02:30Z OWNER

I've decided to make the clever asyncio dependency injection opt-in - so you can either decorate with @inject or you can set inject_all = True on the class - for example: ```python import asyncio from datasette.utils.asyncdi import AsyncBase, inject

class Simple(AsyncBase): def init(self): self.log = []

@inject
async def two(self):
    self.log.append("two")

@inject
async def one(self, two):
    self.log.append("one")
    return self.log

async def not_inject(self, one, two):
    return one + two

class Complex(AsyncBase): inject_all = True

def __init__(self):
    self.log = []

async def b(self):
    self.log.append("b")

async def a(self, b):
    self.log.append("a")

async def go(self, a):
    self.log.append("go")
    return self.log

```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
New pattern for async view classes 1055402144  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 115.78ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows