issue_comments

Table actions

7 rows where author_association = "OWNER", issue = 1087931918 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • simonw · 7 ✖

issue 1

  • `.execute_write(... block=True)` should be the default behaviour · 7 ✖

author_association 1

  • OWNER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1000485719 https://github.com/simonw/datasette/issues/1579#issuecomment-1000485719 https://api.github.com/repos/simonw/datasette/issues/1579 IC_kwDOBm6k_c47ojNX simonw 9599 2021-12-23T19:19:45Z 2021-12-23T19:19:45Z OWNER

All of those removed block=True lines in 8c401ee0f054de2f568c3a8302c9223555146407 really help confirm to me that this was a good decision.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `.execute_write(... block=True)` should be the default behaviour 1087931918  
1000485505 https://github.com/simonw/datasette/issues/1579#issuecomment-1000485505 https://api.github.com/repos/simonw/datasette/issues/1579 IC_kwDOBm6k_c47ojKB simonw 9599 2021-12-23T19:19:13Z 2021-12-23T19:19:13Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `.execute_write(... block=True)` should be the default behaviour 1087931918  
1000481686 https://github.com/simonw/datasette/issues/1579#issuecomment-1000481686 https://api.github.com/repos/simonw/datasette/issues/1579 IC_kwDOBm6k_c47oiOW simonw 9599 2021-12-23T19:09:23Z 2021-12-23T19:09:23Z OWNER

Re-opening this because I missed updating some of the docs, and I also need to update Datasette's own code to not use block=True in a bunch of places.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `.execute_write(... block=True)` should be the default behaviour 1087931918  
1000479737 https://github.com/simonw/datasette/issues/1579#issuecomment-1000479737 https://api.github.com/repos/simonw/datasette/issues/1579 IC_kwDOBm6k_c47ohv5 simonw 9599 2021-12-23T19:04:23Z 2021-12-23T19:04:23Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `.execute_write(... block=True)` should be the default behaviour 1087931918  
1000477813 https://github.com/simonw/datasette/issues/1579#issuecomment-1000477813 https://api.github.com/repos/simonw/datasette/issues/1579 IC_kwDOBm6k_c47ohR1 simonw 9599 2021-12-23T18:59:41Z 2021-12-23T18:59:41Z OWNER

I'm going to go with execute_write(..., block=False) as the mechanism for fire-and-forget write queries.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `.execute_write(... block=True)` should be the default behaviour 1087931918  
1000477621 https://github.com/simonw/datasette/issues/1579#issuecomment-1000477621 https://api.github.com/repos/simonw/datasette/issues/1579 IC_kwDOBm6k_c47ohO1 simonw 9599 2021-12-23T18:59:12Z 2021-12-23T18:59:12Z OWNER

The easiest way to change this would be to default to block=True such that you need to pass block=False to the APIs to have them do fire-and-forget.

An alternative would be to add new, separately named methods which do the fire-and-forget thing.

If I hadn't recently added execute_write_script and execute_write_many in #1570 I'd be more into this idea, but I don't want to end up with eight methods - execute_write, execute_write_queue, execute_write_many, execute_write_many_queue, execute_write_script, execute_write_scrript_queue, execute_write_fn, execute_write_fn_queue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `.execute_write(... block=True)` should be the default behaviour 1087931918  
1000476413 https://github.com/simonw/datasette/issues/1579#issuecomment-1000476413 https://api.github.com/repos/simonw/datasette/issues/1579 IC_kwDOBm6k_c47og79 simonw 9599 2021-12-23T18:56:06Z 2021-12-23T18:56:06Z OWNER

This is technically a breaking change, but a GitHub code search at https://cs.github.com/?scopeName=All+repos&scope=&q=execute_write%20datasette%20-owner%3Asimonw shows only one repo not-owned-by-me using this, and they're using block=True: https://github.com/mfa/datasette-webhook-write/blob/e82440f372a2f2e3ed27d1bd34c9fa3a53b49b94/datasette_webhook_write/init.py#L88-L89

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `.execute_write(... block=True)` should be the default behaviour 1087931918  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);