issue_comments

Table actions

4 rows where author_association = "OWNER" and issue = 1145882578 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • `deterministic=True` fails on versions of SQLite prior to 3.8.3 · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1056001414 https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1056001414 https://api.github.com/repos/simonw/sqlite-utils/issues/408 IC_kwDOCGYnMM4-8U2G simonw 9599 2022-03-02T00:20:26Z 2022-03-02T00:20:26Z OWNER

I need a db.sqlite_version property to implement this check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `deterministic=True` fails on versions of SQLite prior to 3.8.3 1145882578  
1055996626 https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055996626 https://api.github.com/repos/simonw/sqlite-utils/issues/408 IC_kwDOCGYnMM4-8TrS simonw 9599 2022-03-02T00:12:21Z 2022-03-02T00:12:21Z OWNER

Here's the SQLite changelog mentioning that it was added in 3.8.3: https://www.sqlite.org/changes.html#version_3_8_3

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `deterministic=True` fails on versions of SQLite prior to 3.8.3 1145882578  
1055995100 https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055995100 https://api.github.com/repos/simonw/sqlite-utils/issues/408 IC_kwDOCGYnMM4-8TTc simonw 9599 2022-03-02T00:10:41Z 2022-03-02T00:10:41Z OWNER

Here's the code in question:

https://github.com/simonw/sqlite-utils/blob/521921b849003ed3742338f76f9d47ff3d95eaf3/sqlite_utils/db.py#L384-L394

It's checking for Python 3.8, because that's the version of Python that added the deterministic=True option: https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.create_function

But from your error message it looks like it should be checking the SQLite version too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `deterministic=True` fails on versions of SQLite prior to 3.8.3 1145882578  
1055993700 https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055993700 https://api.github.com/repos/simonw/sqlite-utils/issues/408 IC_kwDOCGYnMM4-8S9k simonw 9599 2022-03-02T00:08:10Z 2022-03-02T00:08:10Z OWNER

I thought I'd made it so deterministic=True would be silently ignored in environments that don't support it, but clearly I missed a case here!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `deterministic=True` fails on versions of SQLite prior to 3.8.3 1145882578  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);