issue_comments

Table actions

3 rows where author_association = "OWNER" and issue = 1175690070 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Reconsider ensure_permissions() logic, can it be less confusing? · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1074378472 https://github.com/simonw/datasette/issues/1676#issuecomment-1074378472 https://api.github.com/repos/simonw/datasette/issues/1676 IC_kwDOBm6k_c5ACbbo simonw 9599 2022-03-21T20:18:10Z 2022-03-21T20:18:10Z OWNER

Maybe there is a better name for this method that helps emphasize its cascading nature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Reconsider ensure_permissions() logic, can it be less confusing? 1175690070  
1074180312 https://github.com/simonw/datasette/issues/1676#issuecomment-1074180312 https://api.github.com/repos/simonw/datasette/issues/1676 IC_kwDOBm6k_c5ABrDY simonw 9599 2022-03-21T17:16:45Z 2022-03-21T17:16:45Z OWNER

When looking at this code earlier I assumed that the following would check each permission in turn and fail if any of them failed: python await self.ds.ensure_permissions( request.actor, [ ("view-table", (database, table)), ("view-database", database), "view-instance", ] ) But it's not quite that simple: if any of them fail, it fails... but if an earlier one returns True the whole stack passes even if there would have been a failure later on!

If that is indeed the right abstraction, I need to work to make the documentation as clear as possible.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Reconsider ensure_permissions() logic, can it be less confusing? 1175690070  
1074178865 https://github.com/simonw/datasette/issues/1676#issuecomment-1074178865 https://api.github.com/repos/simonw/datasette/issues/1676 IC_kwDOBm6k_c5ABqsx simonw 9599 2022-03-21T17:15:27Z 2022-03-21T17:15:27Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Reconsider ensure_permissions() logic, can it be less confusing? 1175690070  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);