issue_comments

Table actions

2 rows where author_association = "OWNER", issue = 1177101697 and user = 9599 sorted by updated_at descending

✖
✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • simonw · 2 ✖

issue 1

  • Potential bug in numeric handling where_clause for filters · 2 ✖

author_association 1

  • OWNER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1075438684 https://github.com/simonw/datasette/issues/1681#issuecomment-1075438684 https://api.github.com/repos/simonw/datasette/issues/1681 IC_kwDOBm6k_c5AGeRc simonw 9599 2022-03-22T17:45:50Z 2022-03-22T17:49:09Z OWNER

I would expect this to break against SQL views that include calculated columns though - something like this:

sql create view this_will_break as select pk + 1 as pk_plus_one, 0.5 as score from searchable; Confirmed: the filter interface for that view plain doesn't work for any comparison against that table - except for score > 0 since 0 is converted to an integer. 0.1 breaks though because it doesn't get converted as it doesn't match .isdigit().

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Potential bug in numeric handling where_clause for filters 1177101697  
1075437598 https://github.com/simonw/datasette/issues/1681#issuecomment-1075437598 https://api.github.com/repos/simonw/datasette/issues/1681 IC_kwDOBm6k_c5AGeAe simonw 9599 2022-03-22T17:44:42Z 2022-03-22T17:45:04Z OWNER

My hunch is that this mechanism doesn't actually do anything useful at all, because of the type conversion that automatically happens for data from tables based on the column type affinities, see: - #1671

So either remove the self.numeric type conversion bit entirely, or prove that it is necessary and upgrade it to be able to handle floating point values too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Potential bug in numeric handling where_clause for filters 1177101697  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);